From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.] Date: Tue, 13 Dec 2016 10:34:03 +0100 Message-ID: <87k2b4jhpw.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20161211181237.24485-1-ng0@libertad.pw> <20161211181237.24485-6-ng0@libertad.pw> <20161211223454.GA9474@jasmine> <871sxem5ix.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87mvg1k2f3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20161212154412.GA25907@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGjUK-0001NY-LO for bug-guix@gnu.org; Tue, 13 Dec 2016 04:35:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGjUE-0005hs-TO for bug-guix@gnu.org; Tue, 13 Dec 2016 04:35:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52947) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cGjUE-0005hQ-LY for bug-guix@gnu.org; Tue, 13 Dec 2016 04:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cGjUE-0005by-Ce for bug-guix@gnu.org; Tue, 13 Dec 2016 04:35:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Hartmut Goebel , Leo Famulari Cc: 25177@debbugs.gnu.org --=-=-= Content-Type: text/plain Hartmut Goebel writes: > First of all thanks for spotting this bug. > >>> The bad news is that we have some breakages. >>> >>> 'python-py' fails with: >>> >>> TypeError: py.test.__dict__ is not a dictionary >>> >>> Which seems similar to >>> >>> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144 > > The relevant comment is > https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174196194: > Starting with version 18.4, setuptools will always try to execute a > test-suite (see > https://setuptools.readthedocs.io/en/latest/history.html#id186), which > will fail if there is none. > > So the solution is to disable the test-suite for python-py, as there is > no test-suite which can be run via "setup.py test". For testing I added > "python-setuptools" (18.3.1) as native input. This made the "check" > phase run "0 tests" for python2-py and no tests at al for python-py. > > (This package includes a test-suite (see tox.ini), but this test-suite > requires py.test, with itself requires python-py. So I suggest to > disable it.) I tried upgrading pytest to 3.0.5 and adding a variant that does not propagate 'python-py' as input for the 'python-py' package. That got a bit further, but it does not accept modules from the store! "ImportError: 'test' module incorrectly imported from '/gnu/store/mwci3544rk71p131mgri5am0sxbz09a6-python-pytest-minimal-3.0.5/lib/python3.5/site-packages'. Expected '/tmp/guix-build-python-py-1.4.31.drv-0/py-1.4.31/py'. Is this module globally installed?" Disabled tests for now. > Our Python (3.5.2) comes with setuptools 20.10.1. Is the 2.7 variant the same version? When adding "python-setuptools" as native-input, is it guaranteed to override the bundled one? >> Yikes, I had hoped to avoid addressing that Nix issue and the humongous >> "fix" for a while longer: >> >> https://github.com/NixOS/nixpkgs/pull/12552 > > This puill-request is huge, but for setuptools, it comes down that they > updated from 18.2 to 19.4. Sounds like we're going down the same road. I've started a branch with the earlier patch and a few other fixes. Is it ok to overwrite the existing 'python-updates' branch on Savannah? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhPwIsACgkQoqBt8qM6 VPpH3wgAqPuR4cY+2QU53eQ4qHGsU336r1gJ7lVgMjW68G7Cx8FnwYmqF5VkCvol zjiCXUDbKZa/UHtBbbFhGJmRDiPG9VxcQBMHBXaknVKY9XvWpGbNlY6j3/VCMV81 cE1C7fA+Dqros9awZdkudmrvipUapekphcSuDdUImK8KupVkZYpGduVuPn6IX9eN nP5mF70VxZjvn2wtq5NgEIfddFosLcI//U3jGyUz2V68zAmztLG4w3XBEen+RBr7 pboJ3q7tPxI7clSAi48M6z3YUoUc7q4xkWNH0YTZ0ybaGgT+uYOM2KcOwvkGHiHK S+ULq0N6msqngkzyAwScriOVlPub8w== =eLJ/ -----END PGP SIGNATURE----- --=-=-=--