From: ludo@gnu.org (Ludovic Courtès)
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org, 30706@debbugs.gnu.org
Subject: bug#30706: Nginx service fails
Date: Mon, 05 Mar 2018 11:09:34 +0100 [thread overview]
Message-ID: <87k1uqbzq9.fsf__10201.4264361516$1520244511$gmane$org@gnu.org> (raw)
In-Reply-To: <20180304230637.GA24077@jurong> (Andreas Enge's message of "Mon, 5 Mar 2018 00:06:37 +0100")
Andreas Enge <andreas@enge.fr> skribis:
> guix system: loading new services: user-homes term-auto nginx...
> shepherd: Evaluating user expression (register-services (primitive-load "/gnu/st?") ?).
> guix system: error: exception caught while executing 'eval' on service 'root':
> find-long-options: unbound variable
The problem we have here is that the agetty service expects
‘find-long-options’ from linux-boot.scm, and it expects it at the top
level.
So what happens above is that we evaluate in PID 1 code like:
(make <service>
;; …
#:start (let ((tty … (find-long-options …) …))
…))
If you run this on an “old” GuixSD, ‘find-long-options’ is undefined.
Thus the whole (register-services …) expression fails to evaluate, and
we end up with some of the services missing.
Conclusions:
1. ‘guix system reconfigure’ should probably register services one by
one so that if one of the service expressions is erroneous, we
don’t bork everything. See ‘upgrade-shepherd-services’.
2. IWBN to delay execution of this whole default-tty thing to the
#:start method. Ideas, Danny?
In general we should do as little as possible at the top level in the
Shepherd config file.
Ludo’.
next prev parent reply other threads:[~2018-03-05 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180304222749.GA23799@jurong>
2018-03-04 23:06 ` Nginx service fails Andreas Enge
2018-03-05 7:23 ` bug#30706: " Ricardo Wurmus
2018-03-05 7:43 ` Andreas Enge
2018-03-05 10:09 ` Ludovic Courtès [this message]
[not found] ` <87k1uqbzq9.fsf@gnu.org>
2018-03-06 16:24 ` Danny Milosavljevic
2018-03-10 15:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87k1uqbzq9.fsf__10201.4264361516$1520244511$gmane$org@gnu.org' \
--to=ludo@gnu.org \
--cc=30706@debbugs.gnu.org \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).