From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#33100: [libssh] fatal: dumb http transport does not support
	shallow capabilities
Date: Wed, 24 Oct 2018 21:44:40 -0400
Message-ID: <87k1m63ilz.fsf@gmail.com>
References: <87zhv94as1.fsf@gmail.com> <87in1w90iu.fsf@gnu.org>
	<87va5w3rtj.fsf@gmail.com> <875zxupapd.fsf@gnu.org>
	<87o9bj33e4.fsf@gmail.com> <20181024141523.GB5988@jasmine.lan>
	<87h8hbyqr4.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gFUhv-0001fQ-7D
	for bug-guix@gnu.org; Wed, 24 Oct 2018 21:45:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gFUhq-00018B-6S
	for bug-guix@gnu.org; Wed, 24 Oct 2018 21:45:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36830)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gFUhq-000182-0Y
	for bug-guix@gnu.org; Wed, 24 Oct 2018 21:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gFUhp-0000HL-QU
	for bug-guix@gnu.org; Wed, 24 Oct 2018 21:45:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33100.D33100.15404318901039@debbugs.gnu.org>
In-Reply-To: <87h8hbyqr4.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Wed, 24 Oct 2018 23:33:03 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 33100-done@debbugs.gnu.org

ludo@gnu.org (Ludovic Court=C3=A8s) writes:

> Leo Famulari <leo@famulari.name> skribis:
>
>> On Wed, Oct 24, 2018 at 09:01:07AM -0400, Maxim Cournoyer wrote:
>>> From 06ba66d1949ba59573518f471ad3cbacefea6ea2 Mon Sep 17 00:00:00 2001
>>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>>> Date: Wed, 24 Oct 2018 08:49:50 -0400
>>> Subject: [PATCH] build: git-fetch: Print message when falling back to a=
 full
>>>  checkout.
>>>=20
>>> Otherwise the user might believe that git-fetch stalled, observing the =
lack of
>>> output following a 'fatal' git error message (see:
>>> https://debbugs.gnu.org/33100).
>>>=20
>>> * guix/build/git.scm (git-fetch): Print message when falling back to a =
full
>>> checkout.
>>
>> I like it, but it doesn't seem to actually print anything for me when I
>> trigger the failing case, for example by fetching the libssh source over
>> HTTP.
>
> If might be that current-output-port is fully buffered.  What if you
> add:
>
>   (setvbuf (current-output-port) 'line)
>
> before the =E2=80=98format=E2=80=99 call?
>
> Thanks,
> Ludo=E2=80=99, who is found guilty of not actually running the code.

What is preferable, between your solution or using (force-output)?

I'll send a revised patch accordingly.

Thank you,

Maxim