From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#33310: Cuirass: Evaluations adding no new builds are displayed as
	"failing"
Date: Sun, 11 Nov 2018 14:37:05 +0100
Message-ID: <87k1ljspku.fsf@gnu.org>
References: <87y3a352w1.fsf@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLpwB-0000Br-HY
	for bug-guix@gnu.org; Sun, 11 Nov 2018 08:38:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLpwA-0002oo-PP
	for bug-guix@gnu.org; Sun, 11 Nov 2018 08:38:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41134)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gLpwA-0002oc-LU
	for bug-guix@gnu.org; Sun, 11 Nov 2018 08:38:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLpwA-0006SG-Hi
	for bug-guix@gnu.org; Sun, 11 Nov 2018 08:38:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33310.B.154194343724753@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50457)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gLpvI-0008Dw-6K
	for bug-guix@gnu.org; Sun, 11 Nov 2018 08:37:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1gLpvH-0001Ua-Ie
	for bug-guix@gnu.org; Sun, 11 Nov 2018 08:37:08 -0500
In-Reply-To: <87y3a352w1.fsf@lassieur.org> ("=?UTF-8?Q?Cl=C3=A9ment?=
	Lassieur"'s message of "Thu, 08 Nov 2018 10:34:22 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: 33310@debbugs.gnu.org

Hello,

Cl=C3=A9ment Lassieur <clement@lassieur.org> skribis:

> Evaluations adding no new builds are displayed as "failing".  I know
> this was done on purpose, but I think the check should be done on the
> number of jobs returned by the evaluator, rather than on the number of
> builds registered in the database.

Indeed, that makes sense.  For the record the faulty code was added in
commit 0b40dca734468e8b12b3ff58e3e779679f17d38e.  As I wrote there, it
would be ideal to have a =E2=80=9Cfailed=E2=80=9D bit in the database, and,=
 even better,
to save the output of =E2=80=98evaluate=E2=80=99.

Thanks,
Ludo=E2=80=99.