bug#33623: Backtrace when running `guix system roll-back'

bug#33623: Backtrace when running `guix system roll-back'

[Diego Nicola Barbato]

Hello Guix,

When I run ‘guix system roll-back’ I get the following backtrace:

--8<---------------cut here---------------start------------->8---
root@tapuakh ~# guix system roll-back
Backtrace:
          10 (primitive-load "/root/.config/guix/current/bin/guix")
In guix/ui.scm:
  1603:12  9 (run-guix-command _ . _)
In ice-9/boot-9.scm:
    829:9  8 (catch srfi-34 #<procedure 341ea60 at guix/ui.scm:615:…> …)
    829:9  7 (catch system-error #<procedure 341eb00 at guix/script…> …)
In guix/scripts/system.scm:
   1268:8  6 (_)
In guix/status.scm:
    615:4  5 (call-with-status-report _ _)
In guix/scripts/system.scm:
   1208:9  4 (process-command _ _ _)
   469:10  3 (switch-to-system-generation #<build-daemon 256.99 1ec…> …)
In guix/store.scm:
  1659:24  2 (run-with-store _ _ #:guile-for-build _ #:system _ # _)
In guix/scripts/system.scm:
    499:6  1 (_ _)
In unknown file:
           0 (_ #<build-daemon 256.99 1ec03c0>)

ERROR: Wrong type to apply: #<<computed-file> name: "grub.cfg" gexp: #<gexp  3971ab0> guile: #f options: (#:local-build? #t)>
--8<---------------cut here---------------end--------------->8---

I run GuixSD (commit: 1f51f0d975d95a2ba645193cf43d0a294d952e83) on an
x86_64 machine.

Greetings

Diego

bug#33623: Backtrace when running `guix system roll-back'

[swedebugia]

On 2018-12-05 12:36, Diego Nicola Barbato wrote:
> Hello Guix,
> 
> When I run ‘guix system roll-back’ I get the following backtrace:
> 
> --8<---------------cut here---------------start------------->8---
> root@tapuakh ~# guix system roll-back
> Backtrace:
>           10 (primitive-load "/root/.config/guix/current/bin/guix")
> In guix/ui.scm:
>   1603:12  9 (run-guix-command _ . _)
> In ice-9/boot-9.scm:
>     829:9  8 (catch srfi-34 #<procedure 341ea60 at guix/ui.scm:615:…> …)
>     829:9  7 (catch system-error #<procedure 341eb00 at guix/script…> …)
> In guix/scripts/system.scm:
>    1268:8  6 (_)
> In guix/status.scm:
>     615:4  5 (call-with-status-report _ _)
> In guix/scripts/system.scm:
>    1208:9  4 (process-command _ _ _)
>    469:10  3 (switch-to-system-generation #<build-daemon 256.99 1ec…> …)
> In guix/store.scm:
>   1659:24  2 (run-with-store _ _ #:guile-for-build _ #:system _ # _)
> In guix/scripts/system.scm:
>     499:6  1 (_ _)
> In unknown file:
>            0 (_ #<build-daemon 256.99 1ec03c0>)
> 
> ERROR: Wrong type to apply: #<<computed-file> name: "grub.cfg" gexp:
> #<gexp  3971ab0> guile: #f options: (#:local-build? #t)>
> --8<---------------cut here---------------end--------------->8---
> 
> I run GuixSD (commit: 1f51f0d975d95a2ba645193cf43d0a294d952e83) on an
> x86_64 machine.

Interesting. Could you provide a config.scm to help us reproduce the
issue?

-- 
Cheers 
Swedebugia

bug#33623: Backtrace when running `guix system roll-back'

[Diego Nicola Barbato]

[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]

Hello Swedebugia,

swedebugia@riseup.net writes:

> On 2018-12-05 12:36, Diego Nicola Barbato wrote:
>> Hello Guix,
>> 
>> When I run ‘guix system roll-back’ I get the following backtrace:
>> 
>> --8<---------------cut here---------------start------------->8---
>> root@tapuakh ~# guix system roll-back
>> Backtrace:
>>           10 (primitive-load "/root/.config/guix/current/bin/guix")
>> In guix/ui.scm:
>>   1603:12  9 (run-guix-command _ . _)
>> In ice-9/boot-9.scm:
>>     829:9  8 (catch srfi-34 #<procedure 341ea60 at guix/ui.scm:615:…> …)
>>     829:9  7 (catch system-error #<procedure 341eb00 at guix/script…> …)
>> In guix/scripts/system.scm:
>>    1268:8  6 (_)
>> In guix/status.scm:
>>     615:4  5 (call-with-status-report _ _)
>> In guix/scripts/system.scm:
>>    1208:9  4 (process-command _ _ _)
>>    469:10  3 (switch-to-system-generation #<build-daemon 256.99 1ec…> …)
>> In guix/store.scm:
>>   1659:24  2 (run-with-store _ _ #:guile-for-build _ #:system _ # _)
>> In guix/scripts/system.scm:
>>     499:6  1 (_ _)
>> In unknown file:
>>            0 (_ #<build-daemon 256.99 1ec03c0>)
>> 
>> ERROR: Wrong type to apply: #<<computed-file> name: "grub.cfg" gexp:
>> #<gexp  3971ab0> guile: #f options: (#:local-build? #t)>
>> --8<---------------cut here---------------end--------------->8---
>> 
>> I run GuixSD (commit: 1f51f0d975d95a2ba645193cf43d0a294d952e83) on an
>> x86_64 machine.
>
> Interesting. Could you provide a config.scm to help us reproduce the
> issue?

I've got something better.

Steps to reproduce:

Install GuixSD in a VM using the iso image and the attached config.  The
image should be at least 16G (8G is to small for a reconfigure).

Reboot the VM.

Run ‘guix pull --commit=1f51f0’ as root.

Make sure to log out and back in again to avoid bug#33647.

Run ‘guix system reconfigure /etc/config.scm’.

Reboot the VM.

Run ‘guix system roll-back’ as root.

Backtrace ensues.


Greetings

Diego


[-- Attachment #2: config.scm --]
[-- Type: application/octet-stream, Size: 1702 bytes --]

;; This is an operating system configuration template;; for a "desktop" setup with GNOME and Xfce where the
;; root partition is encrypted with LUKS.

(use-modules (gnu) (gnu system nss))
(use-service-modules desktop)
(use-package-modules certs emacs gnome xorg)

(operating-system
  (host-name "antelope")
  (timezone "Europe/Paris")
  (locale "en_US.utf8")

  (bootloader (bootloader-configuration
                (bootloader grub-bootloader)
                (target "/dev/sda")))

  (file-systems (cons (file-system
                        (device (file-system-label "my-root"))
                        (mount-point "/")
                        (type "ext4"))
                      %base-file-systems))

  (users (cons (user-account
                (name "bob")
                (comment "Alice's brother")
                (group "users")
                (supplementary-groups '("wheel" "netdev"
                                        "audio" "video"))
                (home-directory "/home/bob"))
               %base-user-accounts))

  ;; This is where we specify system-wide packages.
  (packages (cons* nss-certs         ;for HTTPS access
                   gvfs              ;for user mounts
                   emacs emacs-exwm
                   setxkbmap
                   %base-packages))

  ;; Add GNOME and/or Xfce---we can choose at the log-in
  ;; screen with F1.  Use the "desktop" services, which
  ;; include the X11 log-in service, networking with
  ;; NetworkManager, and more.
  (services (cons* (console-keymap-service "de_CH-latin1")
                   %desktop-services))

  ;; Allow resolution of '.local' host names with mDNS.
  (name-service-switch %mdns-host-lookup-nss))

bug#33623: Backtrace when running `guix system roll-back'

[Diego Nicola Barbato]

Diego Nicola Barbato <dnbarbato@posteo.de> writes:

> Hello Swedebugia,
>
> swedebugia@riseup.net writes:
>
>> On 2018-12-05 12:36, Diego Nicola Barbato wrote:
>>> Hello Guix,
>>> 
>>> When I run ‘guix system roll-back’ I get the following backtrace:
>>> 
>>> --8<---------------cut here---------------start------------->8---
>>> root@tapuakh ~# guix system roll-back
>>> Backtrace:
>>>           10 (primitive-load "/root/.config/guix/current/bin/guix")
>>> In guix/ui.scm:
>>>   1603:12  9 (run-guix-command _ . _)
>>> In ice-9/boot-9.scm:
>>>     829:9  8 (catch srfi-34 #<procedure 341ea60 at guix/ui.scm:615:…> …)
>>>     829:9  7 (catch system-error #<procedure 341eb00 at guix/script…> …)
>>> In guix/scripts/system.scm:
>>>    1268:8  6 (_)
>>> In guix/status.scm:
>>>     615:4  5 (call-with-status-report _ _)
>>> In guix/scripts/system.scm:
>>>    1208:9  4 (process-command _ _ _)
>>>    469:10  3 (switch-to-system-generation #<build-daemon 256.99 1ec…> …)
>>> In guix/store.scm:
>>>   1659:24  2 (run-with-store _ _ #:guile-for-build _ #:system _ # _)
>>> In guix/scripts/system.scm:
>>>     499:6  1 (_ _)
>>> In unknown file:
>>>            0 (_ #<build-daemon 256.99 1ec03c0>)
>>> 
>>> ERROR: Wrong type to apply: #<<computed-file> name: "grub.cfg" gexp:
>>> #<gexp  3971ab0> guile: #f options: (#:local-build? #t)>
>>> --8<---------------cut here---------------end--------------->8---
>>> 
>>> I run GuixSD (commit: 1f51f0d975d95a2ba645193cf43d0a294d952e83) on an
>>> x86_64 machine.
>>
>> Interesting. Could you provide a config.scm to help us reproduce the
>> issue?
>
> I've got something better.
>
> Steps to reproduce:
>
> Install GuixSD in a VM using the iso image and the attached config.  The
> image should be at least 16G (8G is to small for a reconfigure).
>
> Reboot the VM.
>
> Run ‘guix pull --commit=1f51f0’ as root.
>
> Make sure to log out and back in again to avoid bug#33647.
>
> Run ‘guix system reconfigure /etc/config.scm’.
>
> Reboot the VM.
>
> Run ‘guix system roll-back’ as root.
>
> Backtrace ensues.

I just repeated the aforementioned steps with the new (0.16.0) iso image
and by pulling from current master (5118e2) instead of 1f51f0 and got a
similar backtrace.  I believe ‘guix system roll-back’ is currently
broken on master.
Judging from the backtrace this might have something to do with the
recent clean up of system code (specifically commit 46c296).

Greetings

Diego

bug#33623: Backtrace when running `guix system roll-back'

[Ludovic Courtès]

Hi Diego,

Diego Nicola Barbato <dnbarbato@posteo.de> skribis:

> When I run ‘guix system roll-back’ I get the following backtrace:

Fixed in commit 6ddc63e599a26c302f74d0622f67cfd987f0dc5f, thanks!

Ludo'.

bug#33623: Backtrace when running `guix system roll-back'

[znavko]

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Hello! This is just an idea.
Is it possible to automatize detection of this kind of problems? 
As I see, some PC can has crontab job to do `guix pull`, so that if 'Backtrace' message occurs, it sends a report to developer not to rush up to push his branch to master branch.
Different branches can be defended from such a minor issues, just trying `guix pull` for all branches using channels. 


Dec 7, 2018, 2:15 PM by ludo@gnu.org:

> Hi Diego,
>
> Diego Nicola Barbato <> dnbarbato@posteo.de <mailto:dnbarbato@posteo.de>> > skribis:
>
>> When I run ‘guix system roll-back’ I get the following backtrace:
>>
>
> Fixed in commit 6ddc63e599a26c302f74d0622f67cfd987f0dc5f, thanks!
>
> Ludo'.
>


[-- Attachment #2: Type: text/html, Size: 1724 bytes --]

bug#33623: Backtrace when running `guix system roll-back'

[Ludovic Courtès]

Hello,

<znavko@tutanota.com> skribis:

> Is it possible to automatize detection of this kind of problems? 
> As I see, some PC can has crontab job to do `guix pull`, so that if 'Backtrace' message occurs, it sends a report to developer not to rush up to push his branch to master branch.

There are lots of unit tests and system tests in Guix.  Unfortunately
this particular bit is not covered by a test.  We would need to come up
with a testing strategy for this but it can be quite challenging.

Ludo’.

bug#33623: Backtrace when running `guix system roll-back'

[swedebugia]

On 2018-12-07 15:15, Ludovic Courtès wrote:
> Hi Diego,
> 
> Diego Nicola Barbato <dnbarbato@posteo.de> skribis:
> 
>> When I run ‘guix system roll-back’ I get the following backtrace:
> 
> Fixed in commit 6ddc63e599a26c302f74d0622f67cfd987f0dc5f, thanks!
> 
> Ludo'.

Good catch Diego! 

-- 
Cheers 
Swedebugia