From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#33378: offload: Avoid hosts with little or no free disk space
Date: Sun, 23 Dec 2018 21:58:49 +0100
Message-ID: <87k1k0gdti.fsf@gnu.org>
References: <87ftw3hio6.fsf@gnu.org> <87r2ealci0.fsf@gnu.org>
	<8736qoi2hf.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:55551)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gbAq5-0000jp-Oi
	for bug-guix@gnu.org; Sun, 23 Dec 2018 15:59:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gbAq0-0001zY-Kn
	for bug-guix@gnu.org; Sun, 23 Dec 2018 15:59:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:58045)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gbApz-0001mN-2r
	for bug-guix@gnu.org; Sun, 23 Dec 2018 15:59:04 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gbApx-0003bZ-UB
	for bug-guix@gnu.org; Sun, 23 Dec 2018 15:59:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33378.B33378.154559873513845@debbugs.gnu.org>
In-Reply-To: <8736qoi2hf.fsf@netris.org> (Mark H. Weaver's message of "Sun, 23
	Dec 2018 12:20:17 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: 33378@debbugs.gnu.org

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> ludo@gnu.org (Ludovic Court=C3=A8s) skribis:
>>
>>> =E2=80=98choose-build-machine=E2=80=99 in (guix scripts offload) could/=
should exclude
>>> build machines that don=E2=80=99t have at least, say, 100=C2=A0MiB avai=
lable in their
>>> store.  That would avoid ENOSPC build failures such as
>>> <https://berlin.guixsd.org/log/0hvhrfdjwnmdm2rdf58knshbbikm4ryv-r-bsgen=
ome-hsapiens-ucsc-hg19-masked-1.3.99>.
>>
>> Done in commit 63b0c3eaccdf1816b419632cd7fe721934d2eb27.
>
> Many builds require more free space than 100 MB, so this is only a
> partial solution.  Also, if multiple builds are happening on the same
> machine, the amount of free space available for each build will be less
> than 100 MB.

You=E2=80=99re right, but this at least avoids the most obvious problems.

> Finally, the other related commit that attempts to detect build failures
> caused by ENOSPC by checking if there's at least 10 MB free after the
> failure won't often work in practice, I suspect.  The problem is, by the
> time you perform that check, the build directory has already been
> deleted.

Correct.  (I wasn=E2=80=99t sure the build directory would already be delet=
ed at
that point but rereading build.cc confirms this.)

I suppose the only way to solve this correctly would be to keep the
build tree and then delete it from (guix scripts offload).  WDYT?

Thanks for your feedback!

Ludo=E2=80=99.