From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: bug#35606: Gajim Date: Mon, 13 May 2019 09:04:26 +0200 Message-ID: <87k1eu96o5.fsf@elephly.net> References: <2c0eb096ca89fb61764045b35d8c695d@disroot.org> <87y33jfk22.fsf@nckx> <87ftpqdp2d.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:42853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQ53l-0002II-0S for bug-guix@gnu.org; Mon, 13 May 2019 03:07:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQ52A-00017c-PD for bug-guix@gnu.org; Mon, 13 May 2019 03:06:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58607) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQ52A-00017P-I2 for bug-guix@gnu.org; Mon, 13 May 2019 03:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hQ52A-0006mL-AR for bug-guix@gnu.org; Mon, 13 May 2019 03:06:02 -0400 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-reply-to: <87ftpqdp2d.fsf@elephly.net> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Tobias Geerinckx-Rice Cc: 35606-done@debbugs.gnu.org, =?UTF-8?Q?Cl=C3=A9ment?= Lassieur , Raghav Gururajan Ricardo Wurmus writes: > Tobias Geerinckx-Rice writes: > >> Traceback (most recent call last): >> File >> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/s= ite-packages/gajim/application.py", >> line 221, in _activate >> self.interface.run(self) >> File >> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/s= ite-packages/gajim/gui_interface.py", >> line 2550, in run >> app.plugin_manager =3D plugins.PluginManager() >> File >> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/s= ite-packages/gajim/plugins/helpers.py", >> line 129, in __call__ >> cls.instance =3D super(Singleton, cls).__call__(*args, **kwargs) >> File >> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/s= ite-packages/gajim/plugins/pluginmanager.py", >> line 115, in __init__ >> pc =3D self.scan_dir_for_plugins(path) >> File >> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/s= ite-packages/gajim/plugins/helpers.py", >> line 114, in wrapper >> result =3D f(*args, **kwargs) >> File >> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/s= ite-packages/gajim/plugins/pluginmanager.py", >> line 598, in scan_dir_for_plugins >> if not os.path.isdir(path): >> File >> "/gnu/store/h8l1pby3cm6b4fxsfwwr65b4d1hyh6cs-python-3.7.0/lib/python3.7/= genericpath.py", >> line 42, in isdir >> st =3D os.stat(s) >> TypeError: stat: path should be string, bytes, os.PathLike or integer, > > This is a problem with the =E2=80=9Cadd-plugin-dirs=E2=80=9D phase. Afte= r setting > GAJIM_PLUGIN_PATH to =E2=80=9C/tmp=E2=80=9D Gajim seems to work fine for = me. > > We need to make sure that even without setting GAJIM_PLUGIN_PATH =E2=80= =9Cpath=E2=80=9D > is a string. I fixed this with commit a624c3631077aa3fa5c05849579932c5b67b985c. When GAJIM_PLUGIN_PATH is not set it will not be added to the list of directories that are searched for plugins. -- Ricardo