bug#35606: Gajim

bug#35606: Gajim

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

## Versions
- OS: Linux
- GTK+ Version: 3.24.7
- PyGObject Version: 3.28.3
- python-nbxmpp Version: 0.6.10
- Gajim Version: 1.1.3

## Traceback
```
Traceback (most recent call last):
 File "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/application.py", line 221, in _activate
 self.interface.run(self)
 File "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/gui_interface.py", line 2550, in run
 app.plugin_manager = plugins.PluginManager()
 File "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py", line 129, in __call__
 cls.instance = super(Singleton, cls).__call__(*args, **kwargs)
 File "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py", line 115, in __init__
 pc = self.scan_dir_for_plugins(path)
 File "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py", line 114, in wrapper
 result = f(*args, **kwargs)
 File "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py", line 598, in scan_dir_for_plugins
 if not os.path.isdir(path):
 File "/gnu/store/h8l1pby3cm6b4fxsfwwr65b4d1hyh6cs-python-3.7.0/lib/python3.7/genericpath.py", line 42, in isdir
 st = os.stat(s)
TypeError: stat: path should be string, bytes, os.PathLike or integer, not NoneType

```
## Steps to reproduce the problem

Install and open the app. This bug error shows up.

[-- Attachment #2: Type: text/html, Size: 1890 bytes --]

bug#35606: Gajim

[Tobias Geerinckx-Rice]

[-- Attachment #1: Type: text/plain, Size: 3994 bytes --]

Raghav, Clément, Ricardo, Guix,

Raghav Gururajan wrote:
> ## Versions
> - OS: Linux

Never heard of that OS…  ;-)

> - GTK+ Version: 3.24.7
> - PyGObject Version: 3.28.3
> - python-nbxmpp Version: 0.6.10
> - Gajim Version: 1.1.3

Thanks for these, but providing the output of ‘guix describe’ 
instead (and making sure both your system and user's packages have 
been fully updated to that version) would be even more 
informative.

> ## Traceback

I can't reproduce this, by the way (output below).  Gajim opens a 
window and a welcome wizard (which I close).  Then I'm left with 
the main window where all the menus work… but all options are 
greyed out (except a few under ‘View’).  So the programme isn't 
frozen, but I can't close it, not even using my window manager's 
key bindings.  Hence the SIGINT at the end.

Very strange.  Is anyone successfully using Gajim on Guix System? 
Clément?  Ricardo?

Kind regards,

T G-R


~ λ gajim
(..gajim-real-real:23682): dbind-WARNING **: 21:27:06.317: AT-SPI: 
Error retrieving accessibility bus address: 
org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus 
was not provided by any .service files
creating /home/nckx/.config/gajim directory
creating /home/nckx/.cache/gajim directory
creating /home/nckx/.local/share/gajim directory
creating /home/nckx/.local/share/gajim/certs directory
creating /home/nckx/.local/share/gajim/debug directory
creating /home/nckx/.local/share/gajim/plugins_data directory
creating /home/nckx/.config/gajim/pluginsconfig directory
creating /home/nckx/.config/gajim/localcerts directory
creating /home/nckx/.cache/gajim/plugins_download directory
creating /home/nckx/.local/share/gajim/plugins directory
creating /home/nckx/.cache/gajim/avatars directory
creating /home/nckx/.config/gajim/theme directory
Traceback (most recent call last):
  File 
  "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/application.py", 
  line 221, in _activate
    self.interface.run(self)
  File 
  "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/gui_interface.py", 
  line 2550, in run
    app.plugin_manager = plugins.PluginManager()
  File 
  "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py", 
  line 129, in __call__
    cls.instance = super(Singleton, cls).__call__(*args, **kwargs)
  File 
  "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py", 
  line 115, in __init__
    pc = self.scan_dir_for_plugins(path)
  File 
  "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py", 
  line 114, in wrapper
    result = f(*args, **kwargs)
  File 
  "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py", 
  line 598, in scan_dir_for_plugins
    if not os.path.isdir(path):
  File 
  "/gnu/store/h8l1pby3cm6b4fxsfwwr65b4d1hyh6cs-python-3.7.0/lib/python3.7/genericpath.py", 
  line 42, in isdir
    st = os.stat(s)
TypeError: stat: path should be string, bytes, os.PathLike or 
integer, not NoneType
06/05/19 21:27:07 (E) gajim.notify Notifications D-Bus connection 
failed
Traceback (most recent call last):
  File 
  "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/notify.py", 
  line 96, in on_proxy_ready
    self.daemon_capabilities = proxy.GetCapabilities()
  File 
  "/gnu/store/f34bv1iaghh7hsymqm57abi8p1lyavv6-python-pygobject-3.28.3/lib/python3.7/site-packages/gi/overrides/Gio.py", 
  line 204, in __call__
    None)
GLib.GError: g-dbus-error-quark: 
GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name 
org.freedesktop.Notifications was not provided by any .service 
files (2)
^CSIGINT/SIGTERM received
~ λ 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#35606: Gajim

[Raghav Gururajan]

T-G-R!

Oh my goodness, I didn't notice that. LoL. Of course the OS is GNU/Linux. ;). The bug report was automatically generated when I opened the app. I didn't create it.

Yes, as you said, nothing works. All menu greyed out. Can't even close the app.

May 6, 2019 7:40 PM, "Tobias Geerinckx-Rice" <me@tobias.gr> wrote:

> Raghav, Clément, Ricardo, Guix,
> 
> Raghav Gururajan wrote:
> 
>> ## Versions
>> - OS: Linux
> 
> Never heard of that OS… ;-)
> 
>> - GTK+ Version: 3.24.7
>> - PyGObject Version: 3.28.3
>> - python-nbxmpp Version: 0.6.10
>> - Gajim Version: 1.1.3
> 
> Thanks for these, but providing the output of ‘guix describe’
> instead (and making sure both your system and user's packages have
> been fully updated to that version) would be even more
> informative.
> 
>> ## Traceback
> 
> I can't reproduce this, by the way (output below). Gajim opens a
> window and a welcome wizard (which I close). Then I'm left with
> the main window where all the menus work… but all options are
> greyed out (except a few under ‘View’). So the programme isn't
> frozen, but I can't close it, not even using my window manager's
> key bindings. Hence the SIGINT at the end.
> 
> Very strange. Is anyone successfully using Gajim on Guix System?
> Clément? Ricardo?
> 
> Kind regards,
> 
> T G-R
> 
> ~ λ gajim
> (..gajim-real-real:23682): dbind-WARNING **: 21:27:06.317: AT-SPI:
> Error retrieving accessibility bus address:
> org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus
> was not provided by any .service files
> creating /home/nckx/.config/gajim directory
> creating /home/nckx/.cache/gajim directory
> creating /home/nckx/.local/share/gajim directory
> creating /home/nckx/.local/share/gajim/certs directory
> creating /home/nckx/.local/share/gajim/debug directory
> creating /home/nckx/.local/share/gajim/plugins_data directory
> creating /home/nckx/.config/gajim/pluginsconfig directory
> creating /home/nckx/.config/gajim/localcerts directory
> creating /home/nckx/.cache/gajim/plugins_download directory
> creating /home/nckx/.local/share/gajim/plugins directory
> creating /home/nckx/.cache/gajim/avatars directory
> creating /home/nckx/.config/gajim/theme directory
> Traceback (most recent call last):
> File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/applicati
> n.py",
> line 221, in _activate
> self.interface.run(self)
> File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/gui_inter
> ace.py",
> line 2550, in run
> app.plugin_manager = plugins.PluginManager()
> File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/h
> lpers.py",
> line 129, in __call__
> cls.instance = super(Singleton, cls).__call__(*args, **kwargs)
> File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/p
> uginmanager.py",
> line 115, in __init__
> pc = self.scan_dir_for_plugins(path)
> File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/h
> lpers.py",
> line 114, in wrapper
> result = f(*args, **kwargs)
> File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/p
> uginmanager.py",
> line 598, in scan_dir_for_plugins
> if not os.path.isdir(path):
> File
> "/gnu/store/h8l1pby3cm6b4fxsfwwr65b4d1hyh6cs-python-3.7.0/lib/python3.7/genericpath.py",
> line 42, in isdir
> st = os.stat(s)
> TypeError: stat: path should be string, bytes, os.PathLike or
> integer, not NoneType
> 06/05/19 21:27:07 (E) gajim.notify Notifications D-Bus connection
> failed
> Traceback (most recent call last):
> File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/notify.py
> ,
> line 96, in on_proxy_ready
> self.daemon_capabilities = proxy.GetCapabilities()
> File
> "/gnu/store/f34bv1iaghh7hsymqm57abi8p1lyavv6-python-pygobject-3.28.3/lib/python3.7/site-packages/gi/
> verrides/Gio.py",
> line 204, in __call__
> None)
> GLib.GError: g-dbus-error-quark:
> GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name
> org.freedesktop.Notifications was not provided by any .service
> files (2)
> ^CSIGINT/SIGTERM received
> ~ λ

bug#35606: Gajim

[Raghav Gururajan]

T-G-R!

One more interesting information. I had to close the Gajim by killing the process. What I noticed in "system monitor" is that the Gajim was running as root instead of that user. I retried, it is the same. Gajim runs as root. Weird.

May 6, 2019 7:45 PM, "Raghav Gururajan" <rvgn@disroot.org> wrote:

> T-G-R!
> 
> Oh my goodness, I didn't notice that. LoL. Of course the OS is GNU/Linux. ;). The bug report was
> automatically generated when I opened the app. I didn't create it.
> 
> Yes, as you said, nothing works. All menu greyed out. Can't even close the app.
> 
> May 6, 2019 7:40 PM, "Tobias Geerinckx-Rice" <me@tobias.gr> wrote:
> 
>> Raghav, Clément, Ricardo, Guix,
>> 
>> Raghav Gururajan wrote:
>> 
>>> ## Versions
>>> - OS: Linux
>> 
>> Never heard of that OS… ;-)
>> 
>>> - GTK+ Version: 3.24.7
>>> - PyGObject Version: 3.28.3
>>> - python-nbxmpp Version: 0.6.10
>>> - Gajim Version: 1.1.3
>> 
>> Thanks for these, but providing the output of ‘guix describe’
>> instead (and making sure both your system and user's packages have
>> been fully updated to that version) would be even more
>> informative.
>> 
>>> ## Traceback
>> 
>> I can't reproduce this, by the way (output below). Gajim opens a
>> window and a welcome wizard (which I close). Then I'm left with
>> the main window where all the menus work… but all options are
>> greyed out (except a few under ‘View’). So the programme isn't
>> frozen, but I can't close it, not even using my window manager's
>> key bindings. Hence the SIGINT at the end.
>> 
>> Very strange. Is anyone successfully using Gajim on Guix System?
>> Clément? Ricardo?
>> 
>> Kind regards,
>> 
>> T G-R
>> 
>> ~ λ gajim
>> (..gajim-real-real:23682): dbind-WARNING **: 21:27:06.317: AT-SPI:
>> Error retrieving accessibility bus address:
>> org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus
>> was not provided by any .service files
>> creating /home/nckx/.config/gajim directory
>> creating /home/nckx/.cache/gajim directory
>> creating /home/nckx/.local/share/gajim directory
>> creating /home/nckx/.local/share/gajim/certs directory
>> creating /home/nckx/.local/share/gajim/debug directory
>> creating /home/nckx/.local/share/gajim/plugins_data directory
>> creating /home/nckx/.config/gajim/pluginsconfig directory
>> creating /home/nckx/.config/gajim/localcerts directory
>> creating /home/nckx/.cache/gajim/plugins_download directory
>> creating /home/nckx/.local/share/gajim/plugins directory
>> creating /home/nckx/.cache/gajim/avatars directory
>> creating /home/nckx/.config/gajim/theme directory
>> Traceback (most recent call last):
>> File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/applicati
>> n.py",
>> line 221, in _activate
>> self.interface.run(self)
>> File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/gui_inter
>> ace.py",
>> line 2550, in run
>> app.plugin_manager = plugins.PluginManager()
>> File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/h
>> lpers.py",
>> line 129, in __call__
>> cls.instance = super(Singleton, cls).__call__(*args, **kwargs)
>> File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/p
>> uginmanager.py",
>> line 115, in __init__
>> pc = self.scan_dir_for_plugins(path)
>> File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/h
>> lpers.py",
>> line 114, in wrapper
>> result = f(*args, **kwargs)
>> File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/p
>> uginmanager.py",
>> line 598, in scan_dir_for_plugins
>> if not os.path.isdir(path):
>> File
>> "/gnu/store/h8l1pby3cm6b4fxsfwwr65b4d1hyh6cs-python-3.7.0/lib/python3.7/genericpath.py",
>> line 42, in isdir
>> st = os.stat(s)
>> TypeError: stat: path should be string, bytes, os.PathLike or
>> integer, not NoneType
>> 06/05/19 21:27:07 (E) gajim.notify Notifications D-Bus connection
>> failed
>> Traceback (most recent call last):
>> File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/notify.py
>> ,
>> line 96, in on_proxy_ready
>> self.daemon_capabilities = proxy.GetCapabilities()
>> File
>> "/gnu/store/f34bv1iaghh7hsymqm57abi8p1lyavv6-python-pygobject-3.28.3/lib/python3.7/site-packages/gi/
>> verrides/Gio.py",
>> line 204, in __call__
>> None)
>> GLib.GError: g-dbus-error-quark:
>> GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name
>> org.freedesktop.Notifications was not provided by any .service
>> files (2)
>> ^CSIGINT/SIGTERM received
>> ~ λ

bug#35606: Gajim

[Ricardo Wurmus]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Very strange.  Is anyone successfully using Gajim on Guix System?
> Clément?  Ricardo?

I used to use it, but some time ago I shut off my XMPP server because I
didn’t really need it.

I’ll try to bring it up again and then test if I can connect to it with
Gajim.  It does look a bit funny and not how I remember it.  The first
menu item is completely empty, which doesn’t seem right.

--
Ricardo

bug#35606: Gajim

[Ricardo Wurmus]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Traceback (most recent call last):
>  File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/application.py",
> line 221, in _activate
>    self.interface.run(self)
>  File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/gui_interface.py",
> line 2550, in run
>    app.plugin_manager = plugins.PluginManager()
>  File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py",
> line 129, in __call__
>    cls.instance = super(Singleton, cls).__call__(*args, **kwargs)
>  File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py",
> line 115, in __init__
>    pc = self.scan_dir_for_plugins(path)
>  File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py",
> line 114, in wrapper
>    result = f(*args, **kwargs)
>  File
> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py",
> line 598, in scan_dir_for_plugins
>    if not os.path.isdir(path):
>  File
> "/gnu/store/h8l1pby3cm6b4fxsfwwr65b4d1hyh6cs-python-3.7.0/lib/python3.7/genericpath.py",
> line 42, in isdir
>    st = os.stat(s)
> TypeError: stat: path should be string, bytes, os.PathLike or integer,

This is a problem with the “add-plugin-dirs” phase.  After setting
GAJIM_PLUGIN_PATH to “/tmp” Gajim seems to work fine for me.

We need to make sure that even without setting GAJIM_PLUGIN_PATH “path”
is a string.

-- 
Ricardo

bug#35606: Gajim

[Raghav Gururajan]

Hello Guix Folks!

Any update on this bug please?

Regards,
RG.

bug#35606: Gajim

[Ricardo Wurmus]

Raghav Gururajan <rvgn@disroot.org> writes:

> Any update on this bug please?

I’ve sent an update on Tuesday where I pointed out the likely culprit.
Have you attempted to confirm my findings?  What do you think about
changing the phase I pointed out to be incorrect?

--
Ricardo

bug#35606: Gajim

[Raghav Gururajan]

> I’ve sent an update on Tuesday where I pointed out the likely culprit.
> Have you attempted to confirm my findings? What do you think about
> changing the phase I pointed out to be incorrect?

Oops! I missed to read that email. My bad. Regarding empty menu, it same for me too. Regarding the path linking, I am not able to understand it. :(

bug#35606: Gajim

[Ricardo Wurmus]

Ricardo Wurmus <rekado@elephly.net> writes:

> Tobias Geerinckx-Rice <me@tobias.gr> writes:
>
>> Traceback (most recent call last):
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/application.py",
>> line 221, in _activate
>>    self.interface.run(self)
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/gui_interface.py",
>> line 2550, in run
>>    app.plugin_manager = plugins.PluginManager()
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py",
>> line 129, in __call__
>>    cls.instance = super(Singleton, cls).__call__(*args, **kwargs)
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py",
>> line 115, in __init__
>>    pc = self.scan_dir_for_plugins(path)
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/helpers.py",
>> line 114, in wrapper
>>    result = f(*args, **kwargs)
>>  File
>> "/gnu/store/lzzphfg2hf52h1cb2dbvz3qvz2ca26na-gajim-1.1.3/lib/python3.7/site-packages/gajim/plugins/pluginmanager.py",
>> line 598, in scan_dir_for_plugins
>>    if not os.path.isdir(path):
>>  File
>> "/gnu/store/h8l1pby3cm6b4fxsfwwr65b4d1hyh6cs-python-3.7.0/lib/python3.7/genericpath.py",
>> line 42, in isdir
>>    st = os.stat(s)
>> TypeError: stat: path should be string, bytes, os.PathLike or integer,
>
> This is a problem with the “add-plugin-dirs” phase.  After setting
> GAJIM_PLUGIN_PATH to “/tmp” Gajim seems to work fine for me.
>
> We need to make sure that even without setting GAJIM_PLUGIN_PATH “path”
> is a string.

I fixed this with commit a624c3631077aa3fa5c05849579932c5b67b985c.  When
GAJIM_PLUGIN_PATH is not set it will not be added to the list of
directories that are searched for plugins.

--
Ricardo

bug#35606: Gajim

[Raghav Gururajan]

> I fixed this with commit a624c3631077aa3fa5c05849579932c5b67b985c. When
> GAJIM_PLUGIN_PATH is not set it will not be added to the list of
> directories that are searched for plugins.

Thank you very much Ricardo! Just to be clear, the path get automatically added with this fix right?

bug#35606: Gajim

[Ricardo Wurmus]

Raghav Gururajan <rvgn@disroot.org> writes:

>> I fixed this with commit a624c3631077aa3fa5c05849579932c5b67b985c. When
>> GAJIM_PLUGIN_PATH is not set it will not be added to the list of
>> directories that are searched for plugins.
>
> Thank you very much Ricardo! Just to be clear, the path get
> automatically added with this fix right?

No.  I only made it so that when GAJIM_PLUGIN_PATH is not set it won’t
be added to the list of directories that Gajim looks at, so there’s no
crash.  If GAJIM_PLUGIN_PATH *is* set the directory it points at will be
added to the list.

--
Ricardo

bug#35606: Gajim

[Clément Lassieur]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

Thank you Ricardo for fixing and Raghav for reporting this bug I introduced!

Sorry not to have more time to work on it at the moment.

Clément

On Tue, May 14, 2019, 2:13 PM Ricardo Wurmus <rekado@elephly.net> wrote:

>
> Raghav Gururajan <rvgn@disroot.org> writes:
>
> >> I fixed this with commit a624c3631077aa3fa5c05849579932c5b67b985c. When
> >> GAJIM_PLUGIN_PATH is not set it will not be added to the list of
> >> directories that are searched for plugins.
> >
> > Thank you very much Ricardo! Just to be clear, the path get
> > automatically added with this fix right?
>
> No.  I only made it so that when GAJIM_PLUGIN_PATH is not set it won’t
> be added to the list of directories that Gajim looks at, so there’s no
> crash.  If GAJIM_PLUGIN_PATH *is* set the directory it points at will be
> added to the list.
>
> --
> Ricardo
>
>

[-- Attachment #2: Type: text/html, Size: 1362 bytes --]

bug#35606: Gajim

[Raghav Gururajan]

> Thank you Ricardo for fixing and Raghav for reporting this bug I introduced!
> 
> Sorry not to have more time to work on it at the moment.

All good :)

Regards,
RG.