From: "Ludovic Courtès" <ludo@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 40493@debbugs.gnu.org
Subject: bug#40493: installer: Provide a way to select multiple keyboard layouts
Date: Wed, 08 Apr 2020 15:22:34 +0200 [thread overview]
Message-ID: <87k12q5cyt.fsf@gnu.org> (raw)
In-Reply-To: <20200408095812.v3kuwakueh44g6mp@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Wed, 8 Apr 2020 11:58:12 +0200")
Hi,
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> skribis:
> The comma is needed, for example the Japanese Kana ("jp" "kana")
> layout breaks otherwise. I believe the reason is that the "kana"
> variant gets applied to "us" layout.
I see.
> From 68fc18d2816e3997f38d0a3c69566d85b26c8719 Mon Sep 17 00:00:00 2001
> From: Florian Pelz <pelzflorian@pelzflorian.de>
> Date: Wed, 8 Apr 2020 11:46:16 +0200
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> Subject: [PATCH] installer: Allow Alt+Shift toggle from non-Latin keyboard
> layouts.
>
> Fixes <https://bugs.gnu.org/40493>.
>
> * gnu/installer/newt/keymap.scm (%non-latin-layouts): New variable.
> (toggleable-latin-layout): New procedure to compute combined layouts.
> (run-keymap-page): Use it.
> (keyboard-layout->configuration): Apply it in config.scm.
> * gnu/installer/newt/help.scm (run-help-page): Mention Alt+Shift.
> * gnu/installer/keymap.scm (kmscon-update-keymap): Pass on XKB options.
> * gnu/installer/record.scm (<installer>): Adjust code comments.
> * gnu/installer.scm (apply-keymap): Pass on XKB options.
> (installer-steps): Adjust code comments.
> * gnu/packages/patches/kmscon-runtime-keymap-switch.patch: Apply XKB options.
[...]
> +(define %non-latin-layouts
> + ;; List of keyboard layouts marked as $nonlatin in xkeyboard-config.
Out of curiosity, where did you find that info? Perhaps add the name of
the relevant file or XML tag here.
> + (apply toggleable-latin-layout
> + (list layout (or variant "")))))
Simply:
(toggleable-latin-layout layout (or variant ""))
This allows the compiler to detect a wrong number of arguments.
Go for it, thank you!
Ludo’.
next prev parent reply other threads:[~2020-04-08 13:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 17:12 bug#40493: installer: Provide a way to select multiple keyboard layouts Mathieu Othacehe
2020-04-07 17:50 ` pelzflorian (Florian Pelz)
2020-04-07 20:38 ` Ludovic Courtès
2020-04-07 21:56 ` pelzflorian (Florian Pelz)
2020-04-08 9:58 ` pelzflorian (Florian Pelz)
2020-04-08 13:22 ` Ludovic Courtès [this message]
2020-04-09 4:14 ` pelzflorian (Florian Pelz)
2020-04-09 4:21 ` pelzflorian (Florian Pelz)
2020-04-09 7:25 ` Mathieu Othacehe
2020-04-09 7:36 ` pelzflorian (Florian Pelz)
2020-04-09 15:24 ` Ludovic Courtès
2020-04-09 7:54 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k12q5cyt.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40493@debbugs.gnu.org \
--cc=pelzflorian@pelzflorian.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).