From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yHd5HgxsWl89PQAA0tVLHw (envelope-from ) for ; Thu, 10 Sep 2020 18:10:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YBarGgxsWl+OQwAA1q6Kng (envelope-from ) for ; Thu, 10 Sep 2020 18:10:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E40E99402CB for ; Thu, 10 Sep 2020 18:10:19 +0000 (UTC) Received: from localhost ([::1]:35368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGR1W-0005Qg-DL for larch@yhetil.org; Thu, 10 Sep 2020 14:10:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGR1H-0005QE-0P for bug-guix@gnu.org; Thu, 10 Sep 2020 14:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57816) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGR1G-0000ZC-BD for bug-guix@gnu.org; Thu, 10 Sep 2020 14:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGR1G-0004Al-5P for bug-guix@gnu.org; Thu, 10 Sep 2020 14:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43296: [PATCH 1/1] gnu: Fix gnome-builder build. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 10 Sep 2020 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43296 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Prikler , 43296@debbugs.gnu.org Received: via spool by 43296-submit@debbugs.gnu.org id=B43296.159976138516012 (code B ref 43296); Thu, 10 Sep 2020 18:10:02 +0000 Received: (at 43296) by debbugs.gnu.org; 10 Sep 2020 18:09:45 +0000 Received: from localhost ([127.0.0.1]:41129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGR0z-0004AC-2P for submit@debbugs.gnu.org; Thu, 10 Sep 2020 14:09:45 -0400 Received: from world.peace.net ([64.112.178.59]:48818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGR0x-00049y-D0 for 43296@debbugs.gnu.org; Thu, 10 Sep 2020 14:09:44 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGR0q-0001Ee-MM; Thu, 10 Sep 2020 14:09:37 -0400 From: Mark H Weaver In-Reply-To: <20200910165827.13274-2-leo.prikler@student.tugraz.at> References: <20200910165827.13274-1-leo.prikler@student.tugraz.at> <20200910165827.13274-2-leo.prikler@student.tugraz.at> Date: Thu, 10 Sep 2020 14:08:19 -0400 Message-ID: <87k0x1tsgh.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: evvo1uCK6FVw Hi, Leo Prikler writes: > As reported in #43296, gnome-builder tries to be linked against the static > version of libselinux (propagated through glib/gio), failing to do so, as it > also wants to be a PIE. To keep the PIE, link it against the dynamic library. > * gnu/packages/gnome.scm (gnome-builder)[#:phases]: Add 'fix-ninja. > --- > gnu/packages/gnome.scm | 6 ++++++ > 1 file changed, 6 insertions(+) Thanks for this! One comment, though: > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 31c5b0319c..ff4cb8a383 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -11336,6 +11336,12 @@ libraries. Applications do not need to be recompiled--or even restarted.") > (string-append (assoc-ref inputs "python-pygobject") > "/lib"))) > #t)) > + (add-after 'configure 'fix-ninja > + (lambda _ > + ;; #43296: meson(?) incorrectly assumes we want to link > + ;; this PIE against a static libselinux. > + (substitute* "build.ninja" > + (("libselinux\\.a") "libselinux.so")))) > (add-before 'check 'pre-check > (lambda _ > (system "Xvfb :1 &") This new phase should end by returning #t. Thanks, Mark