From: Jan Nieuwenhuizen <janneke@gnu.org>
To: 45867-done@debbugs.gnu.org
Subject: bug#45867: hurd-vm: custom disk-size ignored
Date: Thu, 14 Jan 2021 20:21:32 +0100 [thread overview]
Message-ID: <87k0sfpbnn.fsf@gnu.org> (raw)
In-Reply-To: <87eeinqtu7.fsf@verum.com> (Jan Nieuwenhuizen's message of "Thu, 14 Jan 2021 19:03:28 +0100")
Jan Nieuwenhuizen writes:
> On current master, setting a bigger disk-size for a childhurd
>
> (service hurd-vm-service-type
> (hurd-vm-configuration
> (disk-size (* 12 (expt 2 30))) ;12GiB
>
>
> is being ignored. I am suspecting
[..]
> disk-size goes unused. So we probably need something like
>
> diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
> index f435630faf..3ede822183 100644
> --- a/gnu/services/virtualization.scm
> +++ b/gnu/services/virtualization.scm
> @@ -917,7 +917,9 @@ is added to the OS specified in CONFIG."
> (disk-size (hurd-vm-configuration-disk-size config))
> (type (lookup-image-type-by-name 'hurd-qcow2))
> (os->image (image-type-constructor type)))
> - (system-image (os->image os))))
> + (system-image
> + (image (inherit (os->image os))
> + (size disk-size)))))
>
> (define (hurd-vm-port config base)
> "Return the forwarded vm port for this childhurd config."
I can connfirm this works, pushed to master as 5b785b2a62b885a65aeece1399f7e3a732dd1cea.
> Greetings,
> Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
prev parent reply other threads:[~2021-01-14 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 18:03 bug#45867: hurd-vm: custom disk-size ignored Jan Nieuwenhuizen
2021-01-14 19:21 ` Jan Nieuwenhuizen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0sfpbnn.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=45867-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).