From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EIm4K6nrG2DvZAAA0tVLHw (envelope-from ) for ; Thu, 04 Feb 2021 12:42:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ALcwJ6nrG2D0RgAAB5/wlQ (envelope-from ) for ; Thu, 04 Feb 2021 12:42:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D7679401C0 for ; Thu, 4 Feb 2021 12:42:17 +0000 (UTC) Received: from localhost ([::1]:36130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7dxg-0008Ew-5o for larch@yhetil.org; Thu, 04 Feb 2021 07:42:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7dxS-0008Co-AL for bug-guix@gnu.org; Thu, 04 Feb 2021 07:42:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7dxS-000740-3f for bug-guix@gnu.org; Thu, 04 Feb 2021 07:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7dxS-0004dI-2J for bug-guix@gnu.org; Thu, 04 Feb 2021 07:42:02 -0500 Subject: bug#43015: git-fetched packages' working copy is not writable Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Thu, 04 Feb 2021 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43015 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner Mail-Followup-To: 43015@debbugs.gnu.org, maxim.cournoyer@gmail.com, dannym@scratchpost.org Received: via spool by 43015-done@debbugs.gnu.org id=D43015.161244248217746 (code D ref 43015); Thu, 04 Feb 2021 12:42:01 +0000 Received: (at 43015-done) by debbugs.gnu.org; 4 Feb 2021 12:41:22 +0000 Received: from localhost ([127.0.0.1]:40152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7dwn-0004cA-P5 for submit@debbugs.gnu.org; Thu, 04 Feb 2021 07:41:21 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:35290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7dwk-0004bv-Hc for 43015-done@debbugs.gnu.org; Thu, 04 Feb 2021 07:41:19 -0500 Received: by mail-qk1-f178.google.com with SMTP id a19so3116470qka.2 for <43015-done@debbugs.gnu.org>; Thu, 04 Feb 2021 04:41:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hhS2aQ0NSi9dKsKbLrQ+KLMU3iF+AAJp5tDHqPIaebs=; b=kLBHIoe0MIxpHBxeZcJL5cg7E+g/nN9V6rmJZPgy33oFE33uj8l7fii7M8ySuVfuGB V2w9GqMjYSWF/8tixMXMAaWaeyKK8bzR3d95BZJyKJ/rHNle1pSOGYimALqCWtnLBUQL 7SmVDkI9NHLT1vY+Tf2ti5yR2UmEy3B72haLotpOajOD3MkiVbNp0Kq67tP/dzDU4H3h KZeuimFEruUNK1xgnaTof5e1Ho1Aax7K+fvdICoLWgM48bqJOs3JgN99q2iOO7DHGR1j VhBv9pxxsj26/IY0eT2AykX7EgRkxFFpX9WNv9DH7ZF9Fk1SWNh73K6o9vfgGLNQJtLL 0fzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hhS2aQ0NSi9dKsKbLrQ+KLMU3iF+AAJp5tDHqPIaebs=; b=LQ+IbwDeEhoGaToxPlpELocmDj7Y2EhV7NV15MHCIKM1I1NzAXV/LnG2IC9mxoBxNa yRRC8qZMEt8PMxgwcC7i4reXd0qlfMSZj+46xF7d885eSz1SooOIuK7xgA/Z0Xm08gEF QlB9SV76LTiBGhLBL9Km79IMzRK9pu2oNMam2lur0P5h660utMz9tAaVOmM4UlJZN3mG c+N3zgDMF9YmTJ5XaU/Hn06zq6k8yWJq6UJCFOBi5UXGOn7lWAzcrwbxrXLd+5yfmchk qGwVGYCIsGt6ZiG2rXrZoKg0W1W8bJjXMwWLNP8rmbNlSRbHnc7vQlMHmc9NR1/xGRoz 6ilQ== X-Gm-Message-State: AOAM530Mb84v43T82OLZOlxumtwY97hWptXbI9umb1syp8L1I5AqQKBS mGs6wRi/PHlYIPyt/GEmKqsYd0F47d0= X-Google-Smtp-Source: ABdhPJw71tmGIHaXuZcxcysAs67IZjNLX76Py6h00uf9yrWmRwKJVmfPgdhYH6trjA6Di7OBYbQxxw== X-Received: by 2002:a05:620a:49:: with SMTP id t9mr7661250qkt.231.1612442472811; Thu, 04 Feb 2021 04:41:12 -0800 (PST) Received: from hurd (dsl-205-151-56-157.b2b2c.ca. [205.151.56.157]) by smtp.gmail.com with ESMTPSA id c14sm5194893qkl.18.2021.02.04.04.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 04:41:11 -0800 (PST) From: Maxim Cournoyer References: <20200824111359.4008ce30@scratchpost.org> <20200824092256.GH1392@E5400> Date: Thu, 04 Feb 2021 07:41:10 -0500 In-Reply-To: <20200824092256.GH1392@E5400> (Efraim Flashner's message of "Mon, 24 Aug 2020 12:22:56 +0300") Message-ID: <87k0rongyh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43015-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=kLBHIoe0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 2D7679401C0 X-Spam-Score: -1.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6wNF4hLfgLcH Hello, Efraim Flashner writes: > On Mon, Aug 24, 2020 at 11:13:59AM +0200, Danny Milosavljevic wrote: >> Hi, >> >> the working copy of a package build when the package was git-fetched is not >> writable. >> >> On the other hand, if it's url-fetched, it's perfectly writable. >> >> Shall we fix this on core-updates ? > > (ins)efraim@E5400 ~/workspace/guix$ git grep make-files-writable | grep unpack | grep gnu/packages > gnu/packages/bioinformatics.scm: (add-after 'unpack 'make-files-writable > gnu/packages/code.scm: (add-after 'unpack 'make-files-writable > gnu/packages/djvu.scm: (add-after 'unpack 'make-files-writable > gnu/packages/java.scm: (add-after 'unpack 'make-files-writable > gnu/packages/java.scm: (add-after 'unpack 'make-files-writable > gnu/packages/java.scm: (add-after 'unpack 'make-files-writable > gnu/packages/java.scm: (add-after 'unpack 'make-files-writable > gnu/packages/machine-learning.scm: (add-after 'unpack 'make-files-writable > gnu/packages/ocaml.scm: (add-after 'unpack 'make-files-writable > gnu/packages/ruby.scm: (add-after 'unpack 'make-files-writable > > My only concern would be if there were files which weren't supposed to > be writable. We're building the package, not making changes to be > submitted upstream or anything, so I don't see that as being a reason to > hold back. > > I'm in favor I've included the fix as part as the unpack phase, and pushed to core-updates as commit 6129ebddbd. Thanks for the report! Closing. Maxim