unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Vivien Kraus via Bug reports for GNU Guix <bug-guix@gnu.org>
To: 51447@debbugs.gnu.org
Subject: bug#51447: [PATCH] Re: bug#51447: guile-gi source code has a placeholder for a combining character
Date: Tue, 02 Nov 2021 18:24:11 +0100	[thread overview]
Message-ID: <87k0hqwjry.fsf@planete-kraus.eu> (raw)
In-Reply-To: <handler.51447.B.163536819116399.ack@debbugs.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]


The string failure is due to a dotted circle as a basis for the
combining character, that may have been inserted by a clever source code
editor. Replacing it with the hex value for the character itself, the
test passes.

Vivien


[-- Attachment #2: 0001-guile-gi-fix-a-source-code-encoding-error.patch --]
[-- Type: text/x-patch, Size: 1122 bytes --]

From 308bd116d75861c70f7540890a514b0eb487c2f7 Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Tue, 2 Nov 2021 18:19:03 +0100
Subject: [PATCH] guile-gi: fix a source code encoding error

* gnu/packages/guile-xyz.scm (guile-gi) [phases]: remove the default dotted
circle from the combining character that is tested in test/string.scm.
---
 gnu/packages/guile-xyz.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 3c93779209..6a401cda45 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -3145,6 +3145,10 @@ (define-public guile-gi
                   (ice-9 rdelim))
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'workaround-guile-reader-failure
+           (lambda* _
+             (substitute* "test/string.scm"
+               (("#\\\\◌̀") "#\\x0300"))))
          (add-after 'unpack 'patch-references-to-extension
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((effective (read-line
-- 
2.33.1


  parent reply	other threads:[~2021-11-02 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 20:56 bug#51447: Guile-gi fails a few tests on core-updates-frozen Vivien Kraus via Bug reports for GNU Guix
     [not found] ` <handler.51447.B.163536819116399.ack@debbugs.gnu.org>
2021-11-02 17:24   ` Vivien Kraus via Bug reports for GNU Guix [this message]
2021-11-02 17:31     ` bug#51447: [PATCH] Re: bug#51447: guile-gi source code has a placeholder for a combining character Vivien Kraus via Bug reports for GNU Guix
2021-11-02 17:28   ` bug#51447: there’s no other test failing than string.scm Vivien Kraus via Bug reports for GNU Guix
2021-11-03 11:11 ` bug#51447: More explanations for the fix Vivien Kraus via Bug reports for GNU Guix
2021-11-03 11:58   ` Tobias Geerinckx-Rice via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0hqwjry.fsf@planete-kraus.eu \
    --to=bug-guix@gnu.org \
    --cc=51447@debbugs.gnu.org \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).