bug#52598: Clojure-build-system failure at the unpack phase

bug#52598: Clojure-build-system failure at the unpack phase

[Aleksandr Vityazev]

Hello,

Tried to build all the packages from gnu/package/clojure.scm that use
clojure-build-system. All have the same error:

--8<---------------cut here---------------start------------->8---
starting phase `unpack'
error: in phase 'unpack': uncaught exception:
wrong-type-arg "string-suffix?" "Wrong type argument in position ~A (expecting ~A): ~S" (2 "string" #f) (#f) 
phase `unpack' failed after 0.0 seconds
Backtrace:
           9 (primitive-load "/gnu/store/rw9rz7hahnvmlgk8ii1nfd94yc0…")
In guix/build/gnu-build-system.scm:
    904:2  8 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #)
In ice-9/boot-9.scm:
  1752:10  7 (with-exception-handler _ _ #:unwind? _ # _)
In srfi/srfi-1.scm:
    634:9  6 (for-each #<procedure 7ffff25c7540 at guix/build/gnu-b…> …)
In ice-9/boot-9.scm:
  1752:10  5 (with-exception-handler _ _ #:unwind? _ # _)
In guix/build/gnu-build-system.scm:
   925:23  4 (_)
In guix/build/ant-build-system.scm:
    147:6  3 (unpack #:source _)
In unknown file:
           2 (string-suffix? ".jar" #f #<undefined> #<undefined> #<…> …)
In ice-9/boot-9.scm:
  1685:16  1 (raise-exception _ #:continuable? _)
  1685:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1685:16: In procedure raise-exception:
In procedure string-suffix?: Wrong type argument in position 2 (expecting string): #f
builder for `/gnu/store/8zzfxjymy042l28d3mryqgxgdq3f6pv3-clojure-tools-cli-1.0.206.drv' failed with exit code 1
--8<---------------cut here---------------end--------------->8---

-- 
Best regards,
Aleksandr Vityazev

bug#52598: Clojure-build-system failure at the unpack phase

[Maxime Devos]

Aleksandr Vityazev schreef op za 18-12-2021 om 11:34 [+0000]:
> Hello,
> 
> Tried to build all the packages from gnu/package/clojure.scm that use
> clojure-build-system. All have the same error: [...]

I think the problem is that #:source is included in the private-
keywords in (guix build-system clojure), so the source isn't passed to
the builder, instead #false is passed. (untested)

While we're at it, we might want to modify 'unpack' in ant-build-system
to fail gracefully if there's no source (e.g. print an error like
‘source code is missing’ or something). That would probably incur many
rebuilds (though only of Java packages?), so that might need to be done
on a separate branch.


Greetings,
Maxime.

bug#52598: [PATCH] build-system: clojure: Allow clojure-build-system to pass source to ant.

[Reily Siegel]

Fixes http://bugs.gnu.org/52598.

* guix/build-system/clojure.scm (lower): Remove #:source from private
keywords, preventing an error in ant-build-system.
---
 guix/build-system/clojure.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/guix/build-system/clojure.scm b/guix/build-system/clojure.scm
index 39b7f44e89..634854cf1b 100644
--- a/guix/build-system/clojure.scm
+++ b/guix/build-system/clojure.scm
@@ -81,8 +81,7 @@ (define* (lower name
                 #:allow-other-keys
                 #:rest arguments)
   "Return a bag for NAME."
-  (let ((private-keywords '(#:source #:target
-                            #:inputs #:native-inputs
+  (let ((private-keywords '(#:target #:inputs #:native-inputs
                             #:clojure #:jdk #:zip)))
 
     (if target
-- 
2.34.0

bug#52598: Clojure-build-system failure at the unpack phase

[Ricardo Wurmus]

Thank you.  I applied this and pushed it to the master branch with
commit ee6c43f8cd46897bbe1a5a16c68049d7237ea806.

My apologies for the delay.

-- 
Ricardo