From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aNTbD4zzHGLMlQAAgWs5BA (envelope-from ) for ; Mon, 28 Feb 2022 17:08:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ADL9DIzzHGI4gwEA9RJhRA (envelope-from ) for ; Mon, 28 Feb 2022 17:08:44 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 113293E333 for ; Mon, 28 Feb 2022 17:08:43 +0100 (CET) Received: from localhost ([::1]:58500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOiZm-0006ru-LW for larch@yhetil.org; Mon, 28 Feb 2022 11:08:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOiMc-0002rE-Bj for bug-guix@gnu.org; Mon, 28 Feb 2022 10:55:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOiMX-0001SW-Px for bug-guix@gnu.org; Mon, 28 Feb 2022 10:55:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOiMX-0003gt-Oc for bug-guix@gnu.org; Mon, 28 Feb 2022 10:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#40998: [PATCH v2 4/4] initrd: Print its command-line parameters. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 28 Feb 2022 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40998 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Received: via spool by 40998-submit@debbugs.gnu.org id=B40998.164606369314166 (code B ref 40998); Mon, 28 Feb 2022 15:55:01 +0000 Received: (at 40998) by debbugs.gnu.org; 28 Feb 2022 15:54:53 +0000 Received: from localhost ([127.0.0.1]:34591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOiMO-0003gQ-M6 for submit@debbugs.gnu.org; Mon, 28 Feb 2022 10:54:52 -0500 Received: from mail-qv1-f51.google.com ([209.85.219.51]:34537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOiML-0003g9-Uv for 40998@debbugs.gnu.org; Mon, 28 Feb 2022 10:54:51 -0500 Received: by mail-qv1-f51.google.com with SMTP id ba20so13221872qvb.1 for <40998@debbugs.gnu.org>; Mon, 28 Feb 2022 07:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Lxdmi9n+7UdKDdpcq8gIuz/6g+IRvseFpxXBQYDIJR4=; b=oRAXMbeWTHzlyNYumCi2ULZnnfCbzrJ2T+JKldwTB+1p43SQD+rDft4F2/gjSujTk2 AvV1NQyfsjPYl/KBNp05DPIjDPEH4BLcCEiwYaqwmUXv3Sct4f6GX+NDf4VzU39y3cwv /B4t6l5gDQMYJurpOYWMvelr7WkxvbR6nnNMrm6DHRgxuGQGx5k5g2ZMp3w0uzQLr2W/ DlSsBh1N6PwYNJ3ieI2ctNG22KWItX8n7uABmpRpzmjdeHfe8JNLhDs0PP7DscHe7nyA A/oO9lVSxse963oyHNh2DqyZDMhuXuAVQwyUPbT4iLVINwl4wrGMRCvbgsV+kogqWpq4 +dPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Lxdmi9n+7UdKDdpcq8gIuz/6g+IRvseFpxXBQYDIJR4=; b=YTntczWQK1sxRfZ9+n4Uz7gX8Vvqn8Ci5A5htMfhOR4pD+l2z48TLatv3OUCADkVwO 872epdI93YGPl+2yJclNqmWElj0tIHs8R4HKBnyHkuP+NxQ5bO15UkxoqpKDN98p3R3H Yz5M8KnKIE7e4jFWOSutwebZJPi4i/7bG/+33inqil4b1+WOTKcjCMJpmHiLPXIY1wn+ yo8FMBeqBir6ET4yMN6pS6oZ3qBpZOOq2bXcKzoBEr4QoVZ6LSVwBcisBI2BLoDyE/zq zNi2dscPMjzvoafgTE5Hcj9FLF7okBKjBKRuf7bQdJhH2UC4s1jOFmkpv8wtTJ6DYyyj REgQ== X-Gm-Message-State: AOAM533dP9x24VusQIOUxS5TXsGtktGy/F8Iry1gGmdhRtSshz3k6X8o ltn6f+tFbTs+MJPweDnZnW/4I8F7G/g= X-Google-Smtp-Source: ABdhPJyDIICsy2/Rgd5qmCBl1hFUpNNKublpPtu2RzXws5Yqlk6RmuffbG1FSwG656Dy29d2NyagIQ== X-Received: by 2002:a05:6214:5290:b0:432:d8a3:c9a0 with SMTP id kj16-20020a056214529000b00432d8a3c9a0mr9633951qvb.69.1646063684095; Mon, 28 Feb 2022 07:54:44 -0800 (PST) Received: from hurd (dsl-141-227.b2b2c.ca. [66.158.141.227]) by smtp.gmail.com with ESMTPSA id a3-20020a05620a124300b00648c9a37984sm5015029qkl.58.2022.02.28.07.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 07:54:43 -0800 (PST) From: Maxim Cournoyer References: <20220219070155.1924-1-maxim.cournoyer@gmail.com> <20220219070155.1924-4-maxim.cournoyer@gmail.com> <27E100DE-7344-4F7B-8F32-44FE6AF27D2B@tobias.gr> Date: Mon, 28 Feb 2022 10:54:42 -0500 In-Reply-To: <27E100DE-7344-4F7B-8F32-44FE6AF27D2B@tobias.gr> (Tobias Geerinckx-Rice's message of "Mon, 28 Feb 2022 03:45:23 +0000") Message-ID: <87k0dft29p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 40998@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646064524; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Lxdmi9n+7UdKDdpcq8gIuz/6g+IRvseFpxXBQYDIJR4=; b=JmYzdTAFKpH+y+uvijInnlWQifeaRCaySaZOSZ1PAsV4d/JQc92ATUsI37pPVH/hvCGNwX pZmA62kaLv1XjWYPnJEEODESMptwKII3EK8YTROJar81pgxzQbVOVycyQ/Tw6soRzb51O9 +8k3397cVZkpK/EnpZqCdU100t3M16dllCuAC+85eMeJo8Evj0YF05AfX+r5mfXktDFREt kEGyDJFvLTpHB8f/nkP++PdchBM6UiZMUyw5P4qmD5fO4khjB4g580I/3qP8fo09jGgal+ C6vcEQzeguS1H2BAsm7ZYDfGuQzrDnRuhrP79h0mpkzMPxvfvl4ktqlOvvSJPA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646064524; a=rsa-sha256; cv=none; b=WJmVUEoqHN/yU7X5hmk4PmwIIvpPbKFN+AcOAP9fEeaM1Gtzt+vVxo3fHaG9iwdftpmWDv 5HUJZenF8s7q2DilX0+hxy41bJRSLCZqnae/atBx9nCWOUVHREx7uvA6pQ6l3f94JWIDEb eCUMHrITpiq6z24Xb9FLqitb6IkyAwTCAp2l31zcx2cEXr19dVSVHlqnT2c+lQrNY+L52A IVkMCF+eWV6g16bxjs2m1Q6w9jMw/H8OIAJHxZ27lAavzkG3WbY6gytKDBgh+E3Ged3Ea5 60iOAX2PimRwnfv9KSUS6htFjHR+V9SYw7gc5JwPS6WSSrjkqaR6VpPXt7CQSw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=oRAXMbeW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=oRAXMbeW; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 113293E333 X-Spam-Score: 5.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4UCxvbl4ULYI Hi, Tobias Geerinckx-Rice writes: > On 19 February 2022 07:01:55 UTC, Maxim Cournoyer wrote: >>* gnu/build/linux-boot.scm (boot-system): Print command-line parameters to >>standard output. >>--- >> gnu/build/linux-boot.scm | 2 ++ >> 1 file changed, 2 insertions(+) >> >>diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scm >>index 2f8b114806..30442ec8f8 100644 >>--- a/gnu/build/linux-boot.scm >>+++ b/gnu/build/linux-boot.scm >>@@ -542,6 +542,8 @@ (define (device-string->file-system-device device-string) >> (root-fs* (find root-mount-point? mounts)) >> (fsck.mode (find-long-option "fsck.mode" args))) >> >>+ (format #t "initrd command-line parameters: ~a~%" args) >>+ >> (unless (or root-fs* (and root-device rootfstype)) >> (error "no root file system or 'root' and 'rootfstype' parameters")) >> > > I suggest dropping this patch. The kernel already does this. It's just noise. I thought about adding it after attempting to debug initrd/kernel problems as can be seen here: https://elephly.net/paste/1645124517.html (this is the Berlin boot log copied from a serial console). Not that the initrd printing it itself would have helped here, as it appears to be truncated from when Linux took over the initrd script, if I understand correctly. Anyway, I agree it's probably redundant and useless in all but more desperate debugging cases :-), so I don't mind to drop it. Thanks, Maxim