From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OKZbEQarRWONlwAAbAwnHQ (envelope-from ) for ; Tue, 11 Oct 2022 19:42:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0F84EAarRWORTgAAG6o9tA (envelope-from ) for ; Tue, 11 Oct 2022 19:42:30 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89996A5D4 for ; Tue, 11 Oct 2022 19:38:02 +0200 (CEST) Received: from localhost ([::1]:50778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiJCb-0007hn-B5 for larch@yhetil.org; Tue, 11 Oct 2022 13:38:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiJ7m-0004d9-GB for bug-guix@gnu.org; Tue, 11 Oct 2022 13:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiJ7m-00059p-7C for bug-guix@gnu.org; Tue, 11 Oct 2022 13:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oiJ7l-0003R8-WA for bug-guix@gnu.org; Tue, 11 Oct 2022 13:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#57790: Strange behavior with emacs-build-system Resent-From: Fredrik Salomonsson Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 11 Oct 2022 17:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57790 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun , 57790@debbugs.gnu.org Received: via spool by 57790-submit@debbugs.gnu.org id=B57790.166550954313163 (code B ref 57790); Tue, 11 Oct 2022 17:33:01 +0000 Received: (at 57790) by debbugs.gnu.org; 11 Oct 2022 17:32:23 +0000 Received: from localhost ([127.0.0.1]:54741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiJ79-0003QD-5F for submit@debbugs.gnu.org; Tue, 11 Oct 2022 13:32:23 -0400 Received: from mout02.posteo.de ([185.67.36.66]:60833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiJ75-0003Pz-5F for 57790@debbugs.gnu.org; Tue, 11 Oct 2022 13:32:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1C7DF240104 for <57790@debbugs.gnu.org>; Tue, 11 Oct 2022 19:32:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665509533; bh=5vjXzQD0037QGfp1HzGpOpYgo7cSTmTvNjSC8dWcJQQ=; h=From:To:Subject:Date:From; b=dqwatssKvemXbMyxvzLBc3vNklciDbQ5ZOPwNUg5Vt4wNpv7aTjTTG0K7Gm22IGSu aQE9c0ZrIJek/eFk5LQB443RJA1MzHQ1svJKhIl5scBZ15i82Cv5vrdorRzEzQMQ0E /XBXziF8RWvTgQVlB6F2myBMgbG4iyLx8ZOCrXNJufwsQOkj/ILJCjdgE8t+XCi7fn OLcP3XFp7Fmr/JNyDo+0X6p54lNCv70XgJoKjcjBrydsCq5zj4DJnw5J0w6VZJzLsV sMxODBl+kZRnFIODsLrnFidVvYvLrVbbWOQMfOWC53oZEiWOO25gjyqTeEogpYgMPI RjcZNoydW5lGQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mn2sP4cjjz6tq0; Tue, 11 Oct 2022 19:32:09 +0200 (CEST) From: Fredrik Salomonsson In-Reply-To: <86wn96ofhp.fsf@gmail.com> References: <87v8pqbr0o.fsf@d2.com> <86wn96ofhp.fsf@gmail.com> Date: Tue, 11 Oct 2022 17:32:07 +0000 Message-ID: <87k056qnag.fsf@d2.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665509882; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hHOD8x8LbbBmJU2r6/XPLGuIr18Pn9mB3QJ+VeusTHk=; b=J/TogOnE8AyiCcr0H84uP9yVJssPtKzFjgcD69G8q5oWT6PyULMxCj1FIU1Ec9U8rxWsJI JRdTPg0EIZLvwj3ZkiAXidemJauJrgZvQFQcPlX5ZiDC6esXQipE+X3iuiZbhucXJL+oAH WHthPL4IWswl14QAISIREPpyee13w7maK15HNYJlYUQfl//cJtRGuRqVr+6lb+vHQo7FOb PbHuTqc/jdWqdg+ou5oK8ySsPNQnXweYwgDQOJOY0aK3vuf1/AJBDFa87IAHi4y9D8C75L 0AnSQVtT05H7p1pD62CU7BfnxCBlE5chRc+vDuJ5vrp2w2HqpwQXiDOWFTBlxw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665509882; a=rsa-sha256; cv=none; b=tJ0hAh21kYgjBpodzGPXi2z5JM2czgRYrgM2EuCxZfus72tKvy1aQyaqpOd1ri7Wrw8FEZ ug/qKmNTym7Hu/VqQVipxhJDHUW34hh4HOQSDwchD0IyuAdL0G1WCNgyaR6oFbEjGGF1To 5OFUy4h+Aqyo18MeAdKEGj9Id7HkaRdfjG2AuoO/mxYyKtZgvMaLKeJZWfHp1odH95kWwC R8s3Gouxp/HSBNWwjlPjGJpJRFMlid354h8lcp74alsx7X5YLN76p45IPGl6sCfuX0L9Fz Lt1NpZzdyDMGFcxqAZvRBE2mepeU8opsNz3f8Y80/uEwpFsf2qP31TlDA47ZRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=dqwatssK; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=dqwatssK; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 89996A5D4 X-Spam-Score: 7.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: LfiUqLWAHyDD Hi, zimoun writes: > On Wed, 14 Sep 2022 at 02:59, Fredrik Salomonsson w= rote: > >> If I name the local clone `issue.el` (name of the directory); >> `guix=C2=A0build=C2=A0-f=C2=A0guix.scm` will fail. It will just copy the= file >> `issue.el` and then `ert-runner` fails as there is no test directory. >> >> But if I name the local clone something else, e.g. `issue-el` then it >> will copy all the files, `ert-runner` will be happy and >> `guix=C2=A0build=C2=A0-f=C2=A0guix.scm` will succeed. >> >> I'm not sure if this is an issue in `emacs-build-system`, `local-file` >> or plain old user error. > > Well, I guess it comes from =E2=80=99unpack=E2=80=99; which reads: > > --8<---------------cut here---------------start------------->8--- > (define* (unpack #:key source #:allow-other-keys) > "Unpack SOURCE into the build directory. SOURCE may be a compressed > archive, a directory, or an Emacs Lisp file." > (if (string-suffix? ".el" source) > (begin > (mkdir "source") > (chdir "source") > (copy-file source (store-file->elisp-source-file source)) > #t) > (gnu:unpack #:source source))) > --8<---------------cut here---------------end--------------->8--- Ah, yeah that would make sense. > Well, I guess again that the =E2=80=99source=E2=80=99 should contain some= thing like, > > (file-name (git-file-name name version) > > to avoid the issue. But the naive approach does not work with > =E2=80=99local-file=E2=80=99. Would `file-is-directory?` work? E.g. (if (and (string-suffix? ".el" source) (not (file-is-directory? source))) =E2=80=A6) I'm currently at work so I cannot test this right now. --=20 s/Fred[re]+i[ck]+/Fredrik/g