From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mDnFNmHZX2TeCAAASxT56A (envelope-from ) for ; Sat, 13 May 2023 20:39:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sL+uNmHZX2RGEgEAauVa8A (envelope-from ) for ; Sat, 13 May 2023 20:39:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 922CE2765D for ; Sat, 13 May 2023 20:39:29 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxu93-00057O-8J; Sat, 13 May 2023 14:39:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxu90-00056p-Q9 for bug-guix@gnu.org; Sat, 13 May 2023 14:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxu90-0006GN-Ap for bug-guix@gnu.org; Sat, 13 May 2023 14:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxu90-0007Hx-6B for bug-guix@gnu.org; Sat, 13 May 2023 14:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63427: gdk-pixbuf unable to recognize image formats (JPG, PNG, etc.) Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 13 May 2023 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63427 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: Nathan Dehnel , Josselin Poiret , 63427@debbugs.gnu.org Received: via spool by 63427-submit@debbugs.gnu.org id=B63427.168400310627964 (code B ref 63427); Sat, 13 May 2023 18:39:02 +0000 Received: (at 63427) by debbugs.gnu.org; 13 May 2023 18:38:26 +0000 Received: from localhost ([127.0.0.1]:39601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxu8Q-0007Gy-4P for submit@debbugs.gnu.org; Sat, 13 May 2023 14:38:26 -0400 Received: from relay.yourmailgateway.de ([185.244.194.184]:58781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxu8O-0007Gp-7G for 63427@debbugs.gnu.org; Sat, 13 May 2023 14:38:25 -0400 Received: from relay01-mors.netcup.net (localhost [127.0.0.1]) by relay01-mors.netcup.net (Postfix) with ESMTPS id 4QJZC24nLMz8wsN; Sat, 13 May 2023 20:38:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de; s=key2; t=1684003102; bh=CvoiavQh9102L/AOjnnz/NYUe4PLYL7SxhnEHNMecRQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HaAI+DYBkS0fFH600ZLzFPs1klYdo5w3k1mZ0dRG87qgxcHjlqdipuHVKnYh8bPaP 7gIolgrAeIy/z2guDVqb5napB2FcZ40XC292bJrejJRoNvu9fIoSA0h6YIsZG0HiRT ZGiTSOsBfzAFNEVmvQHwwU9h120++CtB8S8KlIsF8GGORIB5LWJmS/wLUxYW/Y/SSW pr/9mbHvm7S0nYUvKGEaKfvhPwmbKfXQtrYXshpaMtJSNskEzg/30ag3W21AXyL9gz zTy5fyBm4MuyZJSj+AaAYU2yrp0Jq3Q4HzKBH4/u5HH3/Gm9Q5/3A7yCo4XTGeLwhz QI4oGJU54KtiQ== Received: from policy01-mors.netcup.net (unknown [46.38.225.35]) by relay01-mors.netcup.net (Postfix) with ESMTPS id 4QJZC2461Mz7vKG; Sat, 13 May 2023 20:38:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at policy01-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy01-mors.netcup.net (Postfix) with ESMTPS id 4QJZC1690rz8sYj; Sat, 13 May 2023 20:38:21 +0200 (CEST) Received: from florianrock64 (ip92344de0.dynamic.kabel-deutschland.de [146.52.77.224]) by mxe217.netcup.net (Postfix) with ESMTPSA id 7A27780D40; Sat, 13 May 2023 20:38:14 +0200 (CEST) From: "pelzflorian (Florian Pelz)" References: <874joje1ii.fsf@jpoiret.xyz> <5d2305c2acf0784713b7d32e6485a80e35171269.camel@gmail.com> <87bkipaovk.fsf@pelzflorian.de> <87cz34ecb7.fsf@pelzflorian.de> Date: Sat, 13 May 2023 20:38:12 +0200 In-Reply-To: (Liliana Marie Prikler's message of "Sat, 13 May 2023 15:50:16 +0200") Message-ID: <87jzxccc17.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Rspamd-Queue-Id: 7A27780D40 X-Spamd-Result: default: False [-4.10 / 15.00]; BAYES_HAM(-5.50)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:3209, ipnet:146.52.0.0/16, country:DE]; FREEMAIL_TO(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; TAGGED_RCPT(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,jpoiret.xyz,debbugs.gnu.org] X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: jf84Y71ccypkEuBvsvyxIrvo+2Vnhp+dGzUvxnO1G5oKhyHh3xgjGdqW X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684003169; a=rsa-sha256; cv=none; b=q7VFjgVATpGCbvya8K8pC0R0+HAepxSRCR4wtYASi6/cRAXFQoss/Owx+33MOPyjchx1f9 0DVwfBuMyiz48ZiIMKhblPqJMylnb0yw5ZqtOk66JSUSzqng+3I3blVeYKg4OEN2Cfe2JW T9lDqyEnQsfIG4fTwjLj5BUXNyeB5W+9x3QgSx8UxtRQJ3uOoiAoJwZ/53g3LaGwt+5uG+ tzFVYUro6Xo5c5vEEmpGR8hpVoNAW1ZKaof567WhExGJpWB6+tfXgYFGyJpMDvXBGvHVJn UAP2UdWbxDRXUTY8PYZAQeEgmgUa6ACSKF92Yy3DbLYsOoG+NwWJvNWIJ00vRw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=HaAI+DYB; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684003169; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=A4UE/66DntvUkKShqJowCYQhFhSYklrfn+es+MVBRbE=; b=JDAqHycBW8EVOFQlA2sHDWyOQvAY956VU9SnV3Oa1uTE6YJgvK6Tjij4OCFm6A9iEDzR5Z D4A2qpO0WG7f2yjOyefWUxLcGMWlSQ+s6EN4IKp8JyvGrIA9PmP9y6mC01sA5GPX3iLwps 2rHE2TouYHm0Mp5O3PWUeKq/LN9p+vJxt5znhIEPRD4TnFGO1c5uYisTEgGYymPQMuozwj mdFpM6uyhZR4zqBmFbZfAQKEmsih0UUvlgWziU8KH5f2RWc3+dPYrxEBMlSVlJ/NlM/jC9 uaWM4GSs5P9unwRz8Sm2w5YxRioRTMqWjsI7Tpx+l9Lb/eNfU8OnoHRFyPaYjw== X-Migadu-Spam-Score: 0.59 X-Spam-Score: 0.59 X-Migadu-Queue-Id: 922CE2765D X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=HaAI+DYB; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: ikYjwFbJXbAP --=-=-= Content-Type: text/plain Hi Liliana and all. Until now the user could decide what image loaders to install alongside. Or so I thought. However, surprisingly I cannot get any other loader except gdk-pixbuf and librsvg to work anyway. That is, guix shell viewnior webp-pixbuf-loader surprisingly does not see webp files. I do not understand. If this changed patch looks fine, now with proper gexp use, I will push it. The patch continues to include gdk-pixbuf among the inputs even though gtk+@2 propagates gdk-pixbuf anyway, but better be explicit. Regards, Florian --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=viewnior-Support-image-formats-out-of-the-box.patch Content-Transfer-Encoding: quoted-printable >From 6acc7322695a13c326918c4b83a999e324406b21 Mon Sep 17 00:00:00 2001 Message-Id: <6acc7322695a13c326918c4b83a999e324406b21.1684001649.git.pelzfl= orian@pelzflorian.de> From: Florian Pelz Date: Sat, 13 May 2023 12:33:26 +0200 Subject: [PATCH] gnu: viewnior: Support image formats out of the box. * gnu/packages/image-viewers.scm (viewnior) [inputs]: Add 'librsvg-for-system'. [arguments]: Enable 'glib-or-gtk?' to make available GDK_PIXBUF_MODULE_FILE. Wrap viewnior to use it instead of the image loaders installed by the user. --- gnu/packages/image-viewers.scm | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index db7a44d4ff..798a8e50e8 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -27,6 +27,7 @@ ;;; Copyright =C2=A9 2022, 2023 Maxim Cournoyer ;;; Copyright =C2=A9 2022 Tomasz Jeneralczyk ;;; Copyright =C2=A9 2022 Cairn +;;; Copyright =C2=A9 2023 Florian Pelz ;;; ;;; This file is part of GNU Guix. ;;; @@ -425,13 +426,24 @@ (define-public viewnior (base32 "14qvx1wajncd5ab0207274cwk32f4ipfnlaci6phmah0cwra2did")))) (build-system meson-build-system) (arguments - '(#:phases (modify-phases %standard-phases - (add-after 'unpack 'patch-source - (lambda _ - ;; Don't create 'icon-theme.cache' - (substitute* "meson.build" - (("meson.add_install_script*") ""))))) - #:tests? #f)) ;no tests + (list #:glib-or-gtk? #t + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-source + (lambda _ + ;; Don't create 'icon-theme.cache' + (substitute* "meson.build" + (("meson.add_install_script*") "")))) + (add-after 'glib-or-gtk-wrap 'wrap-pixbuf + (lambda* (#:key outputs #:allow-other-keys) + (let ((viewnior (string-append #$output "/bin/viewnior"= ))) + (wrap-program viewnior + ;; Wrap GDK_PIXBUF_MODULE_FILE so viewnior can be u= sed + ;; to view JPG, PNG and SVG, without the user needi= ng + ;; to install gdk-pixbuf or librsvg. + `("GDK_PIXBUF_MODULE_FILE" =3D + (,(getenv "GDK_PIXBUF_MODULE_FILE")))))))) + #:tests? #f)) ;no tests (native-inputs (list gettext-minimal `(,glib "bin") ;glib-genmarshal @@ -440,7 +452,8 @@ (define-public viewnior (inputs (list exiv2 gdk-pixbuf - gtk+-2)) + gtk+-2 + (librsvg-for-system))) (home-page "https://siyanpanayotov.com/project/viewnior") (synopsis "Simple, fast and elegant image viewer") (description "Viewnior is an image viewer program. Created to be simp= le, base-commit: e3e011a08141058598cc7631aeb52d620a3ccb8c --=20 2.39.2 --=-=-=--