From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QlfiEuKv12RBOAEASxT56A (envelope-from ) for ; Sat, 12 Aug 2023 18:14:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OC/XEeKv12TxSwEA9RJhRA (envelope-from ) for ; Sat, 12 Aug 2023 18:14:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03C0E3EB3B for ; Sat, 12 Aug 2023 18:14:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=iQk9TGJe; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691856866; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=nPekc22gYcEx0MXso+6oTaAPgutcYP/GatKCg+kTPHw=; b=MsEgCScDZ8mJezcoIBbmr+YKHUBsxkWAMRFEtLchlSXdZ55tzKjt7LpkV8DJFkLoKE2dnE eUIPHFJ7WOgeJuGuWm0Ds2bdxtDU87qoPRC7HW+j5DH+TzFTH9YDJMoKnp7oz5VUMztVRg ib35mmN/pA5/19Y5Jl0pj3onsDEBQ08YCl8iZG2JGSxB8wQLZERQ1Yz7SKVS8o/ZpLG58g 8IuKHMdzjPxuG29NuTfnSukPVHwfehBavz5vkAF194GGv/yDUPPBmnGX83PIoBg8C8uQoi AEhKYOQXv7nXtUQJmki6FHOmpfJnMIQGWhC1PggFDRi3d8yXC+prlqTt3gtEUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=iQk9TGJe; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691856866; a=rsa-sha256; cv=none; b=E5nEnRMXsXFiZYWzikTMrLN0wyw7uhQy0Bfd5QeV16pKEWtsYVc35nVbp0+mxGVD/gZAPB Hbxy9IVrouDTGxPvFuMwiTXOysdLZ1uIm/zeaIBCfBzoNRDkZqx50w6vNKVlnAFJvbRQE2 pSbdnFpMBM0qTrwZudjIncMaa5ACM6Iza0pzNUELtuSAsszKSzlCYZKY62cq17CUdXbXx9 Jw6wlgtEPCXWmZB7mFAKd11QH6GHwr0ueD7Bdfnue892CnIv4rv7Y3LUMGYF7CciEsGG1y 6tnGt3SwWzcwtf0fgMQdGyTpWADVDw5XgI+CuRnYjZQ9N2l6idwBNn/7aeHAUg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUrFc-0006np-M5; Sat, 12 Aug 2023 12:14:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUrFa-0006m8-F3 for bug-guix@gnu.org; Sat, 12 Aug 2023 12:14:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUrFa-0001Oc-70 for bug-guix@gnu.org; Sat, 12 Aug 2023 12:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUrFa-0000vi-1b for bug-guix@gnu.org; Sat, 12 Aug 2023 12:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#65218: emacs-orderless 1.0 shows as 0.8 due to incorrect value in package file Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 12 Aug 2023 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65218 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Piotr =?UTF-8?Q?Kwieci=C5=84ski?= Cc: 65218@debbugs.gnu.org Received: via spool by 65218-submit@debbugs.gnu.org id=B65218.16918567823491 (code B ref 65218); Sat, 12 Aug 2023 16:14:02 +0000 Received: (at 65218) by debbugs.gnu.org; 12 Aug 2023 16:13:02 +0000 Received: from localhost ([127.0.0.1]:56711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUrEb-0000u3-Ki for submit@debbugs.gnu.org; Sat, 12 Aug 2023 12:13:02 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:43908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUrEZ-0000to-2t for 65218@debbugs.gnu.org; Sat, 12 Aug 2023 12:12:59 -0400 Date: Sat, 12 Aug 2023 23:57:43 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1691856767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nPekc22gYcEx0MXso+6oTaAPgutcYP/GatKCg+kTPHw=; b=iQk9TGJevT1X4+G9Wlp3qe+zP9dySmQdfoDoiuJaauwhf4/rfILao8P1rHuqE9mmRv/piI iUyCc2yN1ETCuqVlQnkXXjquUmL+pzT61RrKVRRncZMZYNLNOELryaw7656iZVI0PPctCC s7JNLtqZcymrWrmQENGdD0qXyVkCz9t0jUWwUPu9GG2H3JTCkAs0eJ2MAkmNXQhOGLkJ+U fZEL/oH24FfEX2joKLp/Of7Jb81/DZjHc4PxDVEF3fQiYhosaxzhhJ/Hwl0hwKP0PCpF9q sH2mOqfRuhSA/CGVj+G89AaX/gNLk5l/7sHQuOudj34qoe5DL5U+u/iqGTOUyw== Message-ID: <87jzu0qmmg.wl-hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain From: Hilton Chain via Bug reports for GNU Guix Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.68 X-Spam-Score: -6.68 X-Migadu-Queue-Id: 03C0E3EB3B X-Migadu-Scanner: mx2.migadu.com X-TUID: x29650EYK4Gv Hi Piotr, On Fri, 11 Aug 2023 04:18:57 +0800, Piotr Kwieci=C5=84ski wrote: > > [1 ] > [2 ] > I have the latest version of emacs-orderless installed on using guix and = it shows: > > Status: External in =E2=80=98/gnu/store/mp2ckcr7psy9myby262zqii36cd49yja= -emacs-orderless-1.0/share/emacs/site-lisp/orderless-1.0/=E2=80=99 (unsigne= d). > Version: 0.8 > Summary: Completion style for matching regexps in any order > > This is caused by an incorrect version of a package declared in orderless= .el. It seems that emacs-orderless in Guix wasn't really updated to 1.0, only the version field was changed. > I'm new to the ecosystem and I'm not familiar with the process of fixing = this. > The issue was fixed by the package maintainer in commit > https://github.com/oantolin/orderless/commit/847694e78c12d903d5e3f6cb365a= 5d3b984db537 > > Would replacing commit in the package definition be enough ? Swapping 004= cee6b8e01f8eb0cb1c683d0a637b14890600f with > 847694e78c12d903d5e3f6cb365a5d3b984db537 That's not enough, the hash in (sha256 (base32 [...])) needs changing as well. And when updating an untagged revision to a tagged release, we usually drop the outer let form, and use the value from version field for commit. For example, the original definition: --8<---------------cut here---------------start------------->8--- (define-public emacs-orderless (let ((commit [...])) (package (name "emacs-orderless") (version [...]) (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/oantolin/orderless") (commit commit))) (file-name (git-file-name name version)) (sha256 (base32 [...])))) [...]))) --8<---------------cut here---------------end--------------->8--- would be changed to: --8<---------------cut here---------------start------------->8--- (define-public emacs-orderless (package (name "emacs-orderless") (version "1.0") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/oantolin/orderless") (commit version))) ; <- see here (file-name (git-file-name name version)) (sha256 (base32 [...])))) ; <- hash is changed as well [...])) --8<---------------cut here---------------end--------------->8--- BTW the hash can be obtained with `guix hash' [1]: --8<---------------cut here---------------start------------->8--- git clone https://[...] emacs-orderless cd emacs-orderless git checkout 1.0 guix hash -rx . --8<---------------cut here---------------end--------------->8--- Would you like to get familiar with the process by going through the way [2] to make your first contribution? ;) I can send a patch if you prefer, and it may take a few days to get the change into Guix. Thanks [1]: [2]: (Not sure why this issue isn't on the mailing list, but is available in Debbugs. Still under moderation?)