From: Alex Sassmannshausen <alex.sassmannshausen@gmail.com>
To: bug-guix@gnu.org
Subject: Re: Rollback problems
Date: Thu, 24 Jan 2013 15:33:48 +0000 [thread overview]
Message-ID: <87ip6mzjc3.fsf@gmail.com> (raw)
In-Reply-To: <87mwvystku.fsf@gnu.org>
Hello,
For what it's worth, my 2 cents on the issue:
- I too think that rollback into an empty profile should be
possible. The empty state seems like a valid state to be in for me.
On the issue of rollbacks and branches, I like the simplicity of
numbers. To try and understand Ludo's suggestion, would the following be
right?
>> I find the behaviour of roll back currently very confusing, and the
>> situation looks reasonable to me:
>> I install hello, it works, so I keep it.
Generation 1, from Generation 0
>> I install freetype,
Generation 2, from Generation 1
>> it does not work, so I drop it again.
Generation 1, from Generation 2
>> I install file,
Generation 3, from Generation 1
>> it does not work, so I drop it again.
Generation 1, from Generation 3
Is rollback supposed to be one-directional? I.e. you can go back in
time, but you can't then go forward in time again ('undo' and 'redo')?
It makes sense for rollback, but it would be cool to be able to move
forward again (conceptually — I don't know whether it would be useful in
real life…).
--switch-generation would allow one to move forward anyhow. And
presumably we'd need some way to output descriptive state information
between the different generations, to be able to switch between those
effectively. Or at least the differences between a target generation and
the current one.
Numbers seem sensible as a means to navigate using switch, and as
shorthand, but maybe, for completeness, the full identifier should be
some form of combination of the 'descriptive number' and the 'forward'
and 'backward' neighbours.
Generations should not just remember how you got there, but also where
you went after that.
An example might be:
Blank profile: generation 0
Install pdfwrit3r: generation 1
Actually that's pretty rubbish -> rollback: generation 0
Install pdfwriter: generation 2
No, this is even worse! -> Panic, rollback: generation 0
But we need *something* -> 'rollforward' should allow me to choose
between generation 1 and generation 2, as both are direct 'neighbours'
of 0. This functionality would be provided by --switch-generation
anyway, but maybe this provides a concrete example of how a user might
want to move back and forth.
I don't know whether the above explodes the framework of what --rollback
is intended for though, so it might not be helpful at all.
Best wishes,
Alex
You might rollback to generation 1, but really that gener
> Right, that seems like a real-world scenario, I admit.
>
> So I guess we can make that change. That will mean storing the ordered
> list of previous generations in each generation’s manifest, and then
> getting the previous generation number from there.
>
Ludovic Courtès <ludo@gnu.org> writes:
> Hello!
>
> Andreas Enge <andreas@enge.fr> skribis:
>
>> Am Mittwoch, 23. Januar 2013 schrieb Ludovic Courtès:
>>> And what if you roll back once you’re at the empty profile?
>>
>> Then nothing should happen.
>>
>>> It seems more intuitive for me to error out like this, because there was
>>> really nothing but nothingness before “hello” was installed. :-)
>>> WDYT?
>>
>> No, I disagree; when I have nothing, install hello and roll back, I should
>> be back to nothing. Some other opinions would be useful on this matter.
>
> Hmm, OK.
>
> Well, that’s doable, so if you or others find it less confusing this
> way, it’s probably worth doing it.
>
>>> This is expected (same behavior as nix-env.) Profile generations are
>>> not deleted unless you explicitly do so; this is what guarantees that
>>> one can roll back anywhere they want.
>>>
>>> But I wonder if this is really worth the trouble. In my experience, a
>>> scenario like the one above rarely happens, if ever.
>>
>> I find the behaviour of roll back currently very confusing, and the
>> situation looks reasonable to me:
>> I install hello, it works, so I keep it.
>> I install freetype, it does not work, so I drop it again.
>> I install file, it does not work, so I drop it again.
>> Now I expect to have only hello, but I have hello and freetype.
>
> Right, that seems like a real-world scenario, I admit.
>
> So I guess we can make that change. That will mean storing the ordered
> list of previous generations in each generation’s manifest, and then
> getting the previous generation number from there.
>
> I wonder if generations should be identified by a number at all, then.
>
> Thoughts?
>
> Thanks,
> Ludo’.
next prev parent reply other threads:[~2013-01-24 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 20:48 Rollback problems Andreas Enge
2013-01-23 22:58 ` Ludovic Courtès
2013-01-23 23:17 ` Andreas Enge
2013-01-24 11:34 ` Ludovic Courtès
2013-01-24 15:33 ` Alex Sassmannshausen [this message]
2013-01-24 15:59 ` Ludovic Courtès
2013-01-24 20:52 ` Ludovic Courtès
2013-01-25 2:44 ` Nikita Karetnikov
2013-01-25 13:54 ` Alex Sassmannshausen
2013-01-25 14:48 ` Andreas Enge
2013-01-25 14:53 ` Ludovic Courtès
2013-01-27 17:05 ` Ludovic Courtès
2013-01-28 22:10 ` Andreas Enge
2013-01-28 22:44 ` Ludovic Courtès
2013-01-25 3:08 ` Nikita Karetnikov
2013-01-27 17:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ip6mzjc3.fsf@gmail.com \
--to=alex.sassmannshausen@gmail.com \
--cc=bug-guix@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).