unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 19840-done@debbugs.gnu.org
Subject: bug#19840: "Bad uri header component" when downloading from gitorious.org
Date: Thu, 19 Feb 2015 03:42:24 -0500	[thread overview]
Message-ID: <87ioeygumn.fsf@netris.org> (raw)
In-Reply-To: <874mqsns2h.fsf@mango.localdomain> (Ricardo Wurmus's message of "Wed, 11 Feb 2015 20:53:10 +0100")

Ricardo Wurmus <rekado@elephly.net> writes:

> Downloading archives from gitorious fails:
>
>     ~/dev/guix $ ./pre-inst-env guix download https://gitorious.org/lv2-synths/lv2-mdametapiano/archive/0.0.1.tar.gz
>     starting download of `/tmp/guix-file.gqYdZs' from `https://gitorious.org/lv2-synths/lv2-mdametapiano/archive/0.0.1.tar.gz'...
>     ERROR: Bad uri header component: /lv2-synths/lv2-mdametapiano/archive/ceb5345396425ad526be34c79eae2b4dfe886d5b.tar.gz

Guile's parsing and validation of HTTP "Location" headers was based on
the now obsolete RFC 2616 section 14.30, which required it to be an
absolute URI.  However, RFC 7231 section 7.1.2 allows it to be any URI
reference, which can include relative URIs.

This will be fixed in Guile 2.0.12.

Additionally, the possibility of HTTP redirects to relative URIs
requires us to determine the target URI based on a relative URI and base
URI, using the algorithm described in RFC 3986 section 5.2.2.

I just pushed commit 04dec194d8 to master which resolves both of these
issues.  I'm closing this bug now.

     Thanks!
       Mark

      reply	other threads:[~2015-02-19  8:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11 19:53 bug#19840: "Bad uri header component" when downloading from gitorious.org Ricardo Wurmus
2015-02-19  8:42 ` Mark H Weaver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ioeygumn.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=19840-done@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).