From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#27429: core-updates and shishi [was Re: bug#27429: Stack clash
	(CVE-2017-1000366 etc)]
Date: Fri, 30 Jun 2017 14:59:10 +0200
Message-ID: <87injdmy1t.fsf@gnu.org>
References: <20170621084134.GA2870@macbook42.flashner.co.il>
	<20170621095045.GB2870@macbook42.flashner.co.il>
	<20170621235227.GA4510@jasmine.lan>
	<20170622000336.GB4510@jasmine.lan> <87zid0iksk.fsf@netris.org>
	<87mv8rqcuu.fsf@gnu.org> <87h8yyn696.fsf@netris.org>
	<87wp7ulftb.fsf@gnu.org> <20170629210317.GB19238@jasmine.lan>
	<8760fesa36.fsf@gnu.org> <20170630064714.GA13156@jasmine.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40972)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dQvWo-0004q3-I2
	for bug-guix@gnu.org; Fri, 30 Jun 2017 09:00:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dQvWl-0006rU-Hl
	for bug-guix@gnu.org; Fri, 30 Jun 2017 09:00:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42933)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dQvWl-0006qw-E2
	for bug-guix@gnu.org; Fri, 30 Jun 2017 09:00:03 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27429.B27429.14988275642321@debbugs.gnu.org>
In-Reply-To: <20170630064714.GA13156@jasmine.lan> (Leo Famulari's message of
	"Fri, 30 Jun 2017 02:47:14 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 27429@debbugs.gnu.org

Leo Famulari <leo@famulari.name> skribis:

> On Fri, Jun 30, 2017 at 12:27:57AM +0200, Ludovic Court=C3=A8s wrote:
>> > -    (native-inputs `(("pkg-config" ,pkg-config)))
>> > +    (arguments
>> > +     `(#:phases
>> > +       (modify-phases %standard-phases
>> > +         (add-before 'configure 'bootstrap
>> > +           (lambda _ (zero? (system* "autoreconf" "-vfi")))))))
>> > +    (native-inputs `(("pkg-config" ,pkg-config)
>> > +                     ;; XXX For bootstrapping. Remove for the next Sh=
ishi
>> > +                     ;; release after 1.0.2.
>> > +                     ("autoconf" ,autoconf)
>> > +                     ("automake" ,automake)
>> > +                     ("gettext" ,gnu-gettext)
>> > +                     ("libtool" ,libtool)
>> > +                     ("texinfo" ,texinfo)))
>>=20
>> I think you can achieve the same result but without adding these
>> dependencies etc. just by adding:
>>=20
>>   #:configure-flags '("ac_cv_libgcrypt=3Dyes")
>>=20
>> which I think is marginally better (but no big deal).
>
> Yes, that's better. I built Shishi and GSS with it locally, pushed, and
> started a core-updates evaluation.

OK.

> But I don't know if we will hit this evaluation failure also on
> core-updates since I merged master:
>
> https://lists.gnu.org/archive/html/guix-devel/2017-06/msg00349.html

Oops indeed.  I fixed it in master and merged the fixed.  New evaluation
pending.

Thanks,
Ludo=E2=80=99.