unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Adonay Felipe Nogueira <adfeno@openmailbox.org>
To: 27590@debbugs.gnu.org
Subject: bug#27590: artanis has a bundled and customized copy of guile-json package
Date: Mon, 17 Jul 2017 00:11:07 -0300	[thread overview]
Message-ID: <87inir92r8.fsf@openmailbox.org> (raw)
In-Reply-To: <87mv8i4tkj.fsf@openmailbox.org> (Adonay Felipe Nogueira's message of "Wed, 05 Jul 2017 15:39:08 -0300")

I have compared the two. Note however that I didn't test them, I only
read the diffs, so my notes might not accurately reflect nested/complex
cases.

Discarding the new features implemented in guile-json since the bundled
customization and the deprecation of (json ...) macro, it seems that
"json/builder.scm" is the file where most important changes are.

Considering upstream guile-json:

- (json-build-object ...) considers the given Scheme "native" directly as
  a list of pairs (that is: no conversion is done inside the procedure
  itself).

- (json-build ...) has conditionals for checking if a given Scheme
  "native" is a symbol, and also for checking if it's an association
  list.

- Inside (json-build ...), the conditional that checks if the givem
  Scheme object is a hash table also builds JSON documents for those
  cases, but instead of taking the Scheme "native" as it is, it will
  receive such converted to a list of pairs.

Considering the bundled and customized guile-json:

- (json-build-object ...) calls procedures to convert the given Scheme
  "native" to a list of pairs (that is: there is always a conversion made
  inside the procedure).

- (json-build ...) has no conditionals to check for symbols and
  association lists specially.

- Inside (json-build ...), the conditional that checks if the givem
  Scheme object is a hash table takes the Scheme "native" as it is.

This indicates that upstream guile-json seems to have more control on
what to do with each thing. However, I don't know if this really impacts
GNU Artanis such that there is an unexpected behavior. From the looks of
it, there might be no problem on removing the bundle. Of course, a test
is preferable.

  parent reply	other threads:[~2017-07-17  3:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 18:39 bug#27590: artanis has a bundled and customized copy of guile-json package Adonay Felipe Nogueira
2017-07-05 22:07 ` Ludovic Courtès
2017-07-16 14:58 ` Adonay Felipe Nogueira
2017-07-17  3:11 ` Adonay Felipe Nogueira [this message]
2017-07-28 14:28 ` Adonay Felipe Nogueira
2017-08-01 12:34   ` Ludovic Courtès
2017-07-28 14:29 ` Adonay Felipe Nogueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inir92r8.fsf@openmailbox.org \
    --to=adfeno@openmailbox.org \
    --cc=27590@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).