From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#35068: GDM crashes when it cannot find any .desktop files
Date: Fri, 26 Apr 2019 10:10:48 +0200
Message-ID: <87imv1nq47.fsf@gnu.org>
References: <87lg0um9qb.fsf@gnu.org> <20190420170649.30c05dbd@scratchpost.org>
	<20190421113749.0439cbc9@scratchpost.org> <87v9z72k3p.fsf@gnu.org>
	<87tvel7we1.fsf@ngyro.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:39186)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJvwl-0000IC-T4
	for bug-guix@gnu.org; Fri, 26 Apr 2019 04:11:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJvwk-0006dg-PM
	for bug-guix@gnu.org; Fri, 26 Apr 2019 04:11:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:46430)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hJvwk-0006da-L3
	for bug-guix@gnu.org; Fri, 26 Apr 2019 04:11:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hJvwk-0000eM-FL
	for bug-guix@gnu.org; Fri, 26 Apr 2019 04:11:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.35068.B35068.15562662582476@debbugs.gnu.org>
In-Reply-To: <87tvel7we1.fsf@ngyro.com> (Timothy Sample's message of "Thu, 25
	Apr 2019 14:49:42 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: 35377@debbugs.gnu.org, 35068@debbugs.gnu.org

Hello,

Timothy Sample <samplet@ngyro.com> skribis:

> There are two workarounds.  The first is to keep Danny=E2=80=99s patch as=
-is,
> but add logic to =E2=80=9Cxinitrc=E2=80=9D so that it only uses =E2=80=9C=
~/.xsession=E2=80=9D when
> passed =E2=80=9Ccustom=E2=80=9D as an argument (it=E2=80=99s kinda magic,=
 but it seems to be a
> common convention).  I have a slight preference for this option, because
> it makes the whole =E2=80=9C~/.xsession=E2=80=9D thing more explicit.  Ho=
wever, it would
> break other DMs that don=E2=80=99t install a =E2=80=9Ccustom.desktop=E2=
=80=9D.  Maybe we could
> integrate it into all DMs at the service level.
>
> The quicker workaround is to keep the current logic, and install the
> following with GDM:
>
>     [Desktop Entry]
>     Encoding=3DUTF-8
>     Type=3DApplication
>     Name=3DFail
>     Comment=3DThis session always fails.
>     NoDisplay=3Dtrue
>     Exec=3Dfalse
>
> This way, GDM fails cleanly when there are no =E2=80=9C.desktop=E2=80=9D =
files.  It
> doesn=E2=80=99t show up in the list, either (=E2=80=9CNoDisplay=3Dtrue=E2=
=80=9D), so everything
> just kinda works as expected without any visible changes.

I have a slight preference for the hack you propose Timothy, at least in
the short term, because it seems less likely to break anything than
fiddling with =E2=80=9CExec=3Dcustom=E2=80=9D and all that.

Anyway, it=E2=80=99d be great if one of you could push a fix by 1.0.  :-)

Thanks,
Ludo=E2=80=99.