From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iLQWJVvS5170dQAA0tVLHw (envelope-from ) for ; Mon, 15 Jun 2020 19:56:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qAoEIVvS5144OgAAB5/wlQ (envelope-from ) for ; Mon, 15 Jun 2020 19:56:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE4FF940704 for ; Mon, 15 Jun 2020 19:56:10 +0000 (UTC) Received: from localhost ([::1]:48514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkvDF-0000lU-TO for larch@yhetil.org; Mon, 15 Jun 2020 15:56:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkvD8-0000lG-Cl for bug-guix@gnu.org; Mon, 15 Jun 2020 15:56:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkvD8-0000qH-3e for bug-guix@gnu.org; Mon, 15 Jun 2020 15:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkvD8-00067V-0G for bug-guix@gnu.org; Mon, 15 Jun 2020 15:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41855: [PATCH 1/2] hurd-boot: Create individual translators instead of running MAKEDEV. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 15 Jun 2020 19:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41855 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: "Jan \(janneke\) Nieuwenhuizen" Received: via spool by 41855-submit@debbugs.gnu.org id=B41855.159225090223449 (code B ref 41855); Mon, 15 Jun 2020 19:56:01 +0000 Received: (at 41855) by debbugs.gnu.org; 15 Jun 2020 19:55:02 +0000 Received: from localhost ([127.0.0.1]:47530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkvCA-000669-7U for submit@debbugs.gnu.org; Mon, 15 Jun 2020 15:55:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkvC8-00065c-2P for 41855@debbugs.gnu.org; Mon, 15 Jun 2020 15:55:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42711) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkvC2-0000ZQ-Or; Mon, 15 Jun 2020 15:54:54 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40668 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jkvC2-0002wy-8a; Mon, 15 Jun 2020 15:54:54 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200614165430.3411-1-janneke@gnu.org> <20200614165649.3496-1-janneke@gnu.org> Date: Mon, 15 Jun 2020 21:54:52 +0200 In-Reply-To: <20200614165649.3496-1-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Sun, 14 Jun 2020 18:56:48 +0200") Message-ID: <87imfsyuib.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41855@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 2idXc/RCZbJK Hi! "Jan (janneke) Nieuwenhuizen" skribis: > * gnu/build/hurd-boot.scm (make-hurd-device-nodes): Do not create > dev/{null,zero,full,random,urandom} mount points. > (setup-translator, xattr-translator, > showtrans-translator?, translated?, set-hurd-device-translators): New > procedures. > (boot-hurd-system): Use them instead of running MAKEDEV. This is mostly about moving the logic from the MAKEDEV script to this file, right? Sounds nice. > +(define (xattr-translator? file-name) > + "Return true if FILE-NAME has an extended @code{gnu.translator} attrib= ute > +set." > + (false-if-exception > + (not (string-null? (getxattr file-name "gnu.translator"))))) I=E2=80=99d call it =E2=80=98passive-translator-xattr?=E2=80=99. In general, I=E2=80=99d avoid =E2=80=98false-if-exception=E2=80=99 as much = as possible because it can hide real issues. So here, you could catch 'system-error and check for ENODATA. If you need it in several places, you can define a =E2=80=98false-if-ENODATA=E2=80=99 macro > +(define (showtrans-translator? file-name) > + "Return true if @file{showtrans} finds a translator installed on FILE-= NAME." Should be =E2=80=98passive-translator-installed?=E2=80=99 no? (IIRC =E2=80= =98showtrans=E2=80=99 only shows passive translator settings by default.) > + (with-output-to-port (%make-void-port "w") > + (lambda _ > + (with-error-to-port (%make-void-port "w") > + (lambda _ > + (zero? (system* "showtrans" "--silent" file-name))))))) > + > +(define (translated? file-name) > + "Return true if a translator is installed on FILE-NAME." > + (if (string-contains %host-type "linux-gnu") > + (xattr-translator? file-name) > + (showtrans-translator? file-name))) It=E2=80=99s counter-intuitive that hurd-boot.scm is used from GNU/Linux. Should we move the shared bits in (gnu build hurd) or similar? > +(define* (setup-translator file-name command #:optional (mode #o600)) > + "Setup translator COMMAND on FILE-NAME." =E2=80=98set-translator=E2=80=99? :-) > + (false-if-exception (mkdir-p (scope "dev/vcs/1"))) > + (false-if-exception (mkdir-p (scope "dev/vcs/2"))) > + (false-if-exception (mkdir-p (scope "dev/vcs/3"))) > + (false-if-exception (rename-file "/dev/console" "/dev/console-")) > + (for-each scope-setup-translator devices) > + > + (false-if-exception (symlink "/dev/random" "/dev/urandom")) > + (false-if-exception (mkdir-p "/dev/fd")) > + (false-if-exception (symlink "/dev/fd/0" "/dev/stdin")) > + (false-if-exception (symlink "/dev/fd/1" "/dev/stdout")) > + (false-if-exception (symlink "/dev/fd/2" "/dev/stderr"))) =E2=80=98false-if-EEXIST=E2=80=99? Thanks! Ludo=E2=80=99.