From: Jan Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 44000@debbugs.gnu.org
Subject: bug#44000: Guile-Git cross-compiled to i586-pc-gnu gets bytestructures wrong
Date: Thu, 15 Oct 2020 12:06:24 +0200 [thread overview]
Message-ID: <87imbbls67.fsf@gnu.org> (raw)
In-Reply-To: <871ri0c4u8.fsf@gnu.org> ("Ludovic Courtès"'s message of "Thu, 15 Oct 2020 09:42:55 +0200")
Ludovic Courtès writes:
Hi,
> Ludovic Courtès <ludo@gnu.org> skribis:
>
>> The problem is that the ‘cond-expand’ used to define ‘arch32bit?’ is a
>> expansion-time thing when (cross-)building Bytestructures itself, so
>> it’s incorrect from cross-building from 64-bit to 32-bit.
>>
>> I believe that changing it to:
>>
>> (define arch32bit? (memq data-model '(ilp32 lp32)))
>>
>> would fix it because then the test would happen at run time.
>
> I confirm that the attached patch for Bytestructures solves the problem
> (running ‘guix pull’ in my childhurd :-)).
Wow, beautiful!
> Let’s see whether it needs to be adapted for inclusion upstream.
Yes, sure.
Greetings,
Janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
next prev parent reply other threads:[~2020-10-15 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 22:25 bug#44000: Guile-Git cross-compiled to i586-pc-gnu gets bytestructures wrong Ludovic Courtès
2020-10-15 7:42 ` Ludovic Courtès
2020-10-15 8:09 ` Ludovic Courtès
2020-10-15 8:48 ` Mathieu Othacehe
2020-10-15 10:06 ` Jan Nieuwenhuizen [this message]
2020-10-16 15:58 ` Taylan Kammer
2020-10-17 17:44 ` Taylan Kammer
2020-10-19 8:23 ` Ludovic Courtès
2020-10-22 18:47 ` Taylan Kammer
2020-11-16 16:10 ` Ludovic Courtès
2020-11-16 17:07 ` Taylan Kammer
2020-11-16 17:37 ` Ludovic Courtès
2020-11-16 22:01 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imbbls67.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=44000@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).