unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: Zhu Zihao <all_but_last@163.com>, 45193@debbugs.gnu.org
Subject: bug#45193: Wrapper of Qt programs doesn't extend existing environment variable
Date: Mon, 14 Dec 2020 15:45:23 -0500	[thread overview]
Message-ID: <87im94ru9t.fsf@netris.org> (raw)
In-Reply-To: <86wnxns81f.fsf@163.com>

Hi,

Zhu Zihao <all_but_last@163.com> writes:

> Reproduce steps:
>
>    guix environment --ad-hoc qbittorrent && cat $GUIX_ENVIRONMENT/bin/qbittorrent
>
>
> We can see the wrapper generated in qt-build-system doesn't extend
> existing environment variable. Instead, it overrides them.
>
> It was discussed in
> https://lists.gnu.org/archive/html/guix-devel/2019-12/msg00117.html one
> year ago. This's not a trivial issue because using input method in Qt
> program requires an qt plugin(XIM doesn't work here) which is managed by
> QT_PLUGIN_PATH.
>
> We should change following functions:
>
> 1. guix/build/qt-build-system.scm(wrap-all-programs)
> 2. guix/build/qt-utils.scm(wrap-qt-program)
>
> It's ideal to make wrap-all-programs use wrap-qt-program internally and
> we don't need to maintain two copy of wrap code.

I agree with your analysis.  Would you like to propose a patch and test
it as thoroughly as you can?

     Regards,
       Mark




  parent reply	other threads:[~2020-12-14 20:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12  9:11 bug#45193: Wrapper of Qt programs doesn't extend existing environment variable Zhu Zihao
     [not found] ` <handler.45193.B.160776432713396.ack@debbugs.gnu.org>
2020-12-12  9:19   ` bug#45193: Acknowledgement (Wrapper of Qt programs doesn't extend existing environment variable) Zhu Zihao
2020-12-14 20:45 ` Mark H Weaver [this message]
2020-12-15  1:50   ` bug#45193: Wrapper of Qt programs doesn't extend existing environment variable Zhu Zihao
2020-12-17 11:35   ` Zhu Zihao
2020-12-19 13:13 ` Hartmut Goebel
2020-12-19 18:20   ` Zhu Zihao
2020-12-19 19:12     ` Hartmut Goebel
2021-01-10 16:34   ` Zhu Zihao
2021-01-11  8:17     ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87im94ru9t.fsf@netris.org \
    --to=mhw@netris.org \
    --cc=45193@debbugs.gnu.org \
    --cc=all_but_last@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).