From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4j4NNtAKXGBRMAAAgWs5BA (envelope-from ) for ; Thu, 25 Mar 2021 05:00:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wLiwMNAKXGA1HAAAbx9fmQ (envelope-from ) for ; Thu, 25 Mar 2021 04:00:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4F1531EF72 for ; Thu, 25 Mar 2021 05:00:15 +0100 (CET) Received: from localhost ([::1]:48640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPHAL-0005Cx-4a for larch@yhetil.org; Thu, 25 Mar 2021 00:00:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49712) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPHAA-0005AB-VO for bug-guix@gnu.org; Thu, 25 Mar 2021 00:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPHAA-0001ZK-Lq for bug-guix@gnu.org; Thu, 25 Mar 2021 00:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPHAA-0004kC-Jl for bug-guix@gnu.org; Thu, 25 Mar 2021 00:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47375: guix test failure: tests/print Resent-From: Chris Marusich Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 25 Mar 2021 04:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47375 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Julien Lepiller Received: via spool by 47375-submit@debbugs.gnu.org id=B47375.161664479618161 (code B ref 47375); Thu, 25 Mar 2021 04:00:02 +0000 Received: (at 47375) by debbugs.gnu.org; 25 Mar 2021 03:59:56 +0000 Received: from localhost ([127.0.0.1]:36739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPHA4-0004ir-9o for submit@debbugs.gnu.org; Wed, 24 Mar 2021 23:59:56 -0400 Received: from mail-pj1-f44.google.com ([209.85.216.44]:54027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPHA1-0004id-HY for 47375@debbugs.gnu.org; Wed, 24 Mar 2021 23:59:54 -0400 Received: by mail-pj1-f44.google.com with SMTP id t18so485591pjs.3 for <47375@debbugs.gnu.org>; Wed, 24 Mar 2021 20:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=JYZBDQNxsb/geDx0xIwwajTM4s8pOzcVVWwdoH72krI=; b=e2qdeXObSN2G3aRNxfJ9mIPe/0VZBn6PnPl3NxxlMx6N/o6DZTJXZ0qUOdqpkMXut1 LrRAZpxNLyLq9Biw8IsI4BKruCHuJ1skg8f5hpFRBAwkZD4PepnYmmXyr9JIuptNYigv 18V1ZX6LbAShDl+N+uhAId9m2LAEruvKHPqKaMiWW/2Xvq1tCs3Lh9V7xyo5aiau3Bl3 ObDKJdzbo3hXq7XWQrGh/I6dljQz1vzv9gYb/qAJryS+spP7fJoH0VOt5rvcLGyTkED8 EHT4hZPS/6YCNIopRjHUaQsaLY9a4Xk2/tp/uA1RVx7Gkf2CclcfsrXxdsI/Et+W07g0 orNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=JYZBDQNxsb/geDx0xIwwajTM4s8pOzcVVWwdoH72krI=; b=Nt80RR+fOtweKllBeCciFyxnDe/k1n7P+l3tZTT9Gjc2uDIr3ltBy+1fUp7DQE13pu rxlz7qlHUF6s3uqi8h4jQv4aJ0ghV7FKNEGzUJ8KKWXoKxXjjl9u3ou0fIkGX8P+fiRQ wBl7D5DEHQD2zcJyW6N8aKA8EHr2jfWFa5oHCPN6WkNRqynWuPVEa1tWcclM2AL8K/gA HHLRUVL6Q+2qGJIhtV2pZPYfrB5DRlfq79p+dV1EatMtkPf1f2c1+8elzAzQCKNzIRcf 8ifRfMm+yzt3dQGbDvNVl1Ls7GeMMY33xntAey72V3W8KzVCZQTOx5mFiVteFo4HmUr0 w8hQ== X-Gm-Message-State: AOAM532nYMpd8ofIhlQ6qHtw71fGp2468v7D/yyReWITQZ02uY/Iad20 O5FK+lAeW8KJZJiaQP3FDsJEU994Ens= X-Google-Smtp-Source: ABdhPJzQUbs+tHH10m2d3guIcpdp5mRapXiWDx8VOJAJLgL94/hnQRj25dUTtwmPg0dtPfZXZ71GoQ== X-Received: by 2002:a17:90a:9f8c:: with SMTP id o12mr6622399pjp.215.1616644787023; Wed, 24 Mar 2021 20:59:47 -0700 (PDT) Received: from garuda-lan (c-24-18-44-142.hsd1.wa.comcast.net. [24.18.44.142]) by smtp.gmail.com with ESMTPSA id h15sm4019077pfo.20.2021.03.24.20.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 20:59:46 -0700 (PDT) From: Chris Marusich References: <818412ea23ae7ce27a673afd1dfe3bb9d758c340.camel@zaclys.net> Date: Wed, 24 Mar 2021 20:59:41 -0700 In-Reply-To: (Julien Lepiller's message of "Wed, 24 Mar 2021 21:54:48 -0400") Message-ID: <87im5f7uj6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 47375@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616644815; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JYZBDQNxsb/geDx0xIwwajTM4s8pOzcVVWwdoH72krI=; b=i9GXD1/omsidAB1YZVTfnR+C2PzosGOu2UMWZWHezwRNuq/NebGB1eLN36F8L+moNo5dp9 WZuPp3H8LA3yAJcHHS0iU9Y3bwFdRs8o0rIv1IU3AdCS79MO+WiTjnNN9mSPZ3Y4FwKVdF BH8DoLaEroaV4K9Zcgrqe5xYJUOf3KXoIzpQyqxI49CvGnYS6ky+WFEgPTNKQAOPGm2XEp LQJzgwp8dv/9LMa2aj1VqEUWGJr9qi3tHtXRbX4zxYOnSoM9bRHmEbhXFBArdbp0J9rxBI BEruhnyD+hlermU7olHkZLYKyBzPnUfziOkGwWpc3vA3cbEULOoaqIOmVZ9c0A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616644815; a=rsa-sha256; cv=none; b=YCnzgUmujKI5IOBNG//8rkSqADOHEUacN0E3BL/gvf2ZjPym8fXBQ0K77+tSo9rs5Ktecy jOIXSeImgRUNiGhXe+nZNkpX3aY09fTGKJMsfvLjCl+LQ4rM8BHsM6VQqW3f/Ik8YAn/o/ 7UEa93H7FYjDWGNazqAg7xTecdgIfNeXsmKODjJ+VBn7S7D+x4s4958VroSK1WDzW2RTXf cr3Ubs3BcP/posqXo6A6W0/jPa9K8ijgdqfIdWgy/QkTmL7JzzlxB5W0PsXTOZushDhhgC 82/r9E1pq3LgZLuk+4PR9vj4JGkgdYaaIYAJMqmz1QFTiNsygZ/BTHMUCP+K7A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=e2qdeXOb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: 0.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=e2qdeXOb; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 4F1531EF72 X-Spam-Score: 0.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: /J6WTmJyf1+o --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Julien Lepiller writes: > I don't think this is the right fix. Now you define packages with the > incorrect url-fetch, so the test passes, but package->code would still > not work as intended on actual packages that are properly defined. > > It seems that the issue is package->code uses the internal name > url-fetch* whereas it should be the exported name url-fetch. I think > this is a legitimate bug in package->code and your patch incorrectly > hides it. I think Julien is correct. The url-fetch* procedure from guix/download.scm is here: (define* (url-fetch* url hash-algo hash #:optional name #:key (system (%current-system)) (guile (default-guile)) executable?) "Return a fixed-output derivation that fetches data from URL (a string, o= r a list of strings denoting alternate URLs), which is expected to have hash HA= SH of type HASH-ALGO (a symbol). By default, the file name is the base name of URL; optionally, NAME can specify a different file name. When EXECUTABLE? = is true, make the downloaded file executable. ... And the url-fetch procedure from guix/build/download.scm is here: (define* (url-fetch url file #:key (timeout 10) (verify-certificate? #t) (mirrors '()) (content-addressed-mirrors '()) (hashes '()) print-build-trace?) "Fetch FILE from URL; URL may be either a single string, or a list of string denoting alternate URLs for FILE. Return #f on failure, and FILE on success. ... They do different things, even though they share the same name. The problem, apparently introduced with commit f7008ca71351e5368a7c1c5bc3fe88fb80b01298, is that before the change, package->code produced code that uses url-fetch, and after the change, it produced code that uses url-fetch*. Reverting the change fixes it. I reverted it and tested it, and it does fix the test. I wonder if we can just revert it for now? What do you think, Ludo? In guix/import/print.scm, package->code generates the code by invoking (origin-method source) to get the origin's "method", and then invoking (procedure-name method) on the method thus obtained. It seems that procedure-name returns the name "url-fetch*" (the name used privately in the (guix download) module), but it should be returning the name "url-fetch" (the public name exported by the (guix download) module). I wonder if there is any way to get the public name of the procedure programmatically, instead of the private one? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAmBcCq0VHGNtbWFydXNp Y2hAZ21haWwuY29tAAoJEN1AmhXYIkadsJ8QAI9HGS8/cSHuMViQ3aVKoS/oOGc4 EWshV6sO3kEClyK9vePgYs5tl6QlT54Red77Z4h8T0e+QqieISGaiwejZ+bpZmv3 OdExSG+2xI5om7ko4eQZuxTOy1P/PzdYdV5YB3vkel267EBLda1+D7U1/okgtLtF MjfMjajnC2F+D7Ok9V8P9sberoQqSzBHoh9B8C1BsA0GbQtdzgDgufe4MoUAGIhj ZuiA2Oe7hQZ3xAzCe/BKUijR58pczvnv/4Ruzr+CvI1nKStvLkAeG0Zcafx1763J zXA7f6+yqAIfYQ5D1FPwNkMptMo6ZiY3+XmueXSrPgAwe9VtDb6VHN2egLwBnlpP b/HE8CQIRcpxfYImPhGp/zc3eFaZ4EomGFwaIIiBNGYYgNJimej1AThJJoLV9vVr Rz1fgoyMqTFL5xE80ggumrKCME4Wk3iFsJpaAFRFroUZkrioy5F6klCl59gbg8S/ +MsRmT6IUxEWmBHd9FESoCmbtjyNtGJCrLo6lHjDtvjid0w4R9Aysrww3ZAknkJt UPfmPYCDFoCskA9l7QfdSrLsdlQU5MYHTzQ9nFPi97B21mKsnzahwAA7Yopow8D2 oUHpQQvInNNArcnfl7TiqJqB2BwlgdhKhM4/sVwXJ2D3ZfoQhg6i9UsUHvmxNdqL srwVQCKJB8gWxKYk =QDVL -----END PGP SIGNATURE----- --=-=-=--