From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iBSbNmZ+cGArOgEAgWs5BA (envelope-from ) for ; Fri, 09 Apr 2021 18:18:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +AVyMGZ+cGBCeQAA1q6Kng (envelope-from ) for ; Fri, 09 Apr 2021 16:18:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5172812393 for ; Fri, 9 Apr 2021 18:18:46 +0200 (CEST) Received: from localhost ([::1]:58298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUtqG-0001tX-7o for larch@yhetil.org; Fri, 09 Apr 2021 12:18:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUtjm-0002YH-Sj for bug-guix@gnu.org; Fri, 09 Apr 2021 12:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39196) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUtjm-0001Hw-KO for bug-guix@gnu.org; Fri, 09 Apr 2021 12:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lUtjm-0006bI-EQ for bug-guix@gnu.org; Fri, 09 Apr 2021 12:12:02 -0400 Subject: bug#46362: got unexpected path `Backtrace:' from substituter Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Fri, 09 Apr 2021 16:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 46362 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 46362-done@debbugs.gnu.org Mail-Followup-To: 46362@debbugs.gnu.org, ludo@gnu.org, all_but_last@163.com Received: via spool by 46362-done@debbugs.gnu.org id=D46362.161798466325301 (code D ref 46362); Fri, 09 Apr 2021 16:12:02 +0000 Received: (at 46362-done) by debbugs.gnu.org; 9 Apr 2021 16:11:03 +0000 Received: from localhost ([127.0.0.1]:50741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUtik-0006Zf-27 for submit@debbugs.gnu.org; Fri, 09 Apr 2021 12:11:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUtif-0006ZL-Hu for 46362-done@debbugs.gnu.org; Fri, 09 Apr 2021 12:10:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52746) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUtia-0000gI-Bw for 46362-done@debbugs.gnu.org; Fri, 09 Apr 2021 12:10:48 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44876 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lUtia-0001jN-0W for 46362-done@debbugs.gnu.org; Fri, 09 Apr 2021 12:10:48 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <86a6sgcan1.fsf@163.com> <87eeh41rsb.fsf@gnu.org> <87h7kjogt9.fsf@gnu.org> Date: Fri, 09 Apr 2021 18:10:46 +0200 In-Reply-To: <87h7kjogt9.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 06 Apr 2021 12:20:18 +0200") Message-ID: <87im4v4ewp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617985126; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=XpTcEL0CIj+Rr1H7lRtJKDK0K+FnblF7kGiML6WeCMA=; b=PVr1TTdytBmYNyS/gI+3KDFRJsd9G04+JcuM1qkAdu9J7W7AGE61WLC2wHM2sCDJ9GpvXe zteEtraVw6MiLIjSNby9ibMzwQloB6Fh0cvWLMZyiNL2VuqRsTuT/nWnF1MCzD1STULN/5 VR8J0z4uG+tDo6QQtJ4fjE24VWQUa7EQroZX5LWAeEKFuNCIWhYkMyh/BuQU3gnxIeesuQ b4HDBNDBjzW2Z4yKk16dFw/0ETraLPJAHx0IkncAX2TCjh8BwRHsUinoX5ihdtOQvgtIJS tUFTS7tJvq+SExRX3nfZpchR6wbtEVLTTy/+JLJhMwW7w0DB+qDRZTAZakPCZw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617985126; a=rsa-sha256; cv=none; b=RpIBjMTm1s2UTfuGhApbrasHgOYONr+B76ort7VCi8gwTpA2VHreipMEUyNFiE4ltRMd7a xelNAilP+PGyDiQ57FnXaue6y9nrfvUiv6P6qcOeGYmiFrY1gqUZFGSDa6E+G7bmz0viqh aDsq9CwQR78eNQpr5w5FIHdAAPrklRsIOl3PsT2olKlRExhsh3yamhkDADmJjnioVKChvb wbSiGfuIhX1Lf4RWTF0BS1wBIZWhWcoVExfAmpq2z48ZF54zjNpAOZEk5mWU9h4BgoX5mR Q7A077381Ll2G8xS15Yj+SeVMj89//qG8jvqMl3zjaCsxdYXCxsO4mVPKUVEIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 5172812393 X-Spam-Score: -2.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: rC0gsfOSuwUL Ludovic Court=C3=A8s skribis: >>>From d85353dd4bfaa57a7d5803dade91d806a169295a Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Ludovic=3D20Court=3DC3=3DA8s?=3D > Date: Tue, 6 Apr 2021 12:10:29 +0200 > Subject: [PATCH] daemon: 'guix substitute' replies on FD 4. > > This avoids the situation where error messages would unintentionally go > to stderr and be wrongfully interpreted as a reply by the daemon. > > Fixes . > This is a followup to ee3226e9d54891c7e696912245e4904435be191c. > > * guix/scripts/substitute.scm (display-narinfo-data): Add 'port' > parameter and honor it. > (process-query): Likewise. > (process-substitution): Likewise. > (%error-to-file-descriptor-4?, with-redirected-error-port): Remove. > (%reply-file-descriptor): New variable. > (guix-substitute): Remove use of 'with-redirected-error-port'. Define > 'reply-port' and pass it to 'process-query' and 'process-substitution'. > * nix/libstore/build.cc (SubstitutionGoal::handleChildOutput): Swap > 'builderOut' and 'fromAgent'. > * nix/libstore/local-store.cc (LocalStore::getLineFromSubstituter): > Likewise. > * tests/substitute.scm : Set '%reply-file-descriptor' > rather than '%error-to-file-descriptor-4?'. > --- > guix/scripts/substitute.scm | 183 +++++++++++++++++------------------- > nix/libstore/build.cc | 4 +- > nix/libstore/local-store.cc | 12 +-- > tests/substitute.scm | 4 +- > 4 files changed, 95 insertions(+), 108 deletions(-) Pushed as 2d73086262e1fb33cd0f0f16f74a495fe06b38aa with the corresponding =E2=80=98guix=E2=80=99 package update in ec8d09ee672e0d357bb5bb597464c8b168f14bfb. Ludo=E2=80=99.