From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id IMybNrhzdGBveAAAgWs5BA (envelope-from ) for ; Mon, 12 Apr 2021 18:22:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KJiCMLhzdGBLVAAA1q6Kng (envelope-from ) for ; Mon, 12 Apr 2021 16:22:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 55B0126329 for ; Mon, 12 Apr 2021 18:22:16 +0200 (CEST) Received: from localhost ([::1]:50566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVzKJ-0006c5-0m for larch@yhetil.org; Mon, 12 Apr 2021 12:22:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVzK6-0006bp-P7 for bug-guix@gnu.org; Mon, 12 Apr 2021 12:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVzK6-0002tC-GS for bug-guix@gnu.org; Mon, 12 Apr 2021 12:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVzK6-0003cf-D8 for bug-guix@gnu.org; Mon, 12 Apr 2021 12:22:02 -0400 Subject: bug#41140: =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?system=E2=80=9D?= suggests wrong module import when using =?UTF-8?Q?=E2=80=9Cremove=E2=80=9D?= Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Mon, 12 Apr 2021 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41140 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Mail-Followup-To: 41140@debbugs.gnu.org, rekado@elephly.net, rekado@elephly.net Received: via spool by 41140-done@debbugs.gnu.org id=D41140.161824448813879 (code D ref 41140); Mon, 12 Apr 2021 16:22:02 +0000 Received: (at 41140-done) by debbugs.gnu.org; 12 Apr 2021 16:21:28 +0000 Received: from localhost ([127.0.0.1]:57852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVzJX-0003bn-U4 for submit@debbugs.gnu.org; Mon, 12 Apr 2021 12:21:28 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVzJW-0003bf-Hr for 41140-done@debbugs.gnu.org; Mon, 12 Apr 2021 12:21:26 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1618244475; cv=none; d=zohomail.com; s=zohoarc; b=NjxcyT4MHq3h5EbXqontEjiWwflEfyr19dTflcCTR0C/1irWU0bPqZtqsMcRu6sUiZSrDG8o26S8+KKHqKpmpDjke+VYoYKGJ/Qu2NeNm5NL8ssJrXUIT3XYnQMEXozQ8KC7IQVpQlvc83oGnX3D8FQd9pNXIa7sIP3AQlewQkk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1618244475; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=tbNzKKBWPJGWRjD4SojHJBHSNJ1UFFUBny8MLJYnB+s=; b=koOpN/hFXhlAxOfTF3iDbe/jt00w0r9abaF3x1YP3G4nmKKmVOj3gZlJFdMq/sQEzakxAQd2yR2AmVFAbskhP8lr2pxOrynt5Z0zpX+CFPhLOqNG/OdDyo7Afkhwhn+s2dIZOVXAkF2HQgP+7Vn6poRyWUUhsXzmf2eS1FP9WSQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1618244475; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=tbNzKKBWPJGWRjD4SojHJBHSNJ1UFFUBny8MLJYnB+s=; b=TrVDLLG6Rc/FGPiqfjQLGeUYjkiITBhcSkCRLv7Ql3Unya5F94Fd5B9xpfkxhxQJ O3KJ7WfiCKujuQ/E2fTfQnGhiQUd1nc5Zh+xWjEbkV9+htvLaSWcT/y+jQs5iWJFPJK XZVWSvsL31wgFpMIux6MKIr03gauBjj9TxdRL7Ac= Received: from localhost (p54ad4dc1.dip0.t-ipconnect.de [84.173.77.193]) by mx.zohomail.com with SMTPS id 1618244471887594.2259919441541; Mon, 12 Apr 2021 09:21:11 -0700 (PDT) References: <87lfm22il6.fsf@elephly.net> <877dxj327c.fsf@elephly.net> <87lflyfchf.fsf@gnu.org> User-agent: mu4e 1.4.15; emacs 27.2 From: Ricardo Wurmus In-reply-to: <87lflyfchf.fsf@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Mon, 12 Apr 2021 18:21:08 +0200 Message-ID: <87im4rv5hn.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41140-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618244536; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tbNzKKBWPJGWRjD4SojHJBHSNJ1UFFUBny8MLJYnB+s=; b=N39oupAgYJtFTyHliwU6b4FmrowYatPd+JbJK4SJeJXbiKGXZzAjs8yFGs+EBBl4xcn+9O mo1nATYjH+BAaDlltI1PtGcy/TN6GsSW35L99tGsYdjCxFJegDUElTWehNQFK1u/HUrAJ8 aVNk/0f5vkevNn9GJnDFJUvS3u+YHTVKEBg9yezVsR7x0D4VzK6DDSGsj8ZtUq1k7k0929 JWRsdqmHbUEmy6SHKMugTDXh4rjrYKFsvjGqrAW9IvZBe7MfkDYrcrdaNhC0NS+gLs+TUT JTvSyFnpMEkS2C2a9cn9UWYWakfF0YT1BmDNA04o54KdF8q4uBz0MnvdzqoolQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1618244536; a=rsa-sha256; cv=fail; b=cg9cWCFlW+AWb92u8BM/3Oq3z6lyVmQAWU8oUokQSXb1M2IsW3uaNyfpuVAnwJr2sWaGwM dxaa+HREgN8Zc3UOeWMzA20f+WnqOeiAvK5xZjp63WrSlnLoxwUOswitzJNup0y+G5YiTY p5TvDW8YL+mGZnP4CUcVyR7xC6vPyQU9+i2rm/aJTli1tuSQ+G/9vkvhzL+OgRg0P5TyHx KoGApWYtwsf1iKaNxjqEK81WkKooNBPaYyktq7EgtSHI5q0kxVmk6UWaJi6nAo+jxpdhfI efhBUJ5qk7u5pnxLQ3lmta8nuuHn91crb0pgMC7dMPxQ6WN30cERn1/XU28fCw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=TrVDLLG6; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: 0.56 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=TrVDLLG6; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 55B0126329 X-Spam-Score: 0.56 X-Migadu-Scanner: scn0.migadu.com X-TUID: Rz7egs3HV3oP Ludovic Court=C3=A8s writes: > Hi, > > Ricardo Wurmus skribis: > >>>>From 40c1208cbe9cbfa58ee385ef6ee06b775d309753 Mon Sep 17 00:00:00 2001 >> From: Ricardo Wurmus >> Date: Sun, 10 May 2020 23:29:38 +0200 >> Subject: [PATCH] services: Support DELETE in MODIFY-SERVICES macro. >> >> * gnu/services.scm (%modify-service): Add clause for DELETE syntax. >> (modify-services): Use FILTER-MAP; adjust docstring. >> * doc/guix.texi (System Services): Mention alternative syntax. >> (X Window): Use MODIFY-SERVICES syntax. > > I like it! > >> - #:use-module (srfi srfi-1) >> + #:use-module ((srfi srfi-1) #:hide (delete)) >> #:use-module (srfi srfi-9) >> #:use-module (srfi srfi-9 gnu) >> #:use-module (srfi srfi-26) >> @@ -272,7 +273,11 @@ singleton service type NAME, of which the returned = service is an instance." >> (service type value))) >>=20=20 >> (define-syntax %modify-service >> - (syntax-rules (=3D>) >> + (syntax-rules (=3D> delete) >> + ((_ svc (delete kind) clauses ...) >> + (if (eq? (service-kind svc) kind) >> + #f >> + (%modify-service svc clauses ...))) > > Best practice suggests that =E2=80=98delete=E2=80=99 should be bound (inf= o "(guile) > Syntax Rules"): > > --8<---------------cut here---------------start------------->8--- > Although literals can be unbound, usually they are bound to allow > them to be imported, exported, and renamed. *Note Modules::, for more > information on imports and exports. In Guile there are a few standard > auxiliary syntax definitions, as specified by R6RS and R7RS: > --8<---------------cut here---------------end--------------->8--- > > Now, if we export a new =E2=80=98delete=E2=80=99 binding from here, it=E2= =80=99ll annoy > everyone. So perhaps we can keep the srfi-1 =E2=80=98delete=E2=80=99 and= re-export it, > as done in (guix build utils)=E2=80=A6 though that situation is also anno= ying > because we get warnings saying that it collides with core =E2=80=98delete= =E2=80=99. > > Dunno, give it a try! I finally did give it a try. I=E2=80=99m re-exporting =E2=80=9Cdelete=E2= =80=9D and I don=E2=80=99t get any warnings. I pushed this with commit a247f5c7537df7e0c09051ba22d5c95eb08f48b9. Thank you for the review and your comments! --=20 Ricardo