From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UNbULOMtQmGEJQEAgWs5BA (envelope-from ) for ; Wed, 15 Sep 2021 19:31:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GFx3KOMtQmGwBgAAbx9fmQ (envelope-from ) for ; Wed, 15 Sep 2021 17:31:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 11A44C1EF for ; Wed, 15 Sep 2021 19:31:15 +0200 (CEST) Received: from localhost ([::1]:56170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQYka-0002Zz-W8 for larch@yhetil.org; Wed, 15 Sep 2021 13:31:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQYkR-0002Zk-1Y for bug-guix@gnu.org; Wed, 15 Sep 2021 13:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQYkQ-0004FE-Lc for bug-guix@gnu.org; Wed, 15 Sep 2021 13:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQYkQ-0004qM-8I for bug-guix@gnu.org; Wed, 15 Sep 2021 13:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50605: go: Commit d36c73b8a8f breaks `go tool` Resent-From: Katherine Cox-Buday Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 15 Sep 2021 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50605 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 50605@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163172700318468 (code B ref -1); Wed, 15 Sep 2021 17:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Sep 2021 17:30:03 +0000 Received: from localhost ([127.0.0.1]:53160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQYjS-0004nX-JX for submit@debbugs.gnu.org; Wed, 15 Sep 2021 13:30:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:59556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQYjQ-0004my-0r for submit@debbugs.gnu.org; Wed, 15 Sep 2021 13:30:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQYjP-0002WI-QS for bug-guix@gnu.org; Wed, 15 Sep 2021 13:29:59 -0400 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]:44692) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQYjM-0003Dc-5H for bug-guix@gnu.org; Wed, 15 Sep 2021 13:29:59 -0400 Received: by mail-io1-xd32.google.com with SMTP id g9so4449668ioq.11 for ; Wed, 15 Sep 2021 10:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:user-agent:mime-version; bh=r/YgKDczPAyD6G0B3plkWtGZncXIDFqWhKsNSisNJNg=; b=acgZux/S/rkaWTw49MtNr/ZUMEDKzyN3j0VNhuuYhZ1D6/utNfehJJUICussuGMceY HHDR/Sf8Z/+yQcsYWEgjIp1oDDROa7qBVXbnFuNCndKu/6Keeua7DWSj8JRqj/2RwZBR q17cxDfqzKScCX2wjalZ3olmqXqxSwwQmQ3hRxnV7PWF0Ja69X3UmaO0xp+mLlAbPWmR fcuavYtBv6h1qRGEspsoEMnCe/fs/LUFGLODodNTQlfZx3r4+V+vHroLCFtBbTXhT+DF xTkeiR+zpCYxh7eo4/Qdg4RzTh3hbWOpQt6nVZNe+moAyxqrRCviIFq/Radkjbb2fPQl E+4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :mime-version; bh=r/YgKDczPAyD6G0B3plkWtGZncXIDFqWhKsNSisNJNg=; b=5iKqdiioa4lWO4yJsncIAyIIodBpHHO07vpBRWbOlvqYRPhR5OUhlCPwA5NrY584NK kgdwD0IvfsAgYpOrssvhljWkG3h/kqsRmAX9/2GXQXZjpuJ4Y5hAcp15STZJrRvG7VOA oL8GQnTHuJZf+v1C6/SX+Ygbj4ZUQo1AUyFJeF/ySut0F7CpesXYP4kttSVE1/zslaJp Sd/nbvhR15dSK86iwiF2Vj4bBfXH4z90Sn1XnpOOeoVDso63E3rfIIft3WRA+iNUC+4V OD1lunsOPT9qslqF+/A6GnOvKT+bRmctzFzpUUsyDqyjV18m0HJU1T8TcuOESpnQqmRY A9Kw== X-Gm-Message-State: AOAM533VT95CcICbKJT/RYbur4cfpuAzpot1d5d2CpmFJScSvfe+MpJI Q6axf7Zg6SnBXbupJJe46jU= X-Google-Smtp-Source: ABdhPJxYvczEaqBaDPbd8oWSjGPmPJJ35W1jw3FU1jpwgVst8kZRiZ9GzFcA0yxNOvOVF2gUJfW0gw== X-Received: by 2002:a5d:9da4:: with SMTP id ay36mr982321iob.153.1631726994826; Wed, 15 Sep 2021 10:29:54 -0700 (PDT) Received: from washu-v4 (172-221-246-205.res.spectrum.com. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id x21sm250872ioh.55.2021.09.15.10.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 10:29:54 -0700 (PDT) From: Katherine Cox-Buday Date: Wed, 15 Sep 2021 12:29:53 -0500 Message-ID: <87ilz13fxq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::d32; envelope-from=cox.katherine.e@gmail.com; helo=mail-io1-xd32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sarah Morgensen Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631727075; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=r/YgKDczPAyD6G0B3plkWtGZncXIDFqWhKsNSisNJNg=; b=ehEzqAZIqv3CYjDlNe3wfJ7hG+vz853eveLU/iLTuonG1Mohpnz2Xpajg3Hkkb8VkKWqrH 24qDSiDoApbogMyM4JYfRqQTFqsWNz7v0KQ1xAweiV9gkq81fbHoUBEJSCnyeh+DeeEuNz cycgegFqAqQCQjTQeNwEqrxDilkvIf6d/MsyM+VouNgDIYEETWaF9fw15mJahdszzaCn1F 7Yy/4lcQScG/HyimtXfLae7RJWRPViFPEshv3ddc/mk/kdTSe6fBibUf+UiahKJHG5NVMU SraDTxgHQelFF0vPGj1eniyo71trDXCA16lntbsBT77Xw7JWWEodkU5hc13MzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631727075; a=rsa-sha256; cv=none; b=g5f+pUUch/Hk52G9LFjzITX0evEy/kaPTWiKiIwIvrIWzuHgfL8Mqu2hMry1z5onec0dgY 7kK1ZIBBtEuAphZVB4Pq8rX985Sjx0DzIirKz/IIwtpkEEYOaV1v9xx0wUKQ0nm7A4eTDH j1JDci07Tk6rAU1f3PBvaKLO99wrXbsyUCCGTbjO/pq3EpcRFi0THT5H+78WV0nzDqioQP 4bHd/jCzBJEFBjF/Zzv8O7Hai913hXaDgCQF2yRnfTfLQ22NH2P2db/JZ9O804cFYcNMcf l+AnPGpdQq8BzEyKi8Tmj903IxTF8eGGDFsTLCuwf5JG5lsouCSK7OCf9B9FoA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="acgZux/S"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="acgZux/S"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 11A44C1EF X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: +v4ZD8C4emfh Aside from not being able to issue ~go tool~ commands, things like ~gopls~[1] are broken as well. By design, ~GOTOOLDIR~ cannot be set from the user's environment[2]. This commit moved the directory, but did not update the ~GOTOOLDIR~ path. #+begin_example $ env |grep GOTOOLDIR $ go env GOTOOLDIR /home/katco/.guix-profile/pkg/tool/linux_amd64 $ export GOTOOLDIR=/tmp $ env |grep GOTOOLDIR GOTOOLDIR=/tmp $ go env GOTOOLDIR /home/katco/.guix-profile/pkg/tool/linux_amd64 $ go env -w GOTOOLDIR=/tmp go env -w: GOTOOLDIR cannot be modified $ [ -e $(go env GOTOOLDIR) ] || echo Nope, not here. Nope, not here. $ [ -e /home/katco/.guix-profile/lib/go/pkg/tool ] && echo Here it is Here it is #+end_example I think these are the lines to blame: #+begin_example d36c73b8a8f (Sarah Morgensen 2021-09-02 763) (for-each d36c73b8a8f (Sarah Morgensen 2021-09-02 764) (lambda (file) d36c73b8a8f (Sarah Morgensen 2021-09-02 765) (copy-recursively file (string-append out "/lib/go/" file))) d36c73b8a8f (Sarah Morgensen 2021-09-02 766) '("lib" "VERSION" "pkg/include" "pkg/tool")) #+end_example [1] - https://pkg.go.dev/golang.org/x/tools/gopls [2] - https://github.com/golang/go/issues/10264#issuecomment-91394026 -- Katherine