From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SM8YKqUrkmIlFAAAbAwnHQ (envelope-from ) for ; Sat, 28 May 2022 16:03:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uKUUKaUrkmJldwAAG6o9tA (envelope-from ) for ; Sat, 28 May 2022 16:03:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0F3D315058 for ; Sat, 28 May 2022 16:03:17 +0200 (CEST) Received: from localhost ([::1]:36174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nux2C-0007SO-5i for larch@yhetil.org; Sat, 28 May 2022 10:03:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nux1y-0007Rw-Md for bug-guix@gnu.org; Sat, 28 May 2022 10:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nux1y-0008Ap-CT for bug-guix@gnu.org; Sat, 28 May 2022 10:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nux1y-0003OU-AI for bug-guix@gnu.org; Sat, 28 May 2022 10:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55441: [cuirass] hang in "In progress..."; runs out of pgsql connections Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 28 May 2022 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55441 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Christopher Baines Cc: 55441@debbugs.gnu.org Received: via spool by 55441-submit@debbugs.gnu.org id=B55441.165374656513020 (code B ref 55441); Sat, 28 May 2022 14:03:02 +0000 Received: (at 55441) by debbugs.gnu.org; 28 May 2022 14:02:45 +0000 Received: from localhost ([127.0.0.1]:38638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nux1g-0003Nw-N6 for submit@debbugs.gnu.org; Sat, 28 May 2022 10:02:45 -0400 Received: from jpoiret.xyz ([206.189.101.64]:37732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nux1c-0003Nl-4B for 55441@debbugs.gnu.org; Sat, 28 May 2022 10:02:43 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 80CE71851D2; Sat, 28 May 2022 14:02:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1653746555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O4PnMkEPSIB3dqyg3Ljq2OLeCxdRbVjjB1u+cqFaM/M=; b=JIrQe93dEJXiw1pBzDRRQfI5Y9gs8SNktOWEbV0yYLrcFZ7nFFvA0rLZIh7DDD6x140iXv oIL97+eMumKH/5aQlQKs9zIPxqCqWOdfWlMfEgpcbt6VOU9yoR05Rj86O/9qw9i4eDHaL3 whSqgqTl8wGJ+PVPSKu5lOguNCc7lIbxjfZFI0ATNMKVN6FAXn5EX2ESpvUY+s7Qg24MC4 lF1uWJ4OKeQDSKFVjJmA5+RdVFnW2angVGhP8VX/KS+tNz2J6KLoQBfjIuwT7VsUcZi2Dm xYy9as6yNtBzwPkLj7QkZYkR1vQB060NM549g2ycYnPpegZ/Iw2WxVwh42D8iw== In-Reply-To: <16f8aa929bcba3536da4701f9b1152f28ca4b893.camel@telenet.be> References: <87fslcaznn.fsf@gmail.com> <87mtfj174l.fsf@gnu.org> <878rr2kug6.fsf_-_@gmail.com> <87pmke6ig4.fsf@gnu.org> <87o7zxalhu.fsf@gnu.org> <87k0alahug.fsf@gnu.org> <87fsl9acuw.fsf@gnu.org> <878rr1jsd1.fsf@gmail.com> <87fsl87gb5.fsf@gnu.org> <874k1n5loz.fsf@gnu.org> <87r14ovyud.fsf@gnu.org> <87k0aaiqzu.fsf@gnu.org> <87bkvlh8u2.fsf@gnu.org> <875ylth3rq.fsf@gnu.org> <87h75dtcaa.fsf@cbaines.net> <871qwghbme.fsf@gnu.org> <87sfow10lc.fsf@jpoiret.xyz> <16f8aa929bcba3536da4701f9b1152f28ca4b893.camel@telenet.be> Date: Sat, 28 May 2022 16:02:33 +0200 Message-ID: <87ilpphi12.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Josselin Poiret From: Josselin Poiret via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653746597; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=O4PnMkEPSIB3dqyg3Ljq2OLeCxdRbVjjB1u+cqFaM/M=; b=BJnv0n0wDdYthFwS4hDPyRrQMo1jmsdO+0CajzQB4BlQmWlCpDgCF5QZV7sU2SeuHD6bJM 7FrGw+sJta69+FGj8x6ljlfs2sPhDbymKFsJgII5ucvj3EkMxKCxXYELUKu+FKMSQ8kICU F0jIX6ElkI+cgT81EtdWGVpK9Fv7iaU35BWpWA+GZK/w+v9ntE6RiDQnhZo/6OBhozMJ/i NmtmDAw9aK94no5BPLuG2n56IQ39Dni37SNe3eswe3HwOYW68yMKsI+5917lAxk44wBGG6 mJtXIFPRjgVVpcRt1B1eMlmK6CQSv3egAVr6cNRHVfjgyTKxblZjDk/YV3b1kQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653746597; a=rsa-sha256; cv=none; b=mC6Yh80i4EGYYTKTneVfWphEiob67R3LC5AXB/OYsyPcUeH22C2KdOyfIB7bvjUFNLTDNo dZsRmpMsIMFNpeAiygJ67wg1TYtsTl68vcpe+RCi4KSMltg5gI/yrmxmLs1SsFP4x1YKqM buqrBpqr1cp4T6HdfCN0vgP8zDoU3Kz1XMUH1ykf/4z9sNF2lAqng85drSw2/VJNXxbaDw PMdofpT61yBC6K8FcU8TSYbKl/eJQnbUN6WSMT8VT2VtX/3GMP9W4axtxTkU9gSFTZI4g/ gCKztAVZd6Z+7qsuMND7HZo5ttBy7lr9OmYVLTE6VKJpOrDLUTrSYFx+TNBGeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=JIrQe93d; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=JIrQe93d; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0F3D315058 X-Spam-Score: -3.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: ORhwD7BP3H5g Hello Maxime, Thanks for your review. I took your comments into account and actually wrote some more patches to clean up start_child of potential thread unsafe practices. Since these are not guix-specific, I sent the whole patchset to guile-devel instead [1]. Maxime Devos writes: > The process opening code looks fragile, so I think some tests are > required to avoid causing regressions later. How would you suggest we do that? Since these are mostly racing issues between threads, I don't know how we could reproduce these reliably in tests. [1] v4 PATCH at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52835 (20220528124634.17353-1-dev@jpoiret.xyz) Best, -- Josselin Poiret