From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qFIhL+3T+2LiRwEAbAwnHQ (envelope-from ) for ; Tue, 16 Aug 2022 19:29:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4EbcLu3T+2L/eAAAauVa8A (envelope-from ) for ; Tue, 16 Aug 2022 19:29:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4FF692FD76 for ; Tue, 16 Aug 2022 19:29:17 +0200 (CEST) Received: from localhost ([::1]:60648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oO0NQ-0001p1-EX for larch@yhetil.org; Tue, 16 Aug 2022 13:29:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oO0NC-0001o0-Lt for bug-guix@gnu.org; Tue, 16 Aug 2022 13:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oO0NC-0001S2-D1 for bug-guix@gnu.org; Tue, 16 Aug 2022 13:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oO0NC-0001t4-9G for bug-guix@gnu.org; Tue, 16 Aug 2022 13:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#57232: [installer] ENTER in guided partitioner destroys partition table Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 16 Aug 2022 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57232 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mathieu Othacehe Cc: 57232@debbugs.gnu.org Received: via spool by 57232-submit@debbugs.gnu.org id=B57232.16606708977198 (code B ref 57232); Tue, 16 Aug 2022 17:29:02 +0000 Received: (at 57232) by debbugs.gnu.org; 16 Aug 2022 17:28:17 +0000 Received: from localhost ([127.0.0.1]:48212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO0MS-0001s2-Hj for submit@debbugs.gnu.org; Tue, 16 Aug 2022 13:28:16 -0400 Received: from tobias.gr ([80.241.217.52]:55408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO0MQ-0001rs-72 for 57232@debbugs.gnu.org; Tue, 16 Aug 2022 13:28:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=/Be7jOdSJ7bla tK/qf/eS9vU7IV8pdhQCAipzrB9ndY=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=YQZRglLGGiOZdYZ47N0YxYtVLaiS3VRYyAxFfi Vxh/4lVI+yiTjqaZIEhSn2Q3YcX4gL9PdRXXuS2JlTXZE3IOnriv6X2UkvAvPqbRxxlRZi ++Pe7SMn1xl4qBSNcgzuWQMsa+3mGRn/nHCViUrV0RhgJ/oOYM/RWonZ2cbi9brGNutMSq 3PcpmOFz4MFUnGVXnICc6bjqRTFQtTMuBTUH730U5td7dP4MYN8K+8DTa/Mdx78zvraK7W s5C6x1DyNWUk4LdFly7NOUMo+AdkwMsPjnA5xB0XBhPqp0IdegPD3npFCsHPJHLytaYFtg o22NybdV+Hliz2hUAzxPoaAw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 996654dd (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Tue, 16 Aug 2022 17:28:10 +0000 (UTC) References: <87zgg5f6el.fsf@nckx> <87y1voefkw.fsf@gnu.org> Date: Tue, 16 Aug 2022 18:55:05 +0200 In-reply-to: <87y1voefkw.fsf@gnu.org> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87ilmsf68j.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Tobias Geerinckx-Rice From: Tobias Geerinckx-Rice via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660670957; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/Be7jOdSJ7blatK/qf/eS9vU7IV8pdhQCAipzrB9ndY=; b=cHRNRcV/JtwnmpO7z1D5SIK8v7MqgSb5ATyX6CzhnbUA0BKC0ha9bHAKtPkga32bm9Jx8p Hs938MT93sFUHegDFrZYTy7FjxTpGDydJCOkJFmzstrI2NXpU2FoX5tnihOjmipVYlXs5Q a/V+zrMgkv1k3zv7cam7a6DnvhzANrkCXxGpgmiRgkbhuwrr/F3mqHOpMSwwg9QH5+T39I YW3FoIvVqyKAkRf6nQfmbxOpn4xURHGpfb+X1l1BnL9wbAoXKiqW1a+cyT5MM7lY2GNjWX 3r862Q1qSF6TI9x15QKCHB9Syyu+E1uDczIDub1+miBp5TM1V3o/Xzebx9g94w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660670957; a=rsa-sha256; cv=none; b=HfLkYXV5zsUuX0P0Sc+Jr7nNJasr97ENpRc2thbo95XPpX0b8aQN6hYwf+M7xAagW20sHQ WVKFdzA2kK+q7gz0RCIsLHU8Wc9XAeXk6pQvT9MUq42nkXeoyfARPTZ8ca4pfiu1OtiDCl QLuGYAJYcHrqcpkMtB8VE/sjPtzHAcTuqiLyx9hgoDB/IYSq89q9GX8u7AB9PpUl+7kZMj evAzv0Otw4AC1n0yfvjXU2RFHt4Y1WPw2HdHz6rxvpdIMa2tcvsbxeuNXYlmF59OBOHPHI ceF5yWxlWHuOI/xm4nVUlujaDFVq7bB0/UtkASzu0BB7BOp3SLSHw9LS4ZTAhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=YQZRglLG; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=YQZRglLG; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4FF692FD76 X-Spam-Score: -5.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: JLh3Bqx0MF50 --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Mathieu! Mathieu Othacehe =E5=86=99=E9=81=93=EF=BC=9A >> What that does is immediately and without confirmation wipe the=20 >> on-disc >> partition table. And its back-up. > > Oops, glad you were able to recover, I was also bitten in the=20 > past. My mistake for insisting on a bare metal test without a throwaway=20 machine handy :-) > The attached patch adds an extra confirmation page before wiping > everything, WDYT? Code looks all right. I'll try it out. Thanks! The help text for users reads, in part: =E2=80=9CYou can change a disk's partition table by selecting it and=20 pressing ENTER.=E2=80=9D Er, I was=E2=80=A6 expecting that to mean it would pop up a pretty window=20 or something. Is this really a feature? Should it be? I have to be honest: I was extremely let down by the installer UX,=20 *because* I read a lot of the code and can see how much effort=20 went into it. I hate pointing out that the partitioner is at once=20 less useful and more dangerous than (system "fdisk"). :-/, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYvvTrA0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15yNEBALvR/5YUi1ioZJ/8Hh0tqXsjT9AQfzbe4U9cm3nB stJ3AQCzrPhdcH/eARHGaqD1XdLkDpYZfbMG1c5uwZHINEfUBg== =yelZ -----END PGP SIGNATURE----- --=-=-=--