From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SAw8H7T27mOhZwAAbAwnHQ (envelope-from ) for ; Fri, 17 Feb 2023 04:38:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aO5NH7T27mPkdAEAauVa8A (envelope-from ) for ; Fri, 17 Feb 2023 04:38:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5706A8CAB for ; Fri, 17 Feb 2023 04:38:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSrZT-0002KV-UX; Thu, 16 Feb 2023 22:38:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSrZS-0002JV-Gm for bug-guix@gnu.org; Thu, 16 Feb 2023 22:38:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSrZS-0005lL-1B for bug-guix@gnu.org; Thu, 16 Feb 2023 22:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSrZR-0001sb-KW for bug-guix@gnu.org; Thu, 16 Feb 2023 22:38:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH 05/10] gnu: Add icecat-l10n and icedove-l10n. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 17 Feb 2023 03:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Cc: 32026@debbugs.gnu.org, ludo@gnu.org, Jonathan Brielmaier Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.16766050627196 (code B ref 32026); Fri, 17 Feb 2023 03:38:01 +0000 Received: (at 32026) by debbugs.gnu.org; 17 Feb 2023 03:37:42 +0000 Received: from localhost ([127.0.0.1]:38164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSrZ8-0001rz-FI for submit@debbugs.gnu.org; Thu, 16 Feb 2023 22:37:42 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:36364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSrZ6-0001rk-DF for 32026@debbugs.gnu.org; Thu, 16 Feb 2023 22:37:41 -0500 Received: by mail-qt1-f179.google.com with SMTP id t16so1785880qto.3 for <32026@debbugs.gnu.org>; Thu, 16 Feb 2023 19:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=IT/YXrsrrGl9aqJNTrOHZEKtfHiTTBXeyQZ/k6FLCL4=; b=iVs+ATFN9r19Gv7hh8Gy9VHwp8DjZyJ0/U13qSVHkANKm6DGFawsqeScfTqqkP2T/J t9Sve+vIYMjcq3N8ml4rIpmsGMLcEm3LjfEiJCpgLPMVMf5iKlobAdrFQhX9dIvUHt84 kbUqM8jrT8X2uWxaZTIfbzdE+/S7uJmvi8iTg52DASwPHcFAtj1AD8xKCaFORw+H0PXQ XEEmWDMp0oJwKNkyyqCSo5YDkhR6iaRMJEtnk02mkdAcUa8p/YfpeX25LdSfd2MhtQaw RUjDE/o906ISHXLHjJWAzKw5bvL82MeufnigmzyBYOQKsxogLrQ96GASsCTdlhVAkzZn 3MDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IT/YXrsrrGl9aqJNTrOHZEKtfHiTTBXeyQZ/k6FLCL4=; b=g9YDY8YFhAe/yoP/takIFD373j0OPtxDStCq8FkLAAm8TXpWX30i5zc3lMnMgUyv+k d6r/7RRch6Nf7z+fMhVCQ1+rivtQyj5KRog6TkadL5gr07ApQoEoYxx/SopFCl+buoz6 D7Qn2A/Us28ce0MpSMUGAibKScD1P/SR5cRePkNBk/OvjXbnpHAknKzFDtY8nXAIJjs6 eK6f5MbEexA0cufnBxz2QRRCdVjjgOjxfkojzWpL9RJY+3Edti/OukoIf5WFvU772JuF mtUsOcuKwmAdT+n4XjwaD5ZDmv5MDBt9s4jAt7pTdNtO1zSu/YKSobJPzqOP3GTG2nZV f68Q== X-Gm-Message-State: AO0yUKVnLHMlzyxXTJ2sM3zg2PArq9/HzvHp9/yRQWvJ09El89DDJ1E7 Nj63FpH0u2J//U6EUj0fxAI= X-Google-Smtp-Source: AK7set9OCQ91fl25D3WYvQGWbo/07fwoX5PlH3++l1IrmiaH+nOn89dXnCzt5lU1/Z/lUcF2YXUuSA== X-Received: by 2002:ac8:5891:0:b0:3ba:1d8d:f6eb with SMTP id t17-20020ac85891000000b003ba1d8df6ebmr11703795qta.58.1676605054863; Thu, 16 Feb 2023 19:37:34 -0800 (PST) Received: from hurd (dsl-152-188.b2b2c.ca. [66.158.152.188]) by smtp.gmail.com with ESMTPSA id f5-20020a37d205000000b00729b7d71ac7sm2506534qkj.33.2023.02.16.19.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 19:37:34 -0800 (PST) From: Maxim Cournoyer References: <20230216043649.32119-1-maxim.cournoyer@gmail.com> <20230216043649.32119-5-maxim.cournoyer@gmail.com> <87cz69fcuf.fsf@netris.org> Date: Fri, 17 Feb 2023 04:37:20 +0100 In-Reply-To: <87cz69fcuf.fsf@netris.org> (Mark H. Weaver's message of "Thu, 16 Feb 2023 17:45:49 -0500") Message-ID: <87ilg1t11r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676605108; a=rsa-sha256; cv=none; b=nvgXO2wLbrtbeE67p7cjWBlovne0OFj7SOW+IawU4W3KCalpeURjnAfL4EbPBZm0c65n+W qsZypYN7pLie3nGBmJMdL2JmOioGPIGbKv5OPFsZqTwRTi62fiWySHeQ14AxeyjAMZgzRS RXYFgVCLyWSv+RpQws1y69aiSQnBAo6dI8+Wdd62lhHPBOwkkAj2K92r09Ta514b6oLi4p v8pyGHjJ6M8E1/lD5frVDWxtqV3oY2+HCYUoxYNwxZydUJlopu0qMxY748ez7alWwKm9ms 9xY6+7T33Mcpz9kkyx2Z9WRliqAn1WUERUKbjT7zIaxMds38lkoITpMkzxjlyg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iVs+ATFN; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676605108; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IT/YXrsrrGl9aqJNTrOHZEKtfHiTTBXeyQZ/k6FLCL4=; b=sWEEjq7qSIa2tHFOJcuEJxwP/GX7/y1crH5ZFfUyjwgmFzrH6Wp8zoRYzIoAwjWdvfWAiZ Lcr67ve88lU/7UkOXkXOav7Lkw2wTt3xEoB55Ff9v9uKjkuXzM0cSgpWEebHM2AY6nStpZ KoH7GXcViogXWVMKU32ek8Cy/dnSo4UHHcdKufNciIzYc97zWDSg+O+5YMW9PF5I3qBxHr 8+gSt3it/viAgyavaVM/PiC4q8st1VeslfBFN8N9ocQdMmPO38q3bQ8/s9a457m62BeakF DZLHryl5hLYRWlhj4YTSUBKgU1Cv7zbJaS80Zzqg/AmlNJ+aJOZ5nU0dY9WqXg== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Queue-Id: 5706A8CAB X-Migadu-Spam-Score: -2.03 X-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iVs+ATFN; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: Tv8JIR7auSG8 Hi Mark! Mark H Weaver writes: > Hi Maxim, > > Maxim Cournoyer writes: >> * gnu/packages/gnuzilla.scm (%icecat-locales, %icedove-locales): New variable. >> (make-l10n-package): New procedure. >> (icecat-l10n, icedove-l10n): New variables. > > Thanks very much for this important work. Our lack of support for > language packs has been sore spot for several years, and I'm profoundly > grateful to you for taking this on and getting it done! > > For now, I have just two general questions/comments: Thanks! The motivator was a family member starting to use Guix System... ha! > (1) Instead of generating the locales in separate "*-locales" packages > and then merging them with the main package (which must then be > renamed to "*-minimal"), how feasible would it be to incorporate the > locale generation directly into the existing packages? It's entirely feasible, but I see a couple downsides that explain why I stuck with the current design: 1. The user no longer has an option to install IceCat without the 70 MiB or so of extra locales (via icecat-minimal). 2. The already lengthy IceCat package definition gets even more verbose and hard to follow. 3. The locales are slow to generate (it's sequential, and there are a lot of them). Currently they can be generate at the same time as icecat-minimal is built. 4. It makes debugging locale-generation problems more focused. > (2) In terms of the API, I very much dislike the approach of having the > 'make-l10n-package' accept just one argument: a symbol, which it > uses to construct the variable names of toplevel variables that must > be looked up using 'module-ref'. I'd greatly prefer to simply pass > in all of the variables that are needed. > > What do you think? I don't feel strongly about it. Since you do, I've adjusted it, in an upcoming v3. > I'll hold off on a more detailed review until we can (hopefully) reach > agreement on the overall approach. OK! Thanks for the comments. I hope I don't sound dismissive of them, although I find myself disagreeing with a few of them :-). -- Thanks, Maxim