From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mBkICm+ErGQ40gAASxT56A (envelope-from ) for ; Tue, 11 Jul 2023 00:21:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EEPvCG+ErGRPAQEAG6o9tA (envelope-from ) for ; Tue, 11 Jul 2023 00:21:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C668C4A9D6 for ; Tue, 11 Jul 2023 00:21:34 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=DagLdGw3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689027694; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VS/LWW+ZgzDGRW99vm2p+VdC9vXja/bJor+XOB3DY0Y=; b=VrGH/dULi9OFbBwYg3VrVIk+J75jqIjVtXr+8CxOpEo9SxZ7Aa9geYg3TFqmOzHNP9raCQ Zhpaq66P7OysX8Pk99qB1pspoeQqkkzX/n4uhukPMDQoGWl3lPkHK0lAC3+WM7l0fFyb+2 RXVw1eP7hUxOb6bAs9NzvNb9IaDzoWJhszQzX+OOt/lVQJgUfUfvfpB18GC6/VBo/TFCTr oLoxNKTX0PrEFRXdo7TfTn6Bc3ANCAh/N9nTA8n7JHkO0rcZPAaxbfg+vbkmMMdXVWuyul qNnZG3VYSKoSrijtC0hJAI5vrf2c9JYP0/fQrAh8OUAPqXMuAya3IqEaHQSe7g== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1689027694; a=rsa-sha256; cv=fail; b=RLajNYD7uVvXAubIChvSNh7wcJhd2umiLXBYNXy0yFbcxa6JQ7J7bqfHzA8n+gSrJ+VImz FlB0ylnt2g2VFrBWxnlVCrHa8g+OOe/F2k7i4VRY2rQOhbsYGB2lzhUrSEm+wAqgX4dBNX lbKTLCKbYORq/FNnMlOrnztZaHvvmJty+4mFDoiZerK5QCQSU6azwr7CTx1h6wA8RObpKy /7Qh2unSIJBuXksoEpgZUeh7NnBi8pESKgmsG3+/N40Xo1dBhMqV73NmfVMYhs2U1UTE6a du8oNzOEPniXYq5Du6A68QEwkIrGzULxMVi7iOAvUpi6TzgR/Ve6FVhBN2Uarw== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=DagLdGw3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}") Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIzFj-0002zI-3F; Mon, 10 Jul 2023 18:21:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIzFh-0002xC-Jl for bug-guix@gnu.org; Mon, 10 Jul 2023 18:21:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIzFe-0000t3-MV for bug-guix@gnu.org; Mon, 10 Jul 2023 18:21:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qIzFe-00006L-3c for bug-guix@gnu.org; Mon, 10 Jul 2023 18:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#64358: [PATCH] refresh: Sort update specs by package location. Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 10 Jul 2023 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64358 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 64358@debbugs.gnu.org Received: via spool by 64358-submit@debbugs.gnu.org id=B64358.1689027624320 (code B ref 64358); Mon, 10 Jul 2023 22:21:02 +0000 Received: (at 64358) by debbugs.gnu.org; 10 Jul 2023 22:20:24 +0000 Received: from localhost ([127.0.0.1]:49330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIzF2-000055-DH for submit@debbugs.gnu.org; Mon, 10 Jul 2023 18:20:24 -0400 Received: from sender3-of-o57.zoho.com ([136.143.184.57]:21775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIzEz-00004s-M4 for 64358@debbugs.gnu.org; Mon, 10 Jul 2023 18:20:22 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1689027612; cv=none; d=zohomail.com; s=zohoarc; b=Z0UomCvSXRvhNgm0M1qKK1i8p8v/lTL1wm2sbUzpQ8briMnPpUSy2DxEo8gqXwsipa5w0gRjRK0iYrY2XkcblYgn98bo2dJOh8GgOPitKxKXVDR1MpnAs9gXmDEU80RbwqE4bArpI1Hn8VSMmRPa0aGNMmvrjWePtmjFk1NR3FU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689027612; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=VS/LWW+ZgzDGRW99vm2p+VdC9vXja/bJor+XOB3DY0Y=; b=ay7Vr6vw0bvDAsoLYO/2MsAYR2piw/WNGjITOSW7gXuyXiWW+n0xXUhSmOdXMt30ztafif/03XxSX6iAaTVvgZqrK626pHh3fydaGzAkZZgrT/okajoQMVygA3SRiD+tlUJTb4LTFdrybvAtyvtI4zmQRJq+8PZep9CKyGAiI70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1689027612; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=VS/LWW+ZgzDGRW99vm2p+VdC9vXja/bJor+XOB3DY0Y=; b=DagLdGw3ajVAyWc+sOH12YMUJsoPLWrqoI56YNQ72xZw+DlrsNk5FB6tJd+uUyeV o3uXgtm3j3EL8Oq45aXIjHJIxmLUBzmWWyu3jZuDdneMKnBNIPRmDhX62zt2RRXEq7g +9p8sPCRweaoONC3NP/csPCbmbvSjxS6zyVOJ7Cg= Received: from localhost (92-108-142-46.pool.kielnet.net [46.142.108.92]) by mx.zohomail.com with SMTPS id 1689027610504535.7495296636165; Mon, 10 Jul 2023 15:20:10 -0700 (PDT) References: <87bkgyklbv.fsf@elephly.net> <74997f913e60491d74afcea38a13e5edb0c71b09.1689014499.git.rekado@elephly.net> <87v8er5tdo.fsf@gnu.org> User-agent: mu4e 1.10.3; emacs 28.2 From: Ricardo Wurmus Date: Tue, 11 Jul 2023 00:17:43 +0200 In-reply-to: <87v8er5tdo.fsf@gnu.org> Message-ID: <87ilarjtnt.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx0.migadu.com X-Migadu-Queue-Id: C668C4A9D6 X-Migadu-Spam-Score: 0.21 X-Spam-Score: 0.21 X-TUID: G6hFAxi94Vbf Ludovic Court=C3=A8s writes: > Ricardo Wurmus skribis: > >> Fixes . >> >> * guix/scripts/refresh.scm (guix-refresh): Sort update specs by location= from >> bottom to top before updating packages. > > [=E2=80=A6] > >> + (let* ((get-line >> + (compose location-line >> + package-location >> + update-spec-package)) > > Maybe s/get-line/spec-line/ ? Okay, will change it. I found that it=E2=80=99s probably not a good idea to sort by location-line without also taking into account the file name. My latest version uses =E2=80=9Clocation->string=E2=80=9D and =E2=80=9Cstring>=E2=80=9D instead of= =E2=80=9Clocation-line=E2=80=9D and =E2=80=9C>=E2=80=9D, ensuring that changes to the same file remain grouped. I=E2=80=99ll push this together with the bulk update of CRAN packages that = I=E2=80=99m working on. Thanks for the review! --=20 Ricardo