unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark H Weaver <mhw@netris.org>
To: 18068@debbugs.gnu.org
Subject: bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash
Date: Mon, 21 Jul 2014 00:37:06 -0400	[thread overview]
Message-ID: <87ha2b72fh.fsf@yeeloong.lan> (raw)

'module-init-tools' (with our patch) assumes that LINUX_MODULE_DIRECTORY
ends with a trailing slash.  However, 'udev-service' sets
LINUX_MODULE_DIRECTORY to "/run/booted-system/kernel/lib/modules".

One option would be to add a trailing slash:

--8<---------------cut here---------------start------------->8---
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -488,7 +488,7 @@ passed to @command{guix-daemon}."
 
                         ;; Allow udev to find the modules.
                         (setenv "LINUX_MODULE_DIRECTORY"
-                                "/run/booted-system/kernel/lib/modules")
+                                "/run/booted-system/kernel/lib/modules/")
 
                         (let ((pid (primitive-fork)))
                           (case pid
--8<---------------cut here---------------end--------------->8---

Another option would be to change module-init-tools-moduledir.patch to
cope with the lack of a trailing slash.

Thoughts?

    Thanks,
      Mark

             reply	other threads:[~2014-07-21  4:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21  4:37 Mark H Weaver [this message]
2014-07-21 16:12 ` bug#18068: LINUX_MODULE_DIRECTORY needs trailing slash Ludovic Courtès
2014-07-23  2:22   ` Mark H Weaver
2014-07-23 17:10     ` Ludovic Courtès
2014-07-23 19:53       ` Mark H Weaver
2014-07-23 20:28         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ha2b72fh.fsf@yeeloong.lan \
    --to=mhw@netris.org \
    --cc=18068@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).