From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#27007: [PATCH v2 2/2] doc: Adapt to multiple bootloader support. Date: Thu, 08 Jun 2017 14:39:01 +0200 Message-ID: <87h8zqwt5m.fsf@gnu.org> References: <20170608105738.14445-1-m.othacehe@gmail.com> <20170608105738.14445-2-m.othacehe@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIwjN-0003NW-6c for bug-guix@gnu.org; Thu, 08 Jun 2017 08:40:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIwjK-0002kU-2e for bug-guix@gnu.org; Thu, 08 Jun 2017 08:40:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dIwjK-0002kQ-0O for bug-guix@gnu.org; Thu, 08 Jun 2017 08:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dIwjJ-00057H-RI for bug-guix@gnu.org; Thu, 08 Jun 2017 08:40:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20170608105738.14445-2-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Thu, 8 Jun 2017 12:57:38 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Mathieu Othacehe Cc: 27007@debbugs.gnu.org Mathieu Othacehe skribis: > * doc/guix.texi (GRUB configuration): Rename to "Bootloader > configuration". > Remove device-mount-point field from menu-entry description. > Adapt occurences of "GRUB" in other sections. LGTM. In the future, I think it=E2=80=99ll be preferable to commit code/tests/doc together. That is, in the commit that changes the API from being GRUB-specific to supporting multiple bootloaders, we include not only the code but also the doc update. This simplifies review, makes sure each commit is self-contained, and ensure that users get consistent documentation. Thanks again! Ludo=E2=80=99.