From: Mark H Weaver <mhw@netris.org>
To: 30024@debbugs.gnu.org
Subject: bug#30024: [PATCH] core-updates: librsvg: Disable more failing tests
Date: Mon, 08 Jan 2018 02:08:06 -0500 [thread overview]
Message-ID: <87h8rwbzft.fsf@netris.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On the core-updates branch, in librsvg, some tests fail on i686 and
armhf. I've attached a proposed patch, but I haven't yet been able to
test it because I no longer use binary substitutes on my systems and I'm
currently having some difficulties[*] building the base packages.
If someone else would like to test this and push it to core-updates, I'd
be grateful. It would be sufficient to test on i686, I think.
Mark
[*] GNU tar's handling of sparse files is broken on btrfs filesystems
and thus fails its test suite on my system, and the test suite of
guile-2.2.3 hung up (no output or CPU usage for 30 minutes with a
defunct guile process) on my x86_64 GuixSD system.
[-- Attachment #2: [PATCH] UNTESTED: gnu: librsvg: Disable more failing tests --]
[-- Type: text/x-patch, Size: 2533 bytes --]
From e414375109364f29618ec8e71074e71f514d1765 Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Sun, 7 Jan 2018 21:35:35 -0500
Subject: [PATCH] UNTESTED: gnu: librsvg: Disable more failing tests.
* gnu/packages/gnome.scm (librsvg)[arguments]: Rename
'remove-failing-test' phase to 'remove-failing-tests'. Disable more
tests that fail on i686 and armhf.
---
gnu/packages/gnome.scm | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6d907fdf9..e5345b111 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -9,7 +9,7 @@
;;; Copyright © 2015, 2017 Andy Wingo <wingo@igalia.com>
;;; Copyright © 2015 David Hashe <david.hashe@dhashe.com>
;;; Copyright © 2015, 2016, 2017 Ricardo Wurmus <rekado@elephly.net>
-;;; Copyright © 2015, 2016, 2017 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2015, 2016, 2017, 2018 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2015 David Thompson <davet@gnu.org>
;;; Copyright © 2015, 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2016, 2017 Rene Saavedra <rennes@openmailbox.org>
@@ -1207,11 +1207,19 @@ dealing with different structured file formats.")
(("gdk_pixbuf_cache_file = .*$")
"gdk_pixbuf_cache_file = $(TMPDIR)/loaders.cache\n"))
#t))
- (add-after 'unpack 'remove-failing-test
- ;; This test fails on aarch64.
+ (add-after 'unpack 'remove-failing-tests
(lambda _
- (delete-file "tests/fixtures/reftests/bugs/777834-empty-text-children.svg")
- (delete-file "tests/fixtures/reftests/bugs/777834-empty-text-children-ref.png")
+ (with-directory-excursion "tests/fixtures/reftests"
+ (for-each delete-file
+ '(;; This test fails on i686:
+ "svg1.1/masking-path-04-b.svg"
+ "svg1.1/masking-path-04-b-ref.png"
+ ;; This test fails on armhf:
+ "svg1.1/masking-mask-01-b.svg"
+ "svg1.1/masking-mask-01-b-ref.png"
+ ;; This test fails on aarch64:
+ "bugs/777834-empty-text-children.svg"
+ "bugs/777834-empty-text-children-ref.png")))
#t)))))
(native-inputs
`(("pkg-config" ,pkg-config)
--
2.15.1
next reply other threads:[~2018-01-08 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 7:08 Mark H Weaver [this message]
2018-01-08 14:13 ` bug#30024: [PATCH] core-updates: librsvg: Disable more failing tests Ludovic Courtès
2018-01-08 16:50 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8rwbzft.fsf@netris.org \
--to=mhw@netris.org \
--cc=30024@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).