From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#33078: Attempt to build my GuixSD system now fails
Date: Wed, 07 Nov 2018 22:41:37 +0100
Message-ID: <87h8gssgz2.fsf@gnu.org>
References: <87d0s8nyvi.fsf@netris.org> <87woqgfgb8.fsf@fastmail.com>
	<87tvlkfdl1.fsf@fastmail.com> <87y3auf33w.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKVbQ-0003yM-Qt
	for bug-guix@gnu.org; Wed, 07 Nov 2018 16:43:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKVbN-0003Ii-Fi
	for bug-guix@gnu.org; Wed, 07 Nov 2018 16:43:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35751)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gKVbK-0003GE-0L
	for bug-guix@gnu.org; Wed, 07 Nov 2018 16:43:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gKVbJ-00059F-QN
	for bug-guix@gnu.org; Wed, 07 Nov 2018 16:43:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.33078.B33078.154162692619713@debbugs.gnu.org>
In-Reply-To: <87y3auf33w.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Fri, 19 Oct 2018 16:00:35 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 33078@debbugs.gnu.org

Hey Marius,

Ping!  :-)

Ludo=E2=80=99.

ludo@gnu.org (Ludovic Court=C3=A8s) skribis:

> Hello,
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> Mark H Weaver <mhw@netris.org> writes:
>>>
>>>>   (services (cons* (console-keymap-service keymap)
>>>>                    ;;(xfce-desktop-service)
>>>>                    (gnome-desktop-service)
>>>>                    (service network-manager-service-type
>>>>                             (network-manager-configuration))
>>>>                    (service wpa-supplicant-service-type wpa-supplicant)
>>>
>>> To adapt to the new interface, this should be changed to:
>>>
>>> (service wpa-supplicant-service-type)
>>>
>>> ...though it would be good to have backwards compatibility here.  WDYT
>>> of this approach?
>>
>> [...]
>>=20=20=20
>>>  (define wpa-supplicant-service-type
>>> -  (let ((config->package
>>> -         (match-lambda
>>> -           (($ <wpa-supplicant-configuration> wpa-supplicant)
>>> -            (list wpa-supplicant)))))
>>> -    (service-type (name 'wpa-supplicant)
>>> -                  (extensions
>>> -                   (list (service-extension shepherd-root-service-type
>>> -                                            wpa-supplicant-shepherd-se=
rvice)
>>> -                         (service-extension dbus-root-service-type con=
fig->package)
>>> -                         (service-extension profile-service-type confi=
g->package)))
>>> -                  (description "Run the WPA Supplicant daemon, a servi=
ce that
>>> +  (lambda* (#:optional wpa-supplicant-package)      ;deprecated
>>> +    (let ((package
>>> +           (if wpa-supplicant-package
>>> +               wpa-supplicant-package
>>> +               (match-lambda
>>> +                 (($ <wpa-supplicant-configuration> wpa-supplicant)
>>> +                  (list wpa-supplicant))))))
>>
>> Derp, this obviously won't work.
>>
>> I've tried various incarnations to match a package object in the
>> match-lambda with little success.  Suggestions?
>
> =E2=80=98wpa-supplicant-service-type=E2=80=99 must remain a <service-type=
> record, so
> the above cannot work.
>
> Maybe this?
>
> diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
> index 61a0e975c..391c6ec59 100644
> --- a/gnu/services/networking.scm
> +++ b/gnu/services/networking.scm
> @@ -1077,7 +1077,9 @@ networking."))))
>    (let ((config->package
>           (match-lambda
>             (($ <wpa-supplicant-configuration> wpa-supplicant)
> -            (list wpa-supplicant)))))
> +            (list wpa-supplicant))
> +           ((? package? package)
> +            (list package)))))
>      (service-type (name 'wpa-supplicant)
>                    (extensions
>                     (list (service-extension shepherd-root-service-type
>
>
> HTH,
> Ludo=E2=80=99.