From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Othacehe Subject: bug#35783: Guile-Parted crashes the installer on i686-linux Date: Sat, 18 May 2019 11:30:21 +0200 Message-ID: <87h89shzyq.fsf@gmail.com> References: <87h89syidd.fsf@gnu.org> <877eaoydw8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:44474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRvrA-0001aI-Ni for bug-guix@gnu.org; Sat, 18 May 2019 05:42:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRvgE-0001z6-Lv for bug-guix@gnu.org; Sat, 18 May 2019 05:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hRvgE-0001yo-I4 for bug-guix@gnu.org; Sat, 18 May 2019 05:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hRvgE-0004PB-D1 for bug-guix@gnu.org; Sat, 18 May 2019 05:31:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <877eaoydw8.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35783@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey Ludo, > Reverting 7d567af46b4e10ffafb1d0f76b524f5781460598 fixes the problem, so > I guess this has to do with the fact that the previous partition objects > (those listed in =E2=80=98initial-partitions=E2=80=99) are invalidated or= something. Yes I think that's what happened, even though I don't get why it didn't cause an issue on x64. > > Now we need another way to address > . I have a first draft, I'm about to test right now :) Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-draft-Fix-esp-user-partition-creation.patch >From 3c6018a448f38e263aeb5a23fbc88d226a048d67 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sat, 18 May 2019 11:25:09 +0200 Subject: [PATCH] draft: Fix esp user-partition creation. --- gnu/installer/newt/partition.scm | 5 +---- gnu/installer/parted.scm | 12 ++++++++---- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm index f8e318fa0d..cd9d46316a 100644 --- a/gnu/installer/newt/partition.scm +++ b/gnu/installer/newt/partition.scm @@ -752,10 +752,7 @@ by pressing the Exit button.~%~%"))) (disk-commit disk) disk))) (scheme (symbol-append method '- (run-scheme-page))) - (user-partitions (append - (auto-partition! disk #:scheme scheme) - (create-special-user-partitions - (disk-partitions disk))))) + (user-partitions (auto-partition! disk #:scheme scheme))) (run-disk-page (list disk) user-partitions #:guided? #t))) ((eq? method 'manual) diff --git a/gnu/installer/parted.scm b/gnu/installer/parted.scm index 4ccc0b1f51..ac9098cbde 100644 --- a/gnu/installer/parted.scm +++ b/gnu/installer/parted.scm @@ -1001,10 +1001,14 @@ swap partition, a root partition and a home partition." (mount-point "/home"))))))) (new-partitions* (force-user-partitions-formatting new-partitions))) - (create-adjacent-partitions! disk - new-partitions* - #:last-partition-end - (or end-esp-partition 0))))) + (append + (if esp-partition + (partition->user-partition esp-partition) + '()) + (create-adjacent-partitions! disk + new-partitions* + #:last-partition-end + (or end-esp-partition 0)))))) ;; -- 2.17.1 --=-=-=--