From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice via Bug reports for GNU Guix Subject: bug#36896: [PATCH] added gsettings-desktop-schema to progragated inputs Date: Mon, 16 Sep 2019 12:26:46 +0200 Message-ID: <87h85c1qqh.fsf@nckx> References: <18ecfb89-c1e7-3985-06d1-24a9abe0ecb7@riseup.net> <20190802022815.13670-1-mjbecze@riseup.net> <87sgqfzvpi.fsf@elephly.net> <87wofr2w3q.fsf@nckx> <8eb7ad0b0ffd12f2fa7dfe11ff9e5444@riseup.net> <8f037ead0d55cc4f7c357a77ea6e6983@riseup.net> <89bb192a6e60ad7d45d3471270c86e4c@riseup.net> <871rwxgym0.fsf@elephly.net> <0b7c863c0f42f84c59b2fe97b0c425f5@riseup.net> <87mufktfvm.fsf@nckx> <8e0af69e-fad9-733b-a710-dab620922e65@riseup.net> <87o8zxwwby.fsf@nckx> <35bfc691-74cf-dc3f-c704-15106bf45279@riseup.net> Reply-To: Tobias Geerinckx-Rice Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:47920) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9oDn-0003uK-TR for bug-guix@gnu.org; Mon, 16 Sep 2019 06:27:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9oDm-0006cJ-HW for bug-guix@gnu.org; Mon, 16 Sep 2019 06:27:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9oDm-0006bw-3X for bug-guix@gnu.org; Mon, 16 Sep 2019 06:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i9oDl-00014K-TQ for bug-guix@gnu.org; Mon, 16 Sep 2019 06:27:01 -0400 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-reply-to: <35bfc691-74cf-dc3f-c704-15106bf45279@riseup.net> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Martin Becze Cc: 36896-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Martin, Martin Becze =E5=86=99=E9=81=93=EF=BC=9A > ping :P Absolutely. The diff you sent here[0] is incomplete (it relies on your=20 previous patch and doesn't have a header); please always send=20 git-formatted patches that apply directly to current master. They=20 are easier to merge and will be merged sooner. > Yeah I don't know. I just used prefix in the latest patch. Let=20 > me know > if the other method is preferred. =C2=AF\_(=E3=83=84)_/=C2=AF I've pushed this to master as=20 ad6e168b3f29576d92b00725dedbb38cd5f05e46 with the following=20 changes: =2D Moved widowed =E2=80=98#:phases=E2=80=99 to the previous line (in well-= formatted=20 Scheme, =E2=80=98(=E2=80=99 can never end a line and =E2=80=98)=E2=80=99 = should never start=20 one), same for 'phase 'names =2D then decided to move =E2=80=99#:phases=E2=80=99 below =E2=80=98#:config= ure-flags=E2=80=99. This=20 is subjective, but since *flags =E2=80=98affect=E2=80=99 phases (never th= e other=20 way 'round) it felt right :-) =2D dropped the unused =E2=80=98inputs=E2=80=99 phase argument =2D added the missing ":" separator to the prefix wrapping =E2=80=94 if it= =20 does work without one (I didn't test), that's undocumented &=20 shouldn't be relied upon =2D removed unnecessary trailing / in =E2=80=98schemas/=E2=80=99 =2D and wrote a commit message as mostly documented in =E2=80=98info=20 (standards)Change Logs=E2=80=99. Thanks! T G-R [0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D36896#53 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl1/Y2YACgkQ2Imw8BjF STwCgA//a4I8r4E52kvXZ9uOt+x/kVe+aJ/eLz1xnN1fwQjILOAMy8phq4fM4HAx KxTK4GpaBJx9dlVGl32xHiKtrKAwcIx308SqIpokgKrnm0hTI+H0CXYRBUj5brso 3H6qMWLyzx2d9TvRlDynlfaiJHrbRoh2o/u8a9sx7tNS5fZXq968Rlsay4BOC7zW 8mSYMK7Ho6OjaOHZ2NVp7ioFgid2xZymQXBPkPYBlsm2mBGQMpR0E4QGuY59HzVi YcOPVOu+G8DIsywH+249ZjFAJxwjjHM5AszP5w2LCIhQCLV1PgZblUmLPTpvpzRG OoCZx8cRBoehHKlnoAJA52ECx6FBzkbmGJSNjKTnCWS+3uZu87JD3Li7NyOLMFwN 8hekrw9q0C/Ne9CnAYtGVQ2kMjMzzH5IRbj4S2nA19XqBbWmo6ZSNUAWsmH1ch4m x0XD5IO6X+hj1yQT2dnhY208DCQeskBKq01uZtGpYeh8KAPpQlaoiKyMAIeMYCDI rO5W/CKKWcOibt71An8UhdCFNzztt+OrRYqRmZmcuCemmG486E/zjG5Py+k/sm8r 6160St1h2/rtZlgvveuvmb9vpSBCAnqo5MSJXCRzKkSJxEY9P+7B6+F+HsiRVJz4 7NMVmT1aCDPBbZxtvcG2pUq8o+9Sw4CpnC7ea3YaTgsTJw4SFFU= =KFsa -----END PGP SIGNATURE----- --=-=-=--