From: Tobias Geerinckx-Rice via Bug reports for GNU Guix <bug-guix@gnu.org>
To: Martin Becze <mjbecze@riseup.net>
Cc: 36896-done@debbugs.gnu.org
Subject: bug#36896: [PATCH] added gsettings-desktop-schema to progragated inputs
Date: Mon, 16 Sep 2019 12:26:46 +0200 [thread overview]
Message-ID: <87h85c1qqh.fsf@nckx> (raw)
In-Reply-To: <35bfc691-74cf-dc3f-c704-15106bf45279@riseup.net>
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
Martin,
Martin Becze 写道:
> ping :P
Absolutely.
The diff you sent here[0] is incomplete (it relies on your
previous patch and doesn't have a header); please always send
git-formatted patches that apply directly to current master. They
are easier to merge and will be merged sooner.
> Yeah I don't know. I just used prefix in the latest patch. Let
> me know
> if the other method is preferred.
¯\_(ツ)_/¯
I've pushed this to master as
ad6e168b3f29576d92b00725dedbb38cd5f05e46 with the following
changes:
- Moved widowed ‘#:phases’ to the previous line (in well-formatted
Scheme, ‘(’ can never end a line and ‘)’ should never start
one), same for 'phase 'names
- then decided to move ’#:phases’ below ‘#:configure-flags’. This
is subjective, but since *flags ‘affect’ phases (never the other
way 'round) it felt right :-)
- dropped the unused ‘inputs’ phase argument
- added the missing ":" separator to the prefix wrapping — if it
does work without one (I didn't test), that's undocumented &
shouldn't be relied upon
- removed unnecessary trailing / in ‘schemas/’
- and wrote a commit message as mostly documented in ‘info
(standards)Change Logs’.
Thanks!
T G-R
[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36896#53
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-09-16 10:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 22:14 bug#36896: Evolution needs gsettings-desktop-schemas Martin Becze
2019-08-02 2:28 ` bug#36896: [PATCH] added gsettings-desktop-schema to progragated inputs null
2019-08-05 1:24 ` mjbecze
2019-08-05 11:40 ` Ricardo Wurmus
2019-08-05 19:17 ` Martin Becze
2019-08-05 20:30 ` Tobias Geerinckx-Rice
2019-08-20 13:04 ` Martin Becze
2019-08-27 8:23 ` Martin Becze
2019-09-03 15:47 ` Martin Becze
2019-09-03 15:59 ` Ricardo Wurmus
2019-09-04 11:09 ` Martin Becze
2019-09-04 12:17 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-09-06 9:59 ` Martin Becze
2019-09-06 10:30 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-09-06 11:49 ` Martin Becze
2019-09-10 13:05 ` Martin Becze
2019-09-16 10:26 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix [this message]
2019-08-17 14:33 ` bug#36896: [PATCH] wrapped evolution so that it know where its gsettings are Martin Becze
2019-08-17 14:35 ` Martin Becze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h85c1qqh.fsf@nckx \
--to=bug-guix@gnu.org \
--cc=36896-done@debbugs.gnu.org \
--cc=me@tobias.gr \
--cc=mjbecze@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).