From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#39926: Regression introduced by Shepherd 0.7.0 ('make
 check-system TESTS=btrfs-root-os' fails)
Date: Sat, 21 Mar 2020 14:44:23 +0100
Message-ID: <87h7yh3jrc.fsf@gnu.org>
References: <87wo7yswwy.fsf@gmail.com> <87blpa7m3j.fsf@gnu.org>
 <87a74skcb1.fsf@gmail.com> <875zfgkap0.fsf@gmail.com>
 <87v9n03s02.fsf@gnu.org> <877dzf3y0y.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:51419)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFeQx-0004Cf-Or
 for bug-guix@gnu.org; Sat, 21 Mar 2020 09:45:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFeQw-0006M9-OH
 for bug-guix@gnu.org; Sat, 21 Mar 2020 09:45:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40159)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jFeQw-0006L6-KG
 for bug-guix@gnu.org; Sat, 21 Mar 2020 09:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jFeQw-0007S1-H2
 for bug-guix@gnu.org; Sat, 21 Mar 2020 09:45:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.39926.D39926.158479827428583@debbugs.gnu.org>
In-Reply-To: <877dzf3y0y.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 20
 Mar 2020 10:23:57 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 39926-done@debbugs.gnu.org

Hi!

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> Hi Maxim,
>>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>>>
>>> [...]
>>>
>>>> Comparing with the above uname output, we can see that it validates the
>>>> hostname matches against "liberigilo", yet it is "gnu"!  Perhaps
>>>> Shepherd 0.7.0 introduced some problem with the hostname service?
>>>
>>> Another data point: the same happen when running './pre-inst-env make
>>> check-system TESTS=3Dinstalled-os', so this is not Btrfs specific.
>>
>> Fixed by be0a672c30ad1401019abb5cb83d59be171813d0.
>>
>> I wonder how this could have worked before: =E2=80=98reboot=E2=80=99 nev=
er gets a reply,
>> so it=E2=80=99s supposed to hang until it=E2=80=99s killed when the =E2=
=80=98user-processes=E2=80=99
>> service is stopped.
>>
>> Thanks,
>> Ludo=E2=80=99.
>
> Hey, weird!  Anyway, thanks for fixing it!  How did you debug this?  I'm =
curious.

I first noticed that the installation script ran to completion and that
the VM seems to stop properly.  Then I saw our code that did:

  (zero? (marionette-eval '(system #$script) marionette))

So I just tried adding:

  (pk (marionette-eval '(system "/run/current-system/profile/sbin/reboot")
                       marionette))

to the =E2=80=98basic=E2=80=99 test.  I noticed it would return 15, and the=
n I got it.

Nothing fancy, mostly stubbornness and perseverance.  :-)

Ludo=E2=80=99.