unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 41764-done@debbugs.gnu.org
Subject: bug#41764: `make authenticate` fails to find the keyring branch
Date: Sat, 24 Oct 2020 17:41:44 +0200	[thread overview]
Message-ID: <87h7qjhbrb.fsf@gmail.com> (raw)
In-Reply-To: <87h7qjk6pn.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sat, 24 Oct 2020 17:02:28 +0200")

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

Hi Ludo,

Thanks for the quick revision.

Ludovic Courtès <ludo@gnu.org> writes:
>>  # Authenticate the current Git checkout by checking signatures on every commit.
>> +GUIX_GIT_KEYRING = origin/keyring
>
> You need “?=” or users won’t be able to override it.

The macro definitions provided through the command line are equivalent
to adding these definitions to the end of the file, so this wouldn't
make any difference, so I leave it as only =.
>
> s/git/Git/ in the paragraph, but otherwise LGTM!  ‘origin/keyring’ is
> certainly a better default than ‘keyring’.

Pushed with this change as ef6596a20c to master.

Happy hacking!
Miguel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]

  reply	other threads:[~2020-10-24 15:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 18:54 bug#41764: `make authenticate` fails to find the keyring branch Leo Famulari
2020-06-09 16:16 ` Ludovic Courtès
2020-10-24 12:49   ` Miguel Ángel Arruga Vivas
2020-10-24 15:02     ` Ludovic Courtès
2020-10-24 15:41       ` Miguel Ángel Arruga Vivas [this message]
2020-08-07 12:33 ` guix-vits via web

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7qjhbrb.fsf@gmail.com \
    --to=rosen644835@gmail.com \
    --cc=41764-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).