From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SKyBFhROrV8oEgAA0tVLHw (envelope-from ) for ; Thu, 12 Nov 2020 15:00:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QARUEhROrV8tGgAAB5/wlQ (envelope-from ) for ; Thu, 12 Nov 2020 15:00:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C2DBB9404D3 for ; Thu, 12 Nov 2020 15:00:35 +0000 (UTC) Received: from localhost ([::1]:48634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdE5S-0003oI-HB for larch@yhetil.org; Thu, 12 Nov 2020 10:00:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdE4y-0003me-27 for bug-guix@gnu.org; Thu, 12 Nov 2020 10:00:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdE4w-0001vx-OE for bug-guix@gnu.org; Thu, 12 Nov 2020 10:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kdE4w-0005SV-MP for bug-guix@gnu.org; Thu, 12 Nov 2020 10:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 12 Nov 2020 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44353 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Mathieu Othacehe Received: via spool by 44353-submit@debbugs.gnu.org id=B44353.160519316920918 (code B ref 44353); Thu, 12 Nov 2020 15:00:02 +0000 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 14:59:29 +0000 Received: from localhost ([127.0.0.1]:45356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdE4O-0005RK-Ow for submit@debbugs.gnu.org; Thu, 12 Nov 2020 09:59:29 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:36584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdE4M-0005R6-0w for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 09:59:27 -0500 Received: by mail-qk1-f175.google.com with SMTP id r7so5484303qkf.3 for <44353@debbugs.gnu.org>; Thu, 12 Nov 2020 06:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xeBoIEGl5kOu+FCL+CYqdP9B5yBrqR1JLfbxMT1/jTw=; b=mREErsvscMryplnJZ3UYPwlxDy6AsQy1MWvp/TA1QRj7hxG/sqj9a2vrvH8Ytmr3TX Wbo7tJrGAbY6tApUkG8IOrFRZa+ym7ylzIduhJz3PsSpUh8wScmuBXQzCnSA++fInGtg R2xosCBLbgc0QArxNUOLpQwUM5zKhrnmyHSo7c6BLjHknWhv+vAKg2yjSF2l9Nunj6Al 3/h4mqV2HJvy8sg+d05g7q6ygF7e/BnlQr76jIOja7mSdNmmORnB0vSdqLtMrXzKVamI jfvSG+YP+kRzvcPeq4Z19D3eB3tp/I42wjBNndbmhP4IWkseu7S4iPQgnpjMNcVF8Tvp jW2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=xeBoIEGl5kOu+FCL+CYqdP9B5yBrqR1JLfbxMT1/jTw=; b=XUoJeHZWpbqVqUaPSK2OE+vroblAczXsWh3FBMbb6EdyHvW5bkvxQ/M/4fk3QJ/xN2 PYD6SMnxo8KSBV5nEFQ3bYWk3JqBu2gxMzH59MZ0ry0y8jE9Q9COGnGye/wXpQ6VuP1O Oqg4Lb+qSowWYO6nowlps2Gzzzq1bI/w9ZfIhTWxBWK/Egg92IQQVKQXezaDmRUNZ9KN ht4xDmbfPo2Nk3Q0NNwH1+KrkeJnICv0K57Gg+xbJ7bwK12JmtqIfI6LwR4mneFpuLoI iP1+H4cUeSVpwhEKWFSIx/kX4WP+gEz7LoUiCPOjPSFWDzLu6H1hQNlvo2iShMZPkz/+ aatg== X-Gm-Message-State: AOAM532Z+r+xLdiK8792dN3MITU1v9VpSm3fJ5LzksWNZf7XXDVD+RDc 0gXPO9QqYp/huB+veQCaAtc= X-Google-Smtp-Source: ABdhPJxlpFIZ7xGn1SobfbhKmNjOi53Cu1mmAQqmXKgGDOvtDcPS4MQ3Y3NpKNJo6a7WwBPtADjI9Q== X-Received: by 2002:a37:ac02:: with SMTP id e2mr92849qkm.243.1605193160230; Thu, 12 Nov 2020 06:59:20 -0800 (PST) Received: from hurd ([207.35.95.19]) by smtp.gmail.com with ESMTPSA id v6sm4708160qkh.83.2020.11.12.06.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 06:59:19 -0800 (PST) From: Maxim Cournoyer References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <877dqrvums.fsf@gnu.org> Date: Thu, 12 Nov 2020 09:59:18 -0500 In-Reply-To: <877dqrvums.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 12 Nov 2020 09:36:59 +0100") Message-ID: <87h7pufwop.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44353@debbugs.gnu.org, Jesse Gibbons Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=mREErsvs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: yigbFfC5VEis Hello Mathieu, Mathieu Othacehe writes: > Hello Maxim, > >> * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. >> (%default-options): Set its default value to #f. >> (show-help): Add help doc. >> * guix/scripts/system.scm (perform-action): Propagate option... >> (system-derivation-for-action): ...here. Use it to set the volatile-root? >> field of the image object passed to SYSTEM-IMAGE. >> * doc/guix.texi (Invoking guix system): Document it. > > This is a nice addition and it looks good to me. > > Thanks, > > Mathieu One thing I wasn't sure was if it'd be better to implicitly derive volatile-root? #f when image-type was specified (not (eq? 'guess)). The rationale being that users specifying the image-size themselves probably want to make use of extra space (assumption) but can't unless volatile-root? is #t on the image. If we choose the above it'd lead to less code and one less switch; on the other hand it is not as explicit. What do you think? Maxim