From: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Holger Peters <holger.peters@posteo.de>, 42771@debbugs.gnu.org
Subject: bug#42771: smalltalk fails to build
Date: Tue, 05 Jan 2021 13:09:15 +0100 [thread overview]
Message-ID: <87h7nv37ro.fsf@gmail.com> (raw)
In-Reply-To: <8735zhyrss.fsf@gnu.org> ("Ludovic Courtès"'s message of "Mon, 04 Jan 2021 10:28:35 +0100")
Bonne année, Ludo!
Ludovic Courtès <ludo@gnu.org> writes:
>> From c4385abde62bba4c634a7a874c2f431451909ec2 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
>> <rosen644835@gmail.com>
>> Date: Mon, 28 Dec 2020 10:36:48 +0100
>> Subject: [PATCH 1/2] gnu: smalltalk: Fix integer multiplication overflow.
>>
>> * gnu/packages/patches/smalltalk-multiplication-overflow.patch: Patch
>> from upstream commit 72ada189aba0283c551ead16635c1983968080b8.
>> * gnu/packages/smalltalk.scm (smalltalk): Use patch and link with gmp
>> and lightning libraries instead of the included source.
>> ---
>> .../smalltalk-multiplication-overflow.patch | 121 ++++++++++++++++++
>> gnu/packages/smalltalk.scm | 43 ++++++-
>
> Please make sure to add the patch to ‘gnu/local.mk’ as well. Otherwise
> LGTM.
Oops, I forgot about that, thank you. I've pushed with this change and
some extra comments about optional packages and closure size as
e3281657c8 to master.
>> From 46809e6c265280571ff024c749c448c74af79c1a Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
>> <rosen644835@gmail.com>
>> Date: Mon, 28 Dec 2020 11:42:31 +0100
>> Subject: [PATCH 2/2] gnu: smalltalk: Update to version 3.2.91.
>>
>> * gnu/packages/smalltalk.scm (smalltalk): Update to 3.2.91.
>>
>> Co-Authored-By: Holger Peters <holger.peters@posteo.de>
>
> LGTM.
I've pushed this, together with a comment about reverting to the mirror
when a new release be available, as df965a54e1 to master.
> Thanks for investigating!
I had it on my backlog from long time ago. Thank you for your
review. :-)
> We can address the non-reproducibility issues separately. Perhaps you
> can send your findings to bug-guix so we can keep track of it.
Sure; nonetheless, I think it will relate to two more generic issues I'm
opening too.
Happy hacking!
Miguel
next prev parent reply other threads:[~2021-01-05 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 18:53 bug#42771: smalltalk fails to build Michael Rohleder
2020-11-28 22:09 ` bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases Holger Peters
2020-12-04 11:34 ` Holger Peters
2020-12-04 12:06 ` Holger Peters
2020-11-29 8:43 ` Holger Peters
2020-12-05 14:30 ` Ludovic Courtès
2020-12-28 11:42 ` bug#42771: smalltalk fails to build Miguel Ángel Arruga Vivas
2021-01-04 9:28 ` Ludovic Courtès
2021-01-05 12:09 ` Miguel Ángel Arruga Vivas [this message]
2021-01-03 15:34 ` bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases Holger Peters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7nv37ro.fsf@gmail.com \
--to=rosen644835@gmail.com \
--cc=42771@debbugs.gnu.org \
--cc=holger.peters@posteo.de \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).