unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: Mathieu Othacehe <othacehe@gnu.org>, 39341-done@debbugs.gnu.org
Subject: bug#39341: Installer using 100% of a CPU core
Date: Sun, 25 Apr 2021 23:41:59 +0200	[thread overview]
Message-ID: <87h7juf3dk.fsf@gnu.org> (raw)
In-Reply-To: <87a766u9et.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 29 Jan 2020 00:19:22 -0500")

Hi!

(Cc: Florian + Mathieu)

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> While using the Guix 1.0.1 installer, I noticed that it was constantly
> maxing one of the cores on the machine.
>
> The guilty process is:
>
> USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
> root       377 99.8  0.3  37268 10328 ?        Rs   08:20 377:09 /gnu/store/8asv37pjsq3n4b4hgz9ys840f9j531hk-kmscon-0.0.0-1.01dd0a2/libexec/kmscon/kmscon --login --vt tty1 --no-switchvt --login -- /gnu/store/cb92798ps1xpla3ai14ik81vkl7jbw97-installer -p

Good news!  This is finally fixed:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d904abe0768293b2322dbf355b6e41d94e769d78

(Mathieu, Florian: let me know if anything looks fishy.)

The commit log says it all.  With this patch, a new FIFO is opened after
each keymap-change request so kmscon no longer polls on a stale file
descriptor.

I’ve verified that keymap choices in the installer are honored, that you
can change anytime via the F1 menu, and that there’s no file descriptor
leak in the kmscon process.

Now people will be less likely to hear the fan of their laptop right
from the start of the installation process.  :-)

Ludo’.




  reply	other threads:[~2021-04-25 21:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29  5:19 bug#39341: Installer using 100% of a CPU core Maxim Cournoyer
2021-04-25 21:41 ` Ludovic Courtès [this message]
2021-04-26 14:32   ` pelzflorian (Florian Pelz)
2021-04-26 16:07     ` Ludovic Courtès
2021-04-26 16:14       ` pelzflorian (Florian Pelz)
2021-04-27 10:38         ` Ludovic Courtès
2021-04-27 12:32           ` pelzflorian (Florian Pelz)
2021-04-27 17:43             ` Bengt Richter
2021-04-27 19:58               ` pelzflorian (Florian Pelz)
2021-04-27 21:26             ` Ludovic Courtès
2021-04-28  7:02               ` pelzflorian (Florian Pelz)
2021-04-28  7:06                 ` pelzflorian (Florian Pelz)
2021-04-28 13:43                 ` Ludovic Courtès
2021-04-28 15:20                   ` pelzflorian (Florian Pelz)
2021-04-29  9:33                   ` Mathieu Othacehe
2021-04-29  9:59                     ` Ludovic Courtès
2021-04-29 10:13                       ` Mathieu Othacehe
2021-04-29 10:47                     ` pelzflorian (Florian Pelz)
2021-04-28 15:22                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7juf3dk.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=39341-done@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).