unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Guillaume Le Vaillant <glv@posteo.net>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Jesse Gibbons <jgibbons2357@gmail.com>, 52913-done@debbugs.gnu.org
Subject: bug#52913: 0ad only builds fine with a specific version of mozjs
Date: Sun, 02 Jan 2022 12:56:25 +0000	[thread overview]
Message-ID: <87h7amwarj.fsf@kitej> (raw)
In-Reply-To: <b70e100000e1b213c4831857f229553b26075ed6.camel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> @Guillaume: From what I can gather from the build error, it appears as
> though the calling convention changed to require an additional
> parameter.  I've tracked down the relevant commit [1] and bug [2].
>
> Now obviously doing such a thing violates SemVer, so if rewriting 0ad
> with this and other changes in mind is not an option, I think having a
> hidden package for 0ad might be the lesser evil.
>
> Cheers
>
> [1]
> https://searchfox.org/mozilla-central/commit/a3c605929b16303e8a52ae9d99d5fe6769e8bf09
> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1681268

Thanks for the pointers.
I added a phase to fix the compatibility issue with mozjs-78.15, and
pushed as fea60a2fff443b9c172ed28bd37361e34e064f13.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2022-01-02 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-31  9:17 bug#52913: 0ad only builds fine with a specific version of mozjs Guillaume Le Vaillant
2022-01-01 19:14 ` Jesse Gibbons
2022-01-01 20:27   ` Liliana Marie Prikler
2022-01-02 12:56     ` Guillaume Le Vaillant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7amwarj.fsf@kitej \
    --to=glv@posteo.net \
    --cc=52913-done@debbugs.gnu.org \
    --cc=jgibbons2357@gmail.com \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).