From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QIpJHmMJ8GGnfwAAgWs5BA (envelope-from ) for ; Tue, 25 Jan 2022 15:29:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id COHYGmMJ8GH8RAEAauVa8A (envelope-from ) for ; Tue, 25 Jan 2022 15:29:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DCFFF33D0E for ; Tue, 25 Jan 2022 15:29:54 +0100 (CET) Received: from localhost ([::1]:36072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCMpV-00051H-UD for larch@yhetil.org; Tue, 25 Jan 2022 09:29:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCM3K-0004vU-Vm for bug-guix@gnu.org; Tue, 25 Jan 2022 08:40:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCM3G-0008CT-JV for bug-guix@gnu.org; Tue, 25 Jan 2022 08:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCM3G-0003JB-Gj for bug-guix@gnu.org; Tue, 25 Jan 2022 08:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#53355: guix shell --check: confusing error message Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 25 Jan 2022 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53355 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Chris Marusich Received: via spool by 53355-submit@debbugs.gnu.org id=B53355.164311799912704 (code B ref 53355); Tue, 25 Jan 2022 13:40:02 +0000 Received: (at 53355) by debbugs.gnu.org; 25 Jan 2022 13:39:59 +0000 Received: from localhost ([127.0.0.1]:47452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCM3D-0003Iq-IJ for submit@debbugs.gnu.org; Tue, 25 Jan 2022 08:39:59 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:56174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCM38-0003IX-GL for 53355@debbugs.gnu.org; Tue, 25 Jan 2022 08:39:57 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E62808B; Tue, 25 Jan 2022 14:39:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S1_bmFgNXHNm; Tue, 25 Jan 2022 14:39:47 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id BE2E45B3; Tue, 25 Jan 2022 14:39:46 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87h7a08kub.fsf@gmail.com> <87lez5td4n.fsf@gnu.org> <87sftc4osu.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 =?UTF-8?Q?Pluvi=C3=B4se?= an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 25 Jan 2022 14:39:46 +0100 In-Reply-To: <87sftc4osu.fsf@gmail.com> (Chris Marusich's message of "Mon, 24 Jan 2022 16:55:13 -0800") Message-ID: <87h79slysd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: E62808B X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 53355@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643120995; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=9KRwhtGrUrIxB1redMa90d3nuxhShqKaC/Ayjm/yjBw=; b=dwi9SW3+b0vhxorm5/h0bV0FwTE+cjHP5pfxzNybID5tVb17YuIi5WtVqIwr6Ch7K9U9GM DV+3gIEa5dAjq52hnLBOvyVTlbxoVQMiOQuLcpT2CNHUKnT5LRgfEFsFQSPkNKmk6+8roo SVtWFGn5ipl3ZXIMbwyZU0hzXX2fWq+mcLkr6Txs+moISx7KVdvv32FgIfKO/wXXFMyd8t QlJ0curkPFnQbJoJDi4OSRbTyrdVGPEib+eG1raIYs3CiFesrT+YGo0qZWI4CmFYP2ZGYZ dlLly+r/0hlSx7+oU7itlZTX5stQ50Y98Kj3EzNWr7NnRlPd4HURMOEmfLmijA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643120995; a=rsa-sha256; cv=none; b=GgVe+7Iou/AoM37IZMi/L8vNq/GDK9+19BPFGhYugyj1yDQVe2H4dmthllAxNg1q8yumqo gRTg91A3YNX2oyXqaIv5s0fbfWGBMHK0kxQ7LU3mfrlJuF8ie5cSBPX2N75VG4ZwpZyFTT sHeaBckspS12+A57izUJtHus00P1crWsE6tWkhrkmQKdjO2EZOIsJ+Vtj2TtP8k/CAagxF MiH8SwhUYOcfJeEZobbX7PybT7/3R8myOfXHe6ONVvOvNGHW7d/GmiODkn4WZZF3clhmCA 1h6z0GqnU+4awrLERrPjHPF1A1nzbd3m7Jl6oFQR6oDaog515sObCDxYY/e2DA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.13 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DCFFF33D0E X-Spam-Score: -5.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: vkYax05XTOrt Hi Chris, Chris Marusich skribis: > Ludovic Court=C3=A8s writes: > >> What=E2=80=99s confusing is that =E2=80=98--check=E2=80=99 does the same= job whether or not >> =E2=80=98--container=E2=80=99 is passed: it checks the behavior of your = shell *outside* >> a container. >> >> I think =E2=80=98--check=E2=80=99 should just do nothing when =E2=80=98-= -container=E2=80=99 is used, >> possibly emitting a warning saying it=E2=80=99s not doing anything (patch >> below). >> >> Now, the diagnostic is hopefully correct if you use, say, =E2=80=98--pur= e=E2=80=99 >> instead of =E2=80=98--container=E2=80=99. Could you check whether this = is the case? > > That sounds reasonable. I tested your patch. It now correctly emits a > warning when both --container and --check are provided. Great, I=E2=80=99ll commit it. > First, I tried without --pure or --container. Below, you can see that > it claims LIBRARY_PATH is missing, but it does not seem to be missing: [...] > Next, I tried with --pure and --check - once again, it claims > LIBRARY_PATH is missing, even though it does not seem to be missing: It looks like the shell-check machinery is misdiagnosing things, as Vagrant reported in (is this on Debian too?). Could you try the debugging tricks I proposed there? TIA, Ludo=E2=80=99.