From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KC8VEeZJgmLPZgAAbAwnHQ (envelope-from ) for ; Mon, 16 May 2022 14:56:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EFU/EOZJgmIlSwEAG6o9tA (envelope-from ) for ; Mon, 16 May 2022 14:56:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFF638A8B for ; Mon, 16 May 2022 14:56:05 +0200 (CEST) Received: from localhost ([::1]:59186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqaGb-0006xS-0a for larch@yhetil.org; Mon, 16 May 2022 08:56:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47048) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqaAk-0006Y3-R3 for bug-guix@gnu.org; Mon, 16 May 2022 08:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nqaAk-0003Np-EM for bug-guix@gnu.org; Mon, 16 May 2022 08:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nqaAk-0002Py-A2 for bug-guix@gnu.org; Mon, 16 May 2022 08:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55441: [cuirass] hang in "In progress..."; runs out of pgsql connections Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 16 May 2022 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55441 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 55441@debbugs.gnu.org, Mathieu Othacehe Received: via spool by 55441-submit@debbugs.gnu.org id=B55441.16527053789231 (code B ref 55441); Mon, 16 May 2022 12:50:02 +0000 Received: (at 55441) by debbugs.gnu.org; 16 May 2022 12:49:38 +0000 Received: from localhost ([127.0.0.1]:52065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqaAL-0002Op-KK for submit@debbugs.gnu.org; Mon, 16 May 2022 08:49:37 -0400 Received: from mail-qt1-f180.google.com ([209.85.160.180]:44898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqaAJ-0002OY-MX for 55441@debbugs.gnu.org; Mon, 16 May 2022 08:49:36 -0400 Received: by mail-qt1-f180.google.com with SMTP id i20so11897867qti.11 for <55441@debbugs.gnu.org>; Mon, 16 May 2022 05:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=VOJpJazdtnu+Tqquzi4x/W4a4MRB4ugyc+6jZm6qky4=; b=Yo2LaC8ZjnR/1wrQAcdrqiCgO2xVSLyFbKT7J9Z/a3pCqBl9mw+rOCmQ5/Vq7nN4Bx rxf9SvUMZRY3brm9OHfefTEnqH0QcR11VJq7HvOO3jan/69WYGgYjWOv/0gdU0/GmJ+i li5MAbePd8iLEig5FhuPpS1/CenA7pJgNJ2acNg1HdU6IV6EnvyaHFeWD3IG+LsaPvrK oo8Lftx0E1zsxd1qpEqFdC+VFcr14ctr1nowL/V3pHW/HOCmbVuQagVWXWdnrldR+HX0 gDWN6fRnvlGyuoYZq3eLzfNriv756E4knwGJvJErD1DjvDIvpepd+HVxPxTY4ptMjEAe CNig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=VOJpJazdtnu+Tqquzi4x/W4a4MRB4ugyc+6jZm6qky4=; b=Fb5BEh2k3y412jiBCMCJhc2T6nQrRcxUO6kTR0Zq3X/2IGZ3Q+hF151kPbx+RpnEGc N7kknYNR+tRdCtlQDkHm3onNCxmZYxPD2KJliDZtxEXrGgFRQIHjUbPYgmWyAe21lIcG yBKDbvUWcthUm4COSeUXmd8gPnpAm+MOwJ4aoy1AYJ5vsZfgx5tadHHFnMYrmWxt53Lo HVespEJcM+soQlJODzPUgOQHLppCWExE7JQfaHP0mxXOwoEpk+ZRAifQyE569YGJlgyF 18XKB80pdNemITDFrIOSM0U2hjmQnrmqRaDmg4QipEKzOu26IRM6w9MZwj1h6L9acSFL u8SQ== X-Gm-Message-State: AOAM530oHmS6xZANoW94fhnmKTnjlpJj30iD9Bh/sRZyHCHoMnvP7kGc vrJ6XncNquXLGqDFvfnJIqoPrt5F7Gd8tA== X-Google-Smtp-Source: ABdhPJyCaa+OqHYJQcPhu35LhQ3+DyElf9suo7KYuDSviUMIMetI++TJFXIL+a9gXAnCu9EOJ4MltA== X-Received: by 2002:ac8:5b04:0:b0:2f3:ec8f:1b0a with SMTP id m4-20020ac85b04000000b002f3ec8f1b0amr14990340qtw.327.1652705369930; Mon, 16 May 2022 05:49:29 -0700 (PDT) Received: from hurd (dsl-10-136-209.b2b2c.ca. [72.10.136.209]) by smtp.gmail.com with ESMTPSA id v7-20020ac873c7000000b002f39b99f692sm5691471qtp.44.2022.05.16.05.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 05:49:29 -0700 (PDT) From: Maxim Cournoyer References: <87fslcaznn.fsf@gmail.com> <87mtfj174l.fsf@gnu.org> <878rr2kug6.fsf_-_@gmail.com> <87pmke6ig4.fsf@gnu.org> <87o7zxalhu.fsf@gnu.org> Date: Mon, 16 May 2022 08:49:28 -0400 In-Reply-To: <87o7zxalhu.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 16 May 2022 11:13:17 +0200") Message-ID: <87h75pk5gn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652705765; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VOJpJazdtnu+Tqquzi4x/W4a4MRB4ugyc+6jZm6qky4=; b=trgAP9FCwkJpE4pvspD64/hivJfpMIZWIUybSKCMudLrw6u04BRBPM1kTjEAjCq2M88ToH EnmB2jn6FE8OZ6N3y4xfiiIjrt0F0NipMD9wGp9CYFwTE6NzbFuXSiyP3ozTZvYkBnjEsG 5FefOYZeudH4PN8VCCZb5l1P3ULu2Gm+o7/HAVXSgVqOs/1uIf17sPf/7WbwUsWZPB9Kct 3JQVfft3+gdErV1xMmbMgui/13yjhCqJRQUHAr/h330sQGfSa0xq5IZYFi5YJdjI/NOu07 GDYncszARPfbc0/1NpAQwRj5v0R9ur/I2J8iVh1J8wpcWz/LLykwIECXQAY7LQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652705765; a=rsa-sha256; cv=none; b=n8CQmMP4+Ol1NnOegoKuMA9Lz8uJRlqZTYRHYDANfyPIBwM6VEOJ2yLKXeaJLFq+iKbv/f DyisEH6vPJAN6kY31zpAM1PqrqtuHdR1b3bgnSutEzSeSSGKrtPebpRG1nG1NW04TS4ZRf Wz6J1O8qCp1wYj6L4tObgRrEVsTJMMPYIo9clL6cOVmYTGwhmDQqpX3TMgXVM++oKYT7pK TgQUZjm27k1HrVkujDEzgiXLu99UZWDPAUjVyZBUKz97Si6q8rHbRLVRsgrrXF5o7U0GKw iI+ubB1Z4dRraCvsiNdepUAaDWYyByiwYYlNKEtdnqgUGHQrLEAlv5PPYeY1sw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Yo2LaC8Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Yo2LaC8Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DFF638A8B X-Spam-Score: 5.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0OFX0KYv4aGx Hi Ludo and Mathieu! Ludovic Court=C3=A8s writes: > Hi! > > Mathieu Othacehe skribis: > >> I noticed this error: https://ci.guix.gnu.org/eval/320682/log/raw. >> >> The following lines can be caused by having a multi-threaded program: >> (cuirass scripts evaluate) because of its par-for-each procedure, call >> "primitive-fork" in open-bidirectional-pipe of (guix inferior). >> >> warning: call to primitive-fork while multiple threads are running; >> further behavior unspecified. See "Processes" in the >> manual, for more information. >> >> Not sure that it could cause the observed hang, Ludo what do you think? > > As you write, the warning comes from =E2=80=98open-bidirectional-pipe=E2= =80=99, added in > commit bd86bbd300474204878e927f6cd3f0defa1662a5. I noticed it back then > but as far as I could see, it was harmless (but definitely suboptimal): > > https://issues.guix.gnu.org/48007#11 Thanks for investigating it! I'm not yet very knowledgeable about POSIX threads and shortcomings, but this looks like a dangerous trap to have lying around :-). Is there an alternative implementation we could come up with that would avoid the potential problem (and warnings) entirely? Otherwise, if we are sure there are no practical problems in a multi-threaded scenario, I think a comment explaining the reasoning in the code (of why it's considered safe despite the warnings) and a test exercising the behavior would be in order to ensure it continues working as intended in the face of changes. Thoughts? Thanks again, Maxim