From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: "André Batista" <nandre@riseup.net>
Cc: 56398@debbugs.gnu.org
Subject: bug#56398: (guix git) fails to check out repos with nested submodules
Date: Thu, 04 Aug 2022 13:59:20 +0200 [thread overview]
Message-ID: <87h72smd7r.fsf@inria.fr> (raw)
In-Reply-To: <Yuuw9eo8UAA2ZYE3@andel> ("André Batista"'s message of "Thu, 4 Aug 2022 08:43:49 -0300")
Hello,
André Batista <nandre@riseup.net> skribis:
> Well, I guess ENOENT != GIT_ENOTFOUND and, in that case, I think we
> are better off gracefully failing to update it than trying to "branch"
> our local repo. The patch below tests for the directory's existence
> before proceding with the update. With this patch applied I've managed
> to refresh pytorch, its submodules and got the following code:
But you got a wrong hash I presume, because submodule weren’t actually
checked out, right?
> + (if (file-exists? directory)
> + ((lambda ()
> + (submodule-update submodule
> + #:fetch-options fetch-options)
The problem is that it papers over an actual libgit2 bug.
I think we should instead report it upstream. Do you feel like doing
it? I guess we’d need to give them the C version of the three-line
snippet I gave earlier.
WDYT?
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-08-04 12:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 15:02 bug#56398: (guix git) fails to check out repos with nested submodules Ludovic Courtès
2022-07-07 21:35 ` André Batista
2022-07-08 2:45 ` André Batista
2022-07-08 10:17 ` bokr
2022-08-04 12:01 ` André Batista
2022-07-08 8:26 ` Ludovic Courtès
2022-08-04 11:43 ` André Batista
2022-08-04 11:59 ` Ludovic Courtès [this message]
2022-08-05 20:10 ` André Batista
2022-08-05 22:40 ` André Batista
2022-11-24 15:17 ` André Batista
2022-11-24 23:51 ` bokr
2022-11-28 15:41 ` André Batista
2022-11-28 16:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h72smd7r.fsf@inria.fr \
--to=ludovic.courtes@inria.fr \
--cc=56398@debbugs.gnu.org \
--cc=nandre@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).